samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Riccomini" <criccom...@apache.org>
Subject Re: Review Request 28035: SAMZA-310-1
Date Mon, 24 Nov 2014 18:28:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28035/#review62826
-----------------------------------------------------------


Overall, looks very good to me. Some minor code nits. I haven't run the code in a real grid,
though.


docs/learn/documentation/versioned/jobs/logging.md
<https://reviews.apache.org/r/28035/#comment104962>

    No newline needed between "use" and "this".
    
    add: (add colon)



docs/learn/documentation/versioned/jobs/logging.md
<https://reviews.apache.org/r/28035/#comment104963>

    add: (colon)



samza-log4j/src/main/java/org/apache/samza/config/Log4jSystemConfig.java
<https://reviews.apache.org/r/28035/#comment104953>

    StreamAppender.



samza-log4j/src/main/java/org/apache/samza/logging/log4j/StreamAppender.java
<https://reviews.apache.org/r/28035/#comment104960>

    We will need to make this a little more pluggable, so that systems can use different serializers
for LoggingEvent (this one forces strings), but we can save that for a separate ticket.



samza-log4j/src/main/java/org/apache/samza/logging/log4j/StreamAppender.java
<https://reviews.apache.org/r/28035/#comment104958>

    assert job name not null or throw exception.


- Chris Riccomini


On Nov. 24, 2014, 9:16 a.m., Yan Fang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28035/
> -----------------------------------------------------------
> 
> (Updated Nov. 24, 2014, 9:16 a.m.)
> 
> 
> Review request for samza.
> 
> 
> Bugs: SAMZA-310
>     https://issues.apache.org/jira/browse/SAMZA-310
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> Added a log4j appender using SystemProducer
> Added a log4jConfig class to help get log4j specific config
> Unit test code
> 
> 
> Diffs
> -----
> 
>   build.gradle 828bce9 
>   docs/learn/documentation/versioned/jobs/configuration-table.html fbb5ea4 
>   docs/learn/documentation/versioned/jobs/logging.md 58e56c1 
>   samza-log4j/src/main/java/org/apache/samza/config/Log4jSystemConfig.java PRE-CREATION

>   samza-log4j/src/main/java/org/apache/samza/logging/log4j/StreamAppender.java PRE-CREATION

>   samza-log4j/src/test/java/org/apache/samza/config/TestLog4jSystemConfig.java PRE-CREATION

>   samza-log4j/src/test/java/org/apache/samza/logging/log4j/MockSystemFactory.java PRE-CREATION

>   samza-log4j/src/test/java/org/apache/samza/logging/log4j/MockSystemProducer.java PRE-CREATION

>   samza-log4j/src/test/java/org/apache/samza/logging/log4j/TestStreamAppender.java PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/28035/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Yan Fang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message