samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Riccomini" <criccom...@apache.org>
Subject Re: Review Request 28269: Fix for race contition in SAMZA-461
Date Thu, 20 Nov 2014 21:56:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28269/#review62435
-----------------------------------------------------------


Looks good. Couple of white-space nits. Could you add a test, please?


samza-core/src/main/scala/org/apache/samza/checkpoint/OffsetManager.scala
<https://reviews.apache.org/r/28269/#comment104480>

    Style: delete extra newline.



samza-core/src/main/scala/org/apache/samza/checkpoint/OffsetManager.scala
<https://reviews.apache.org/r/28269/#comment104478>

    Style: delete extra newline.


- Chris Riccomini


On Nov. 20, 2014, 1:31 a.m., Ben Kirwin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28269/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2014, 1:31 a.m.)
> 
> 
> Review request for samza.
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> Fixes SAMZA-461; defaults to the upcoming offset when the stream is empty.
> 
> 
> Diffs
> -----
> 
>   samza-core/src/main/scala/org/apache/samza/checkpoint/OffsetManager.scala 80c8d0e 
> 
> Diff: https://reviews.apache.org/r/28269/diff/
> 
> 
> Testing
> -------
> 
> Passes the existing test suite, and fixes the bug in my (external) integration tests.
> 
> 
> Thanks,
> 
> Ben Kirwin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message