Return-Path: X-Original-To: apmail-samza-dev-archive@minotaur.apache.org Delivered-To: apmail-samza-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2B98D17D3A for ; Thu, 30 Oct 2014 18:01:02 +0000 (UTC) Received: (qmail 6085 invoked by uid 500); 30 Oct 2014 18:01:02 -0000 Delivered-To: apmail-samza-dev-archive@samza.apache.org Received: (qmail 6030 invoked by uid 500); 30 Oct 2014 18:01:02 -0000 Mailing-List: contact dev-help@samza.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@samza.incubator.apache.org Delivered-To: mailing list dev@samza.incubator.apache.org Received: (qmail 6019 invoked by uid 99); 30 Oct 2014 18:01:01 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 30 Oct 2014 18:01:01 +0000 X-ASF-Spam-Status: No, hits=-1998.4 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 30 Oct 2014 18:00:59 +0000 Received: (qmail 96592 invoked by uid 99); 30 Oct 2014 17:58:09 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 30 Oct 2014 17:58:09 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 94C341DF5E5; Thu, 30 Oct 2014 17:58:13 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6255754625334061956==" MIME-Version: 1.0 Subject: Re: Review Request 27388: SAMZA-450 From: "Chris Riccomini" To: "samza" , "Chris Riccomini" Date: Thu, 30 Oct 2014 17:58:13 -0000 Message-ID: <20141030175813.7138.33271@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Chris Riccomini" X-ReviewGroup: Samza X-ReviewRequest-URL: https://reviews.apache.org/r/27388/ X-Sender: "Chris Riccomini" References: <20141030172943.7143.61041@reviews.apache.org> In-Reply-To: <20141030172943.7143.61041@reviews.apache.org> Reply-To: "Chris Riccomini" X-ReviewRequest-Repository: samza X-Virus-Checked: Checked by ClamAV on apache.org --===============6255754625334061956== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27388/ ----------------------------------------------------------- (Updated Oct. 30, 2014, 5:58 p.m.) Review request for samza. Repository: samza Description (updated) ------- export required to set JAVA_OPTS in run-class.sh wrappers export not needed since exec is used only override propertes if they're not set in task.opts for log4j.configuration samza.log.dir samza.container.name java.io.tmpdir Diffs (updated) ----- samza-core/src/main/scala/org/apache/samza/job/local/ThreadJobFactory.scala 766df7651064552923500fcbba959c343f2849f4 samza-shell/src/main/bash/checkpoint-tool.sh 5688b59e32e10f8eeff6ecfd3c3589d08ce8ba8e samza-shell/src/main/bash/kill-yarn-job.sh d42e08679510c9ed196764ed24965f067d8ace7d samza-shell/src/main/bash/run-am.sh 3a6d40d854208fd61403825c40747b95cb2a869e samza-shell/src/main/bash/run-class.sh 2395b59453d7d7b3adc65ba44269a3fa7238c4d3 samza-shell/src/main/bash/run-container.sh af00eba71171d0fc6158abdc9fba9dc9c56c17ef samza-shell/src/main/bash/run-job.sh d43b556bb0e4f57185c491105e506fd8c9642c1f samza-shell/src/main/bash/run-migration-tool.sh 7ac7f279672f73f6c31723845ce0d118dd8fd4bc Diff: https://reviews.apache.org/r/27388/diff/ Testing ------- Thanks, Chris Riccomini --===============6255754625334061956==--