samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Navina Ramesh" <nram...@linkedin.com>
Subject Re: Review Request 27246: Adding checkpoint migration tool SAMZA-354
Date Tue, 28 Oct 2014 21:17:12 GMT


On Oct. 27, 2014, 11 p.m., Navina Ramesh wrote:
> > Also, I want to confirm--you're developing this off of the 0.8.0 branch, not master,
right?
> 
> Navina Ramesh wrote:
>     I am developing off master branch :( Should I develop this off the 0.8.0 branch ?
> 
> Chris Riccomini wrote:
>     Yeah, develop off of 0.8. The reason I say that is that 0.9 (master) is currently
very turbulent due to my changes, and things like TaskNameToSystemStreamPartition are gone
in master.
>     
>     Since this tool is to migrate from 0.7 to 0.8, I think we should just include it
in the 0.8 branch (not master).
> 
> Chris Riccomini wrote:
>     Also, regarding testing, did you validate that the offsets were properly restored
after the migration? It should be shown in the logs.

Diff #2 is based off 0.8. 
Yes. I validated the offsets in the new topic for the hello-world job. I also upgraded the
test job to 0.8 and deployed. It worked fine.


- Navina


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27246/#review58703
-----------------------------------------------------------


On Oct. 28, 2014, 9:14 p.m., Navina Ramesh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27246/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2014, 9:14 p.m.)
> 
> 
> Review request for samza.
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> Adding checkpoint migration tool SAMZA-354
> 
> 
> Diffs
> -----
> 
>   build.gradle 64c223a 
>   samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointManagerFactory.scala
f7db2a1 
>   samza-kafka/src/main/scala/org/apache/samza/util/CheckpointMigrationTool.scala PRE-CREATION

>   samza-shell/src/main/bash/run-migration-tool.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/27246/diff/
> 
> 
> Testing
> -------
> 
> Created a test job "samza-migration-mp" using 0.7 version. Stopped the job and ran the
migration tool. Upgraded to 0.8 version and restarted the job. Works fine
> 
> 
> Thanks,
> 
> Navina Ramesh
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message