samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yan Fang" <yanfang...@gmail.com>
Subject Re: Review Request 27246: Adding checkpoint migration tool LISAMZA-594
Date Tue, 28 Oct 2014 16:22:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27246/#review58813
-----------------------------------------------------------



samza-kafka/src/main/scala/org/apache/samza/util/CheckpointMigrationTool.scala
<https://reviews.apache.org/r/27246/#comment99980>

    thinking if it is possible to put some of the methods, such as createTopic to org.apache.samza.util.KafkaUtil
, or move the KafkaHelper to a seprate class for reusing by other code, such as SAMZA-226,
SAMZA-310. Duplicating code seems awkward for me.


- Yan Fang


On Oct. 28, 2014, 2:06 a.m., Navina Ramesh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27246/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2014, 2:06 a.m.)
> 
> 
> Review request for samza.
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> Adding checkpoint migration tool LISAMZA-594
> 
> 
> Diffs
> -----
> 
>   build.gradle 828bce9913db00161971607e4c9ac19c63cecb95 
>   samza-kafka/src/main/scala/org/apache/samza/util/CheckpointMigrationTool.scala PRE-CREATION

>   samza-shell/src/main/bash/run-migration-tool.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/27246/diff/
> 
> 
> Testing
> -------
> 
> Created a test job "samza-migration-mp" using 0.7 version. Stopped the job and ran the
migration tool. Upgraded to 0.8 version and restarted the job. Works fine
> 
> 
> Thanks,
> 
> Navina Ramesh
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message