samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Riccomini" <criccom...@apache.org>
Subject Re: Review Request 27246: Adding checkpoint migration tool LISAMZA-594
Date Tue, 28 Oct 2014 15:28:56 GMT


On Oct. 27, 2014, 11 p.m., Navina Ramesh wrote:
> > Also, I want to confirm--you're developing this off of the 0.8.0 branch, not master,
right?
> 
> Navina Ramesh wrote:
>     I am developing off master branch :( Should I develop this off the 0.8.0 branch ?
> 
> Chris Riccomini wrote:
>     Yeah, develop off of 0.8. The reason I say that is that 0.9 (master) is currently
very turbulent due to my changes, and things like TaskNameToSystemStreamPartition are gone
in master.
>     
>     Since this tool is to migrate from 0.7 to 0.8, I think we should just include it
in the 0.8 branch (not master).

Also, regarding testing, did you validate that the offsets were properly restored after the
migration? It should be shown in the logs.


- Chris


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27246/#review58703
-----------------------------------------------------------


On Oct. 28, 2014, 2:06 a.m., Navina Ramesh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27246/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2014, 2:06 a.m.)
> 
> 
> Review request for samza.
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> Adding checkpoint migration tool LISAMZA-594
> 
> 
> Diffs
> -----
> 
>   build.gradle 828bce9913db00161971607e4c9ac19c63cecb95 
>   samza-kafka/src/main/scala/org/apache/samza/util/CheckpointMigrationTool.scala PRE-CREATION

>   samza-shell/src/main/bash/run-migration-tool.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/27246/diff/
> 
> 
> Testing
> -------
> 
> Created a test job "samza-migration-mp" using 0.7 version. Stopped the job and ran the
migration tool. Upgraded to 0.8 version and restarted the job. Works fine
> 
> 
> Thanks,
> 
> Navina Ramesh
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message