samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chinmay Soman" <chinmay.cere...@gmail.com>
Subject Re: Review Request 27246: Adding checkpoint migration tool LISAMZA-594
Date Tue, 28 Oct 2014 01:44:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27246/#review58746
-----------------------------------------------------------

Ship it!


Looks good overall ! Left some minor comments.


samza-kafka/src/main/scala/org/apache/samza/util/CheckpointMigrationTool.scala
<https://reviews.apache.org/r/27246/#comment99885>

    Missing format args



samza-kafka/src/main/scala/org/apache/samza/util/CheckpointMigrationTool.scala
<https://reviews.apache.org/r/27246/#comment99886>

    Same here



samza-kafka/src/main/scala/org/apache/samza/util/CheckpointMigrationTool.scala
<https://reviews.apache.org/r/27246/#comment99890>

    Do you also want to check if topic exists for oldCheckpointTopic ?



samza-kafka/src/main/scala/org/apache/samza/util/CheckpointMigrationTool.scala
<https://reviews.apache.org/r/27246/#comment99893>

    This method looks pretty big to me. Not strict - but if you could break it up into smaller
ones - that'll be nice.


- Chinmay Soman


On Oct. 27, 2014, 9:40 p.m., Navina Ramesh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27246/
> -----------------------------------------------------------
> 
> (Updated Oct. 27, 2014, 9:40 p.m.)
> 
> 
> Review request for samza.
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> Adding checkpoint migration tool LISAMZA-594
> 
> 
> Diffs
> -----
> 
>   build.gradle 828bce9913db00161971607e4c9ac19c63cecb95 
>   samza-kafka/src/main/scala/org/apache/samza/util/CheckpointMigrationTool.scala PRE-CREATION

>   samza-shell/src/main/bash/run-migration-tool.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/27246/diff/
> 
> 
> Testing
> -------
> 
> Created a test job "samza-migration-mp" using 0.7 version. Stopped the job and ran the
migration tool.
> 
> 
> Thanks,
> 
> Navina Ramesh
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message