samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Riccomini" <criccom...@apache.org>
Subject Re: Review Request 26992: SAMZA-438
Date Wed, 22 Oct 2014 21:12:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26992/
-----------------------------------------------------------

(Updated Oct. 22, 2014, 9:12 p.m.)


Review request for samza.


Bugs: SAMZA-438
    https://issues.apache.org/jira/browse/SAMZA-438


Repository: samza


Description (updated)
-------

adding a bit more logging


address feedback from reviewboard


revert changes to thread job since it doesn't need an http server


test samza container and json helpers


adding http server tests


remove jackson jaxrs in favor of jackson mapper asl


rework run-class.sh and run-container.sh to properly handle container ID while keeping backwards
compatible with samza.container.name in log4j files


add JobServlet constants for keys


add apache license to misc files


make yarn use HttpServer


remove jetty dependency from yarn


convert yarn to use the HttpServer in core


clean up json helpers to remove unused methods


make samza container read configs, ssp assignments, and changelog partition assignments from
job coordinator's http json server


add url reader util method


make all tests pass


add http server to AM


add http server to process and thread jobs


add servlet to serve config, container tasks, and task changelog partition mappings


Diffs (updated)
-----

  build.gradle 99f435486d8d2820b239bd33dff51f22b1a052a9 
  samza-api/src/main/java/org/apache/samza/container/SamzaContainerContext.java c8693c85377f559306f41b6130a7ef71e51b97f4

  samza-api/src/main/java/org/apache/samza/job/CommandBuilder.java f510ce54caf2075eada99aa355aad5c81e82824c

  samza-core/src/main/scala/org/apache/samza/config/ShellCommandConfig.scala 69cea2c573b6606371ba889c06f84c7788c2559d

  samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala d91d6d7940bd07a145dd3b782a9239f24bb5cf2e

  samza-core/src/main/scala/org/apache/samza/coordinator/server/HttpServer.scala PRE-CREATION

  samza-core/src/main/scala/org/apache/samza/coordinator/server/JobServlet.scala PRE-CREATION

  samza-core/src/main/scala/org/apache/samza/coordinator/server/ServletBase.scala PRE-CREATION

  samza-core/src/main/scala/org/apache/samza/job/ShellCommandBuilder.scala 7519117d093d16d0a44afdf2f328db0e63dec60c

  samza-core/src/main/scala/org/apache/samza/job/local/ProcessJob.scala c8d8bb89d97ad5928126ead0c8bb05c801662dcd

  samza-core/src/main/scala/org/apache/samza/job/local/ProcessJobFactory.scala 8125cbba9dad0943ac2f13e7ba28fd1acc0eee21

  samza-core/src/main/scala/org/apache/samza/util/JsonHelpers.scala PRE-CREATION 
  samza-core/src/main/scala/org/apache/samza/util/Util.scala 7d50352ae81e7399f68e9641f9b680e24e1e95ef

  samza-core/src/test/resources/scalate/css/ropa-sans.css PRE-CREATION 
  samza-core/src/test/scala/org/apache/samza/container/TestSamzaContainer.scala c20060140c4782e895fe770a6b02b1c02ac90304

  samza-core/src/test/scala/org/apache/samza/coordinator/server/TestHttpServer.scala PRE-CREATION

  samza-core/src/test/scala/org/apache/samza/coordinator/server/TestJobServlet.scala PRE-CREATION

  samza-core/src/test/scala/org/apache/samza/job/TestShellCommandBuilder.scala b186ec1b7aca861053ff5c99231a61af0139184f

  samza-core/src/test/scala/org/apache/samza/job/local/TestProcessJob.scala 7f3ccfe8a0c5ea50e10fb5a1959bcfe613f7c997

  samza-core/src/test/scala/org/apache/samza/util/TestUtil.scala 8c21901b2ae7fd966ef8065956eaade3bb774e52

  samza-shell/src/main/bash/run-am.sh 3a6d40d854208fd61403825c40747b95cb2a869e 
  samza-shell/src/main/bash/run-class.sh 2395b59453d7d7b3adc65ba44269a3fa7238c4d3 
  samza-shell/src/main/bash/run-container.sh af00eba71171d0fc6158abdc9fba9dc9c56c17ef 
  samza-test/src/main/scala/org/apache/samza/test/performance/TestKeyValuePerformance.scala
68e9e6648a31c36d485467a6955f75b51dc01322 
  samza-yarn/src/main/resources/scalate/WEB-INF/views/index.scaml 080b85585323968303a96c70a0541e87b2e2ccec

  samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMaster.scala ab8278f14174b2fcca778f33df0581eb5c072c31

  samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterLifecycle.scala 55ff0a859f0675b9c37976ec5115f1864dc8823f

  samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterMetrics.scala 52ede8d3d9d57e5f23846e3e3886cf6c972c3899

  samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterService.scala d1a73a78081d15cb27c8b3a5530289463d5721e2

  samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterState.scala 3872a84ca410f7f610c4e5b5504747bc72994102

  samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterTaskManager.scala 5b6cc814c8d461867cae4657cf7fba1d5558b7e9

  samza-yarn/src/main/scala/org/apache/samza/job/yarn/YarnJob.scala 03986b170f82d4584cab9905330c9251ca9a8c1d

  samza-yarn/src/main/scala/org/apache/samza/webapp/ApplicationMasterRestServlet.scala 27fbe2d6bf1b5b00ebac342f8490d0966e9042ff

  samza-yarn/src/main/scala/org/apache/samza/webapp/WebAppServer.scala 4eaaf7c2232e7641bac20887d894a8fa6aa4feb8

  samza-yarn/src/test/scala/org/apache/samza/job/yarn/TestSamzaAppMasterLifecycle.scala 6bf6aee3a4aa737b5ae071d0964854e1ad7a0bf2

  samza-yarn/src/test/scala/org/apache/samza/job/yarn/TestSamzaAppMasterService.scala a7ce241d5785638fb41110ba7b33269209dc64a8

  samza-yarn/src/test/scala/org/apache/samza/job/yarn/TestSamzaAppMasterTaskManager.scala
3f3154cf89a0328feb192e92049614a6ae58ff69 

Diff: https://reviews.apache.org/r/26992/diff/


Testing
-------


Thanks,

Chris Riccomini


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message