samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yan Fang" <yanfang...@gmail.com>
Subject Re: Review Request 26695: SAMZA-310: Publish container logs to a SystemStream
Date Tue, 21 Oct 2014 16:44:56 GMT


> On Oct. 21, 2014, 10:58 a.m., Martin Kleppmann wrote:
> > docs/learn/documentation/versioned/jobs/logging.md, line 77
> > <https://reviews.apache.org/r/26695/diff/2/?file=722320#file722320line77>
> >
> >     I found the parameter name "PartitionNumber" confusing -- it looks as though
it's specifying which partition number to produce to, but actually it's the number of partitions
for topic creation.
> >     
> >     Would it make sense to stick with the same convention of config parameters as
Kafka itself uses? That is, metadata.broker.list instead of BrokerList, zookeeper.connect
instead of Zookeeper, num.partitions instead of PartitionNumber, etc? Then it's easier for
people to find the description of the properties in the Kafka documentation.

i agree you. But the parameters for log4j is set by a setter/getter convention. Can not do
like setMetadata.broker() {}


- Yan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26695/#review57559
-----------------------------------------------------------


On Oct. 15, 2014, 4:49 p.m., Yan Fang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26695/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2014, 4:49 p.m.)
> 
> 
> Review request for samza.
> 
> 
> Bugs: SAMZA-310
>     https://issues.apache.org/jira/browse/SAMZA-310
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> Publish the logs to the Kafka topic
> 
> 
> Diffs
> -----
> 
>   docs/learn/documentation/versioned/jobs/logging.md 6739740 
>   samza-api/src/main/java/org/apache/samza/job/CommandBuilder.java f510ce5 
>   samza-core/src/main/scala/org/apache/samza/config/ShellCommandConfig.scala 69cea2c

>   samza-core/src/main/scala/org/apache/samza/job/ShellCommandBuilder.scala 7519117 
>   samza-kafka/src/main/scala/org/apache/samza/util/KafkaLog4jAppender.scala PRE-CREATION

>   samza-kafka/src/main/scala/org/apache/samza/util/KafkaUtil.scala d660b91 
>   samza-kafka/src/main/scala/org/apache/samza/util/TaskIdPartitioner.scala PRE-CREATION

>   samza-kafka/src/test/scala/org/apache/samza/util/TestKafkaLog4jAppender.scala PRE-CREATION

>   samza-kafka/src/test/scala/org/apache/samza/util/TestKafkaUtil.scala PRE-CREATION 
>   samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterTaskManager.scala
5b6cc81 
> 
> Diff: https://reviews.apache.org/r/26695/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Yan Fang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message