From commits-return-23992-apmail-samza-commits-archive=samza.apache.org@samza.apache.org Fri Feb 28 18:30:05 2020 Return-Path: X-Original-To: apmail-samza-commits-archive@minotaur.apache.org Delivered-To: apmail-samza-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id 6F5D719182 for ; Fri, 28 Feb 2020 18:30:05 +0000 (UTC) Received: (qmail 86277 invoked by uid 500); 28 Feb 2020 18:30:05 -0000 Delivered-To: apmail-samza-commits-archive@samza.apache.org Received: (qmail 86258 invoked by uid 500); 28 Feb 2020 18:30:04 -0000 Mailing-List: contact commits-help@samza.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@samza.apache.org Delivered-To: mailing list commits@samza.apache.org Received: (qmail 86249 invoked by uid 99); 28 Feb 2020 18:30:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 28 Feb 2020 18:30:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 4EF191A412F for ; Fri, 28 Feb 2020 18:30:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -112.49 X-Spam-Level: X-Spam-Status: No, score=-112.49 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_DMARC_STATUS=0.01, KAM_NUMSUBJECT=0.5, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-ec2-va.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id utHyttUShvzj for ; Fri, 28 Feb 2020 18:30:02 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=207.244.88.153; helo=mail.apache.org; envelope-from=jira@apache.org; receiver= Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx1-ec2-va.apache.org (ASF Mail Server at mx1-ec2-va.apache.org) with SMTP id 39A20BB80F for ; Fri, 28 Feb 2020 18:30:02 +0000 (UTC) Received: (qmail 86232 invoked by uid 99); 28 Feb 2020 18:30:02 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 28 Feb 2020 18:30:01 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 5B284E0239 for ; Fri, 28 Feb 2020 18:30:01 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id 409F87805DB for ; Fri, 28 Feb 2020 18:30:00 +0000 (UTC) Date: Fri, 28 Feb 2020 18:30:00 +0000 (UTC) From: "Lakshmi Manasa Gaduputi (Jira)" To: commits@samza.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (SAMZA-2476) Fix flaky tests introduced in PR-1239 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 Lakshmi Manasa Gaduputi created SAMZA-2476: ---------------------------------------------- Summary: Fix flaky tests introduced in PR-1239 Key: SAMZA-2476 URL: https://issues.apache.org/jira/browse/SAMZA-2476 Project: Samza Issue Type: Task Reporter: Lakshmi Manasa Gaduputi Assignee: Lakshmi Manasa Gaduputi Travis builds occasionally fail with=C2=A0 {code:java} org.apache.samza.system.azureblob.avro.TestAzureBlobOutputStream.testCloseM= ultipleBlocks org.mockito.exceptions.misusing.UnfinishedStubbingException: 1753 =20 Unfinished stubbing detected here:1754 =20 -> at org.apache.samza.system.azureblob.avro.TestAzureBlobOutputStream.test= CloseMultipleBlocks(TestAzureBlobOutputStream.java:235) E.g. thenReturn() may be missing. Examples of correct stubbing: when(mock.isOk()).thenReturn(true); =20 when(mock.isOk()).thenThrow(exception); =20 doThrow(exception).when(mock).someVoidMethod(); Hints: 1. missing thenReturn() 2. you are trying to stub a final method, you naughty developer! 3: you are stubbing the behaviour of another mock inside before 'thenRe= turn' instruction if completed at org.apache.samza.system.azureblob.avro.TestAzureBlobOutputStream= .testCloseMultipleBlocks(TestAzureBlobOutputStream.java:241){code} =C2=A0 -- This message was sent by Atlassian Jira (v8.3.4#803005)