samza-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [samza] shanthoosh commented on a change in pull request #1222: SAMZA-2396: Support dynamic addition of jars in ReflectionUdfResolver.
Date Fri, 22 Nov 2019 03:36:30 GMT
shanthoosh commented on a change in pull request #1222: SAMZA-2396: Support dynamic addition
of jars in ReflectionUdfResolver.
URL: https://github.com/apache/samza/pull/1222#discussion_r349421456
 
 

 ##########
 File path: samza-sql/src/main/java/org/apache/samza/sql/udf/ReflectionBasedUdfResolver.java
 ##########
 @@ -49,20 +54,26 @@
   private static final Logger LOG = LoggerFactory.getLogger(ReflectionBasedUdfResolver.class);
 
   private static final String CONFIG_PACKAGE_PREFIX = "samza.sql.udf.resolver.package.prefix";
 
 Review comment:
   Discussed offline. We'd planned to proceed with having both the configurations for now.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message