samza-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yan Fang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SAMZA-144) Add stream-level overrides for KafkaSystemFactory config
Date Sat, 07 Jun 2014 00:43:01 GMT

    [ https://issues.apache.org/jira/browse/SAMZA-144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14020587#comment-14020587
] 

Yan Fang commented on SAMZA-144:
--------------------------------

Thanks for the reviewing, [~criccomini]!

Made the changes based on your comment. Explained in RB.

RB: https://reviews.apache.org/r/22276/

Thank you.

> Add stream-level overrides for KafkaSystemFactory config
> --------------------------------------------------------
>
>                 Key: SAMZA-144
>                 URL: https://issues.apache.org/jira/browse/SAMZA-144
>             Project: Samza
>          Issue Type: Bug
>          Components: kafka
>    Affects Versions: 0.6.0
>            Reporter: Chris Riccomini
>            Assignee: Yan Fang
>         Attachments: SAMZA-144.patch
>
>
> Currently, we allow Kafka systems to be defined with:
> {noformat}
> systems.my-kafka-system.consumer.*
> {noformat}
> And:
> {noformat}
> systems.my-kafka-system.producer.*
> {noformat}
> We don't support stream-level configurations, the way we do with StreamConfig configuration:
> {code}
>   val STREAM_PREFIX = "systems.%s.streams.%s."
>   val MSG_SERDE = STREAM_PREFIX + "samza.msg.serde"
>   val KEY_SERDE = STREAM_PREFIX + "samza.key.serde"
>   val CONSUMER_RESET_OFFSET = STREAM_PREFIX + "samza.reset.offset"
> {code}
> We should add stream-level configuration override support for Kafka consumer and producers
with:
> {noformat}
> systems.my-kafka-system.streams.my-kafka-topic.consumer.*
> systems.my-kafka-system.streams.my-kafka-topic.producer.*
> {noformat}
> KafkaConfig and KafkaSystemFactory should be updated to handle these.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message