Mailing-List: contact dev-help@samoa.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@samoa.incubator.apache.org
From: gdfm <git@git.apache.org>
To: dev@samoa.incubator.apache.org
Reply-To: dev@samoa.incubator.apache.org
References: <git-pr-48-incubator-samoa@git.apache.org>
In-Reply-To: <git-pr-48-incubator-samoa@git.apache.org>
Subject: [GitHub] incubator-samoa pull request: Patch for SAMOA-58 (Samoa
 AvroFileSt...
Content-Type: text/plain
Message-Id: <20160306111243.E9418DFBED@git1-us-west.apache.org>
Date: Sun,  6 Mar 2016 11:12:43 +0000 (UTC)

Github user gdfm commented on a diff in the pull request:

    https://github.com/apache/incubator-samoa/pull/48#discussion_r55137026
  
    --- Diff: samoa-api/src/main/java/org/apache/samoa/moa/streams/AvroFileStream.java ---
    @@ -140,7 +140,8 @@ protected boolean readNextInstanceFromFile() {
       public void prepareForUseImpl(TaskMonitor monitor, ObjectRepository repository) {
         super.prepareForUseImpl(monitor, repository);
         String filePath = this.avroFileOption.getFile().getAbsolutePath();
    -    this.fileSource.init(filePath, AvroFileStream.AVRO_FILE_EXTENSION);
    +    //this.fileSource.init(filePath, AvroFileStream.AVRO_FILE_EXTENSION);
    +    this.fileSource.init(filePath, null);
    --- End diff --
    
    Could you explain this change?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---