From users-return-966-archive-asf-public=cust-asf.ponee.io@royale.apache.org Wed Apr 4 12:15:38 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 6425818064F for ; Wed, 4 Apr 2018 12:15:37 +0200 (CEST) Received: (qmail 13890 invoked by uid 500); 4 Apr 2018 10:15:36 -0000 Mailing-List: contact users-help@royale.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: users@royale.apache.org Delivered-To: mailing list users@royale.apache.org Received: (qmail 13880 invoked by uid 99); 4 Apr 2018 10:15:36 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Apr 2018 10:15:36 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 13B8F18070D for ; Wed, 4 Apr 2018 10:15:36 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.25 X-Spam-Level: X-Spam-Status: No, score=0.25 tagged_above=-999 required=6.31 tests=[KAM_LOTSOFHASH=0.25] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id e2a34buY0QB4 for ; Wed, 4 Apr 2018 10:15:32 +0000 (UTC) Received: from WIN-CMCMLBH19BL.vconn.com.pk (static.39.34.130.94.clients.your-server.de [94.130.34.39]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id AB4025F1F0 for ; Wed, 4 Apr 2018 10:15:31 +0000 (UTC) Received: from aleenaPC ([58.65.129.193]) by vconn.com.pk with MailEnable ESMTPA; Wed, 4 Apr 2018 12:15:29 +0200 From: "Alina Kazi" To: References: <002a01d3c750$23eb7160$6bc25420$@d-bz.com> <000301d3c7e8$97971f40$c6c55dc0$@d-bz.com> <000301d3c80f$ff15cdc0$fd416940$@d-bz.com> <000e01d3c818$dac3c630$904b5290$@d-bz.com> <1522412019043-0.post@n8.nabble.com> <000901d3ca48$fc9278b0$f5b76a10$@d-bz.com> <000301d3ca6c$e71d4450$b557ccf0$@d-bz.com> <000b01d3ca77$e6261210$b2723630$@d-bz.com> <001101d3cb14$986c1180$c9443480$@d-bz.com> <002b01d3cb46$78384820$68a8d860$@d-bz.com> <002401d3cbd6$fa049300$ee0db900$@d-bz.com> <005001d3cbe3$772fea80$658fbf80$@d-bz.com> In-Reply-To: <005001d3cbe3$772fea80$658fbf80$@d-bz.com> Subject: RE: Work on Emulation Date: Wed, 4 Apr 2018 15:15:09 +0500 Message-ID: <002201d3cbfd$d7780d90$866828b0$@d-bz.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQJdAZr8DLMpQb/p0e7BCaXcEai6oQJYpJCbAY2c5lcCFVANgAH+I6NgAWe7F5kBHsg2ZQIDj7qhAXQYf7UBRhgegwLYNleTAnGP89gCRBjeLAERhI39ArvCZFcBhoA9VQDTMOPYAlFK+ooCBsQbYQI9/13QAgHU1BMBIBWI6AFkg4fWAWfWC8ahkj87IA== Content-Language: en-us Branch->mxRoyaleTileandTileDirection https://github.com/alinakazi/royale-asjs/tree/mxRoyaleTileandTileDirectio= n Pull Request :https://github.com/apache/royale-asjs/pull/143 Tile.as TileDirection.as Branch->MxRoyaleCloseEvent https://github.com/alinakazi/royale-asjs/tree/MxRoyaleCloseEvent Pull Request :https://github.com/apache/royale-asjs/pull/144 CloseEvent.as Branch->mxRoyaleScrollPolicynControlBar https://github.com/alinakazi/royale-asjs/tree/mxRoyaleScrollPolicynContro= lBar Pull Request :https://github.com/apache/royale-asjs/pull/145 ScrollPolicy.as ControlBar.as Please Review. Thanks, Alina Kazi -----Original Message----- From: Alina Kazi [mailto:alina.kazi@d-bz.com]=20 Sent: Wednesday, April 04, 2018 12:06 PM To: users@royale.apache.org Subject: RE: Work on Emulation Hi Alex, Tile and Tile Direction are ready for Review. And Now, I am working on CloseEvent. Thanks, Alina -----Original Message----- From: Alex Harui [mailto:aharui@adobe.com] Sent: Wednesday, April 04, 2018 11:14 AM To: users@royale.apache.org Subject: Re: Work on Emulation Hi Alina, Peter meant that the changing of mx_internal to protected was only = temporary. mx_internal should be working for Royale so please use = mx_internal instead of protected. Using protected may cause other = things to not work. Thanks, -Alex From: Alina Kazi Reply-To: "users@royale.apache.org" Date: Tuesday, April 3, 2018 at 10:36 PM To: "users@royale.apache.org" Subject: RE: Work on Emulation Thanks. replaced mx_internal with protected for now. And Tile and TileDirection are compiled Successfully without any = warning. =20 Alina Kazi =20 =20 From: Peter Ent [mailto:pent@adobe.com] Sent: Tuesday, April 03, 2018 5:33 PM To: users@royale.apache.org Subject: Re: Work on Emulation =20 I recommended changing mx_internal to protected as a stop-gap. I knew = Alex would be putting something out for MXRoyale. =20 Also: please update the Github issue with your progress. I've been = trying to be consistent using it as more people working on the same = items will be confusing. =20 https://github.com/apache/royale-asjs/issues/136 =20 Thanks. Peter =20 From: Piotr Zarzycki Reply-To: "users@royale.apache.org" Date: Tuesday, April 3, 2018 at 8:26 AM To: "users@royale.apache.org" Subject: Re: Work on Emulation =20 Hi Alina, =20 If it is mx_internal I see suggestion to change it to some = protected/private ? I'm not sure about that, but the other way is to got = with suggestion - create getter/setter. Alex also in his suppress warnings in that commits [1] =20 [1] https://github.com/apache/royale-asjs/commit/3cfa84f95635df16e5f6b8214b48= 3a e4c68a902c =20 Thanks, Piotr =20 2018-04-03 14:22 GMT+02:00 Alina Kazi : Thanks Alex Now I am working on : Tile and TileDirection Both files are compiled successfully after changes Pull Request : https://github.com/apache/royale-asjs/pull/143 =20 Only a Warning in Tile.as What I should do to remove that warning [java] = D:\outtest\royale-asjs\frameworks\projects\MXRoyale\src\main\royale\ mx\containers\Tile.as(277): col: 5 public var may not work in minified = JS output . Use getter/setter instead. [java] [java] mx_internal var cellWidth:Number; =20 Thanks, Alina Kazi From: Alex Harui [mailto:aharui@adobe.com] Sent: Tuesday, April 03, 2018 12:27 PM To: users@royale.apache.org Subject: Re: Work on Emulation =20 Hi Alina, =20 Congratulations! I merged your pull request. You have now contributed = code to Apache Royale. =20 You should be able to use mx_internal now. I pushed those changes = earlier. =20 I'm done for today, hopefully Peter or Piotr will review the Hrule/Vrule = pull request. Please make sure there are no warnings in the build. I = updated ListEvent and SliderEvent to suppress warnings. =20 Thanks, -Alex =20 From: Alina Kazi Reply-To: "users@royale.apache.org" Date: Monday, April 2, 2018 at 11:25 PM To: "users@royale.apache.org" Subject: RE: Work on Emulation =20 Thanks alot Peter and Alex. HRule and VRule Files are added to new Branch and Compiled Successfully = https://github.com/alinakazi/royale-asjs/tree/alinakazi-HRuleVRule/framew= or ks/projects/MXRoyale/src/main/royale/mx/controls =20 In Panel : I will also replace =E2=80=9Cmx_internal=E2=80=9C with = "protected" And comment-out all functions and/or variables that referencing = something not yet ported. =20 Alina Kazi From: Alex Harui [mailto:aharui@adobe.com] Sent: Monday, April 02, 2018 8:28 PM To: users@royale.apache.org Subject: Re: Work on Emulation =20 Hi Alina, =20 mx_internal methods may not need to be ported. If they are not listed = in the list of API s you used in your app, the next question is whether = they are needed to emulate the functionality of the component that you = do use. In many cases they are not needed. =20 I am working on getting mx_internal working on the JS side. Even though = mx_internal APIs are not supported by Flex, I don't doubt that other = namespaces are used somewhere so we should try to get it to work. It = has been working in simple test cases so not sure yet why it isn't = working in the emulation components. =20 Thanks, -Alex =20 From: Peter Ent Reply-To: "users@royale.apache.org" Date: Monday, April 2, 2018 at 7:06 AM To: "users@royale.apache.org" Subject: Re: Work on Emulation =20 Hi Alina, =20 Sorry for the delayed response. =20 First, try to port over something easier like VRule and HRule as a first = step since these are less complex. =20 As for mx_internal - I have been changing these to "protected". =20 Once you do that you'll find that you will also need IUITextField. I = haven't done that but I just took a look at it. You can do a couple of = things: =20 In Panel (and any where else), comment-out any function or variable that = references something not yet ported. We are trying to pass compilation, = so that would be OK at this stage. =20 If you feel you need to bring something else over, then you have to go = through the same process of course. Since you can wind up following = class and interface down a long chain, I would just comment-out things = complex. Sometimes I am left with "implements IUIComponent" and the rest = of the interfaces listed in a class are put into comments. =20 I hope that helps. =E2=80=94peter =20 From: Alina Kazi Reply-To: "users@royale.apache.org" Date: Monday, April 2, 2018 at 7:43 AM To: "users@royale.apache.org" Subject: RE: Work on Emulation =20 mx.containers.Panel Panel.as file contains many variables and methods that are using = mx_internal e.g. Variable mx_internal var _showCloseButton:Boolean =3D false; =20 Method mx_internal function getStatusTextField():IUITextField { return statusTextField; } As use namespace mx_internal; and import mx.core.mx_internal; are = commented in source files . I am getting errors on these variables and methods e.g. [java] D:\out\royale-asjs\frameworks\projects\MXRoyale\src\main\royale\mx\contai= ne rs\Panel.as(1796): col: 6 function 'getStatusTextField' will be scoped to the default namespace: mx.containers.Panel: internal.=20 It will not be visible outside of this package. [java] [java] function getStatusTextField():IUITextField =20 Should I comment all of these variables and methods ? Or Should I make all of these variables and methods Public? =20 For Reference, I am sharing link. So you don't need to find this file in = flex-sdk , You can find the at: Flex-sdk mx.containers.Panel: https://www.dropbox.com/s/6xb1jp2efwuwnam/PanelFlex.as?dl=3D0 Royale :https://github.com/alinakazi/royale-asjs/blob/mxRoyalePanel/frameworks/p= ro jects/MXRoyale/src/main/royale/mx/containers/Panel.as =20 Thanks in Advance. Alina =20 From: Alina Kazi [mailto:alina.kazi@d-bz.com] Sent: Monday, April 02, 2018 3:25 PM To: users@royale.apache.org Subject: RE: Work on Emulation =20 =20 Thanks J New branch Created : https://github.com/alinakazi/royale-asjs/tree/mxRoyalePanel =20 Copied MX Panel from flex-sdk to New branch (mxRoyalePanel) Pull Request = : https://github.com/apache/royale-asjs/pull/141 =20 -Alina Kazi =20 =20 From: Piotr Zarzycki [mailto:piotrzarzycki21@gmail.com] Sent: Monday, April 02, 2018 1:22 PM To: users@royale.apache.org Subject: Re: Work on Emulation =20 Alina, =20 You cannot delete pull request. You can only close it, so we are good = with 139 and 140. They are closed. =20 Your pull request 138 now looks great! :) =20 Whenever you are going to push some bigger changes you should create new = branches. If you are working right now on Panel - probably new branch = with your changes would be the best. Our pull request will looks than = cleaner. - That is just my recommendation. =20 In general congrats for your first pull request to Apache Royale = project!! :) =20 Thanks, Piotr =20 2018-04-02 8:08 GMT+02:00 Alina Kazi : Hi Piotr, Thanks Piotr. I am trying to add another pull request for SliderEvent.as file. but = when I added this file manually at = https://github.com/alinakazi/royale-asjs/tree/mxRoyaleAQ/frameworks/proje= ct s /MXRoyale/src/main/royale/mx/events and commit it. Commit auto added to previous Pull Request : https://github.com/apache/royale-asjs/pull/138 Is it ok to do multiple commits on same pull Request instead of creating = New Pull Request for each file? How Can I delete these Closed Pull Requests? https://github.com/apache/royale-asjs/pull/139 and https://github.com/apache/royale-asjs/pull/140 -Alina -----Original Message----- From: piotrz [mailto:piotrz@apache.org] Sent: Friday, March 30, 2018 5:14 PM To:=20 users@royale.apache.org Subject: Re: Work on Emulation I see your new pull request and it doesn't looks good. [1] As you can = see on the screenshot you did it against develop from feature/MXRoyale = and it contains 94 commits. > The old one is being done correctly. You have used your branch -> apache:feature/MXRoyale from alinakazi:mxRoyaleAQ > [1]=20 https://github.com/apache/royale-asjs/pull/139/commits Thanks, Piotr -- Sent from:=20 http://apache-royale-users.20374.n8.nabble.com/ =20 -- Piotr Zarzycki=20 Patreon: https://www.patreon.com/piotrzarzycki =20 -- Piotr Zarzycki=20 Patreon: https://www.patreon.com/piotrzarzycki