From dev-return-6836-archive-asf-public=cust-asf.ponee.io@royale.apache.org Tue Oct 2 18:36:57 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id E2B98180638 for ; Tue, 2 Oct 2018 18:36:56 +0200 (CEST) Received: (qmail 41287 invoked by uid 500); 2 Oct 2018 16:36:56 -0000 Mailing-List: contact dev-help@royale.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@royale.apache.org Delivered-To: mailing list dev@royale.apache.org Received: (qmail 41275 invoked by uid 99); 2 Oct 2018 16:36:55 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Oct 2018 16:36:55 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id E6AFE1A21DC for ; Tue, 2 Oct 2018 16:36:54 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.312 X-Spam-Level: **** X-Spam-Status: No, score=4.312 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_INFOUSMEBIZ=0.75, KAM_LOTSOFHASH=0.25, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URI_HEX=1.313] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id JTYyZ4dJrSn5 for ; Tue, 2 Oct 2018 16:36:52 +0000 (UTC) Received: from mail-lf1-f68.google.com (mail-lf1-f68.google.com [209.85.167.68]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id F04045F51F for ; Tue, 2 Oct 2018 16:36:51 +0000 (UTC) Received: by mail-lf1-f68.google.com with SMTP id s10-v6so1906388lfc.9 for ; Tue, 02 Oct 2018 09:36:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=fLRwm+ZBWKVBOify2B9tIx2AYz5GzKsFZFC67TDS/YI=; b=sOw7//kukZUfqjorarn+9eWO+G0XUmW4RrPTa015+A3QhBJE99ItkWPyiKU3Z18cvm goOetEzACAmc+1mqSGyiOxmoFY0d3iJZ7g0DjlxMcxvo+EZjAwKXTaeL5SvrttCW0Eyj DRuUw0UxNlBpiY50e5jw4VmNMCGI9C67VpQ4LoM5XjNFgRzAOqNIjpXvTG8T3/ZGEFCY p/u+dJogm7/uKG/k5S8ouJNRcgyuCz1/urS/VSQtH7RLUW8GQu0NhqFga0ZaB3fIgkZZ lJcI/WJrEBUiWyowDGia3rrWp5aYFKFnok64d8yJ0OBT0K7WR52ALAU5VC5f4tZW9T4v pRHA== X-Gm-Message-State: ABuFfoiAtc4w40nJElv+eQZVFiDtMifoflkRQDXA5CeB1RxU5wp0l1hT bTBNGwwHA7FuI/3gUVWtdFujs6GXhFqJyyWPtXS8Ng== X-Google-Smtp-Source: ACcGV62qVBoRFy9OeeUWyhlQBI6BQpOHQfyS+Y48lN9N1ZmK3yTJY8Kv8wwQo7IikzztyZUFUq8tTaOHEt/zU6vVj3Q= X-Received: by 2002:a19:f00a:: with SMTP id p10-v6mr8636142lfc.43.1538498204133; Tue, 02 Oct 2018 09:36:44 -0700 (PDT) MIME-Version: 1.0 References: <153844152006.22637.1995140809587779675@gitbox.apache.org> <20181002005200.3A57F826BA@gitbox.apache.org> <603C65DC-487E-42E5-B04F-8B873AA536A7@adobe.com> In-Reply-To: <603C65DC-487E-42E5-B04F-8B873AA536A7@adobe.com> From: Carlos Rovira Date: Tue, 2 Oct 2018 18:36:32 +0200 Message-ID: Subject: Re: [royale-asjs] 03/04: get more Jewel components to show up without crasing on SWF side To: dev@royale.apache.org Content-Type: multipart/alternative; boundary="000000000000f1ed7f05774186dd" --000000000000f1ed7f05774186dd Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Alex, when we first discussed about using SASS, the agreement was to have the .css generated source to avoid the need to set up an SASS under ANT. Right now maven is the only one that compiles the SASS into CSS. we could remove .css if someone puts SASS compiler running. As you already see for my commits SASS is needed in order to generate all the Jewel Themes. We have right now only a subset, but as we get the rest o= f components finished, I'll be creating the rest of theme projects that involve the rest of compinations (flat-no flat, and light - dark) This would mean about 140 projects if I can recall right, what means 140 css generation. And each update or fix, must be applied to all this .css So that only can be done with a tool like this, or die in the process hehe ;) After some months of using SASS, I think without doubt that was a really good decision and we, as we embrace structured programing and compilation of source code, its totally aligned with what we do, so I think we should give more SASS support in Royale as we move to the future just my 2... El mar., 2 oct. 2018 a las 18:26, Alex Harui () escribi=C3=B3: > Hi Carlos, > > So the defaults.css is a generated file that is under source control? I > would think only our source would be under source control. > And then this also means we cannot just run the Ant build in > frameworks/projects/Jewel to see changes? > > That's probably going to be confusing to others as well. > > -Alex > > =EF=BB=BFOn 10/2/18, 1:11 AM, "Carlos Rovira" > wrote: > > Hi Alex, > > in Jewel you can't change defaults.css directly since is generated by > SASS. > It must be done in SASS files. In this case is > "component/_button.sass", > otherwise those lines will get lost in the next sass generation. One > thing > is important in SASS is tabulate lines correctly or SASS could fail. > > thanks > > > > El mar., 2 oct. 2018 a las 2:52, escribi=C3=B3: > > > This is an automated email from the ASF dual-hosted git repository. > > > > aharui pushed a commit to branch develop > > in repository > https://na01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgitbox= .apache.org%2Frepos%2Fasf%2Froyale-asjs.git&data=3D02%7C01%7Caharui%40a= dobe.com%7C7d37eb4e203e423f9fd108d6283ea4a1%7Cfa7b1b5a7b34438794aed2c178dec= ee1%7C0%7C0%7C636740646851942928&sdata=3Dm9RCOOl55hm93%2BeGxHl3teJ%2FBt= I0n2trRe3FYaw68cw%3D&reserved=3D0 > > > > commit 949767d1e538c7d5e1544ae1bb115f4d92a97b08 > > Author: Alex Harui > > AuthorDate: Mon Oct 1 17:50:51 2018 -0700 > > > > get more Jewel components to show up without crasing on SWF sid= e > > --- > > frameworks/projects/Jewel/src/main/resources/defaults.css | 6 > ++++++ > > .../org/apache/royale/jewel/supportClasses/list/DataGroup.as | 11 > > ++++++++++- > > 2 files changed, 16 insertions(+), 1 deletion(-) > > > > diff --git > a/frameworks/projects/Jewel/src/main/resources/defaults.css > > b/frameworks/projects/Jewel/src/main/resources/defaults.css > > index 226476f..58ac360 100644 > > --- a/frameworks/projects/Jewel/src/main/resources/defaults.css > > +++ b/frameworks/projects/Jewel/src/main/resources/defaults.css > > @@ -120,6 +120,12 @@ j|Form { > > } > > > > @media -royale-swf { > > + j|Button > > + { > > + IBeadModel: > > ClassReference("org.apache.royale.html.beads.models.TextModel"); > > + IBeadView: > > ClassReference("org.apache.royale.html.beads.CSSTextButtonView"); > > + } > > + > > j|Container { > > IContentView: > > > ClassReference("org.apache.royale.html.supportClasses.ContainerContentAre= a"); > > } > > diff --git > > > a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/suppo= rtClasses/list/DataGroup.as > > > b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/suppo= rtClasses/list/DataGroup.as > > index 3962ca2..4309c85 100644 > > --- > > > a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/suppo= rtClasses/list/DataGroup.as > > +++ > > > b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/suppo= rtClasses/list/DataGroup.as > > @@ -20,6 +20,8 @@ package org.apache.royale.jewel.supportClasses.li= st > > { > > import org.apache.royale.html.supportClasses.DataGroup; > > import org.apache.royale.html.DataContainer; > > + import org.apache.royale.core.IBead; > > + import org.apache.royale.core.IStrand; > > > > COMPILE::JS > > { > > @@ -38,7 +40,7 @@ package org.apache.royale.jewel.supportClasses.li= st > > * @playerversion AIR 2.6 > > * @productversion Royale 0.9.4 > > */ > > - public class DataGroup extends DataContainer > > + public class DataGroup extends DataContainer implements IBe= ad > > { > > /** > > * constructor. > > @@ -55,6 +57,13 @@ package > org.apache.royale.jewel.supportClasses.list > > typeNames =3D "jewel datagroup"; > > } > > > > + protected var host:IStrand; > > + > > + public function set strand(value:IStrand):void > > + { > > + host =3D value; > > + } > > + > > /** > > * @royaleignorecoercion > org.apache.royale.core.WrappedHTMLElement > > */ > > > > > > -- > > < > https://na01.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fwww.cod= eoscopic.com&data=3D02%7C01%7Caharui%40adobe.com%7C7d37eb4e203e423f9fd1= 08d6283ea4a1%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C63674064685194292= 8&sdata=3Dou3qw0FvKT5RAm5qfQ1hQyMs1fpbhKAmDY3uE%2BmZ894%3D&reserved= =3D0 > > > > Carlos Rovira > > Director General > > M: +34 607 22 60 05 > > > https://na01.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fwww.cod= eoscopic.com&data=3D02%7C01%7Caharui%40adobe.com%7C7d37eb4e203e423f9fd1= 08d6283ea4a1%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C63674064685194292= 8&sdata=3Dou3qw0FvKT5RAm5qfQ1hQyMs1fpbhKAmDY3uE%2BmZ894%3D&reserved= =3D0 > > > Con=C3=B3cenos en 1 minuto! < > https://na01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Favant2= .es%2F%23video&data=3D02%7C01%7Caharui%40adobe.com%7C7d37eb4e203e423f9f= d108d6283ea4a1%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636740646851942= 928&sdata=3DOTbIgnImUr4iN8XLoLiK9GC%2BDE89vHoW1xA0nGopR%2BA%3D&rese= rved=3D0 > > > > > AVISO LEGAL: La informaci=C3=B3n contenida en este correo electr=C3= =B3nico, y en > su > caso en los documentos adjuntos, es informaci=C3=B3n privilegiada par= a uso > exclusivo de la persona y/o personas a las que va dirigido. No est=C3= =A1 > permitido el acceso a este mensaje a cualquier otra persona distinta = a > los > indicados. Si Usted no es uno de los destinatarios, cualquier > duplicaci=C3=B3n, > reproducci=C3=B3n, distribuci=C3=B3n, as=C3=AD como cualquier uso de = la informaci=C3=B3n > contenida en =C3=A9l o cualquiera otra acci=C3=B3n u omisi=C3=B3n tom= ada en relaci=C3=B3n > con > el mismo, est=C3=A1 prohibida y puede ser ilegal. En dicho caso, por = favor, > notif=C3=ADquelo al remitente y proceda a la eliminaci=C3=B3n de este= correo > electr=C3=B3nico, as=C3=AD como de sus adjuntos si los hubiere. En cu= mplimiento > de la > legislaci=C3=B3n espa=C3=B1ola vigente en materia de protecci=C3=B3n = de datos de > car=C3=A1cter > personal y del RGPD 679/2016 le informamos que sus datos est=C3=A1n s= iendo > objeto de tratamiento por parte de CODEOSCOPIC S.A. con CIFA85677342, > con > la finalidad del mantenimiento y gesti=C3=B3n de relaciones comercial= es y > administrativas. La base jur=C3=ADdica del tratamiento es el inter=C3= =A9s > leg=C3=ADtimo de > la empresa. No se prev=C3=A9n cesiones de sus datos, salvo que exista= una > obligaci=C3=B3n legal. Para ejercitar sus derechos puede dirigirse a > CODEOSCOPIC > S.A., domiciliada enPaseo de la Habana, 9-11, 28036 de Madrid > (MADRID), o > bien por email adpd@codeoscopic.com, con el fin de ejercer sus > derechos de > acceso, rectificaci=C3=B3n, supresi=C3=B3n (derecho al olvido), limit= aci=C3=B3n de > tratamiento, portabilidad de los datos, oposici=C3=B3n, y a no ser ob= jeto de > decisiones automatizadas, indicando como Asunto: =E2=80=9CDerechos Le= y > Protecci=C3=B3n > de Datos=E2=80=9D, y adjuntando fotocopia de su DNI. Delegado de prot= ecci=C3=B3n de > datos:dpd@codeoscopic.com > > > --=20 Carlos Rovira http://about.me/carlosrovira --000000000000f1ed7f05774186dd--