royale-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Carlos Rovira <carlosrov...@apache.org>
Subject Re: ListCollectionView in Royale replacement
Date Wed, 24 Oct 2018 20:23:45 GMT
Hi Alex,
I've must be blind, since I make a diff merge between Royale's
ListCollectionView and the Flex version and don't see huge differences.
could you point me to what should I look for?

thanks

El mié., 24 oct. 2018 a las 20:21, Alex Harui (<aharui@adobe.com.invalid>)
escribió:

> Tree is not using filtering/sorting.  I'm just saying that it is using a
> mapper that generates renderers from an XMLListCollection.
>
> I suspect the code that returns items from localIndex needs to be
> "re-enabled".
>
> -Alex
>
> On 10/24/18, 11:14 AM, "Carlos Rovira" <carlosrovira@apache.org> wrote:
>
>     Ok Alex,
>     I reverted my change since for your comments I see it's not needed. In
>     fact, I see filterFunction is doing its job, and the expected filtered
>     result is in "localIndex" property. I now need to see how to pull this
> into
>     a Jewel List or ComboBox to display it. I'll check Tree to see how
> it's done
>
>     El mié., 24 oct. 2018 a las 19:57, Alex Harui
> (<aharui@adobe.com.invalid>)
>     escribió:
>
>     > Hi Carlos,
>     >
>     > When we pull code from Flex, we still need to keep in mind whether
> we want
>     > to support it or not.  Recently, I just suggested we try not to
> bring over
>     > Repeater because it may have issues on other platforms.  Every line
> of code
>     > we bring over is more work for us to maintain.  Unless someone
> really needs
>     > it, we shouldn't bring it over.  There are some exceptions like
>     > RemoteObject and Charts where it is easier to bring everything
> because it
>     > doesn't have much dependency on Flash.  But I'm not sure you really
> need
>     > ItemPendingError or even ItemResponder to get 99% of
> Sorting/Filtering to
>     > work.  ItemPendingError for sure is about handling "page faults"
> when all
>     > of the data is not available right away.  I'm not even sure you can
>     > generate an ItemPendingError using RemoteObject.  So I would
> definitely
>     > remove that.  And if ItemResponder is only used to handle
> ItemPendingError
>     > I would remove it too.
>     >
>     > -Alex
>     >
>     > On 10/24/18, 10:52 AM, "Carlos Rovira" <carlosrovira@apache.org>
> wrote:
>     >
>     >     Hi Alex,
>     >
>     >     I thought you (and others) were pulling flex classes and make it
>     > compile
>     >     all. Ok , just pushed compiled versions of both classes and I'm
> now
>     > testing
>     >     if that works. I can then try to remove ItemPendingError if I
> can and
>     > push
>     >     it to repo
>     >
>     >     El mié., 24 oct. 2018 a las 19:29, Alex Harui
>     > (<aharui@adobe.com.invalid>)
>     >     escribió:
>     >
>     >     > I would definitely recommend avoiding ItemPendingError unless
> you
>     > must use
>     >     > it.  That is a ton of just-in-case code I'm not sure people
> really
>     > need.
>     >     > Just comment out any ItemPendingErrors usage.
>     >     >
>     >     > I think there is a lot of other just-in-case code in
> Sort/Filter
>     > that you
>     >     > may not need and it might make it easier/faster to get the
>     >     > sorting/filtering you do need by commenting some of that out
> as well.
>     >     > Especially use of ObjectUtil if you run into it.
>     >     >
>     >     > -Alex
>     >     >
>     >     > On 10/24/18, 10:19 AM, "Carlos Rovira" <
> carlosrovira@apache.org>
>     > wrote:
>     >     >
>     >     >     Hi Alex,
>     >     >
>     >     >     I'll be watching to it now and see if I can bring classes
> that
>     > I'm
>     >     > seeing
>     >     >     are still not there (ItemResponder and ItemPendingError)
>     >     >     Let's see what I get
>     >     >
>     >     >     El mié., 24 oct. 2018 a las 18:50, Alex Harui
>     >     > (<aharui@adobe.com.invalid>)
>     >     >     escribió:
>     >     >
>     >     >     > Hi Carlos,
>     >     >     >
>     >     >     > ArrayCollection as [RemoteClass] metadata, so assuming
> you
>     > have the
>     >     >     > ClassAliasBead, and the server used the correct alias,
> you
>     > should
>     >     > get an
>     >     >     > ArrayCollection.  I don't think there is any automatic
> upgrade
>     > from
>     >     > Array
>     >     >     > to ArrayCollection in the framework, but maybe there
> is.  I
>     > don't
>     >     > know the
>     >     >     > code that well.  You can test it with a simple Flex app.
>     >     >     >
>     >     >     > I think the filterFunction/Sort code has not yet been
> tested,
>     > we've
>     >     > only
>     >     >     > recently added the classes to get a clean compile, so
> IMO, it
>     > is
>     >     > just a
>     >     >     > matter of stepping through the code, finding where it
> needs
>     >     > adjusting, and
>     >     >     > making those adjustments.  That is something you or other
>     > volunteers
>     >     > should
>     >     >     > be able to do.
>     >     >     >
>     >     >     > -Alex
>     >     >     >
>     >     >     > On 10/24/18, 8:25 AM, "Carlos Rovira" <
> carlosrovira@apache.org
>     > >
>     >     > wrote:
>     >     >     >
>     >     >     >     Hi I did a quick test in my app a redo a couple of
> vars to
>     > use
>     >     > the
>     >     >     > original
>     >     >     >     code with ArrayCollection and ListCollectionView:
>     >     >     >
>     >     >     >     ArrayCollection:
>     >     >     >
>     >     >     >     * ArrayCollection seems to be working right (I'll
> need to
>     > test
>     >     > it a bit
>     >     >     >     more to see if we can find some issue)
>     >     >     >     * Note about mx:RemoteObject - ArrayCollection
> integration:
>     >     > Something
>     >     >     > is
>     >     >     >     missing since I get the event.result as an Array,
> while in
>     > Flex
>     >     > we get
>     >     >     >     ArrayCollection.
>     >     >     >     This makes the user code need to change from
> "event.result
>     > as
>     >     >     >     ArrayCollection" to "new ArrayCollection(even.result
> as
>     > Array)".
>     >     > At
>     >     >     > this
>     >     >     >     point, maybe this is could be better, since you
> would want
>     > to
>     >     > wrap the
>     >     >     >     Array in an ArrayCollection, or in ArrayList, right?
> so
>     > maybe is
>     >     > no
>     >     >     > good to
>     >     >     >     make the assumption that it should be
> ArrayCollection.
>     >     >     >
>     >     >     >     ListCollectionView
>     >     >     >     * It wraps the ArrayCollection and seems to compile
>     > providing the
>     >     >     >     ArrayCollection, so good to this point
>     >     >     >
>     >     >     >     problems:
>     >     >     >
>     >     >     >     * ListCollectionView.filterFunction seems not
> working for
>     > now (I
>     >     >     > suppose
>     >     >     >     .sort will be the same although didn't try that), so
> this
>     >     > behaves now
>     >     >     > as
>     >     >     >     the original ArrayCollection it wraps. I take a look
> at the
>     >     > code, but
>     >     >     > most
>     >     >     >     of the code seems to be available (not commented).
> Things
>     >     > commented are
>     >     >     >     mostly about ResourceManager (resource bundles)
>     >     >     >     * Jewel controls doesn't shows anything, so I
> suppose to
>     > fix
>     >     > this I'll
>     >     >     >     needs to create similar beads that uses
> ArrayCollection
>     > instead
>     >     >     > ArrayList.
>     >     >     >
>     >     >     >     @alex, some option that you could take a look at
>     > filterFuncion /
>     >     > sort
>     >     >     > in
>     >     >     >     ListCollectionView and provide some info about why's
> not
>     > working?
>     >     >     >
>     >     >     >     I'm in the middle of migration and having
> filter/sorting
>     > could
>     >     > make me
>     >     >     >     invest time in revert code to ArrayCollecion and make
>     > beads for
>     >     > Jewel
>     >     >     > to
>     >     >     >     work with AC instead AL
>     >     >     >
>     >     >     >     Thanks
>     >     >     >
>     >     >     >
>     >     >     >
>     >     >     >
>     >     >     >     El mié., 24 oct. 2018 a las 16:12, Carlos Rovira (<
>     >     >     > carlosrovira@apache.org>)
>     >     >     >     escribió:
>     >     >     >
>     >     >     >     > Hi Alex
>     >     >     >     >
>     >     >     >     > El mié., 24 oct. 2018 a las 1:49, Alex Harui
>     >     >     > (<aharui@adobe.com.invalid>)
>     >     >     >     > escribió:
>     >     >     >     >
>     >     >     >     >> MXRoyale has emulations for ListCollectionView
and
>     >     > ArrayCollection
>     >     >     > (and
>     >     >     >     >> the old Flex ArrayList and XMLListCollection).
 I
> think
>     > they
>     >     > are
>     >     >     > working to
>     >     >     >     >> some degree.  Over time, we will fix bugs in
> sorting and
>     >     > filtering
>     >     >     > since
>     >     >     >     >> other migrating Flex users will need to have
it
> work.
>     >     >     >     >>
>     >     >     >     >>
>     >     >     >     > if ArrayCollection and ListCollectionView are
> working
>     > now, I
>     >     > can try
>     >     >     > to
>     >     >     >     > use them, but since I'm using Jewel and like other
>     > royale code
>     >     >     > (Basic,
>     >     >     >     > MDL,..) are prepared for ArrayList instead of
>     > ArrayCollection
>     >     > I'd
>     >     >     > must see
>     >     >     >     > if is simply a matter of change the mapper bead to
> one
>     > that do
>     >     > the
>     >     >     > same but
>     >     >     >     > with ArrayCollection or is not as easy as that.
>     >     >     >     >
>     >     >     >     >
>     >     >     >     >> Once we have it working, it will be a separate
> task to
>     > see
>     >     > what we
>     >     >     > ended
>     >     >     >     >> up with and break it up into PAYG beads for use
>     > elsewhere.
>     >     >     >     >>
>     >     >     >     >> Since you are already using MXRoyale's
> RemoteObject, you
>     >     > should be
>     >     >     > able
>     >     >     >     >> to use MXRoyale's ArrayCollection without
> dragging in
>     > the
>     >     > need for
>     >     >     >     >> MXRoyale's UI widgets.  We should try to break
> any UI
>     > Widget
>     >     >     > dependencies
>     >     >     >     >> if there are any.  And any fixes you make to
>     > ArrayCollection
>     >     > will
>     >     >     > help the
>     >     >     >     >> other migrating users.
>     >     >     >     >>
>     >     >     >     >>
>     >     >     >     > Right that's something to consider too... I think
> and
>     >     > eventually try
>     >     >     > this
>     >     >     >     > and report what I see
>     >     >     >     >
>     >     >     >     > Thanks
>     >     >     >     >
>     >     >     >     >
>     >     >     >     >> -Alex
>     >     >     >     >>
>     >     >     >     >> On 10/23/18, 4:57 AM, "Carlos Rovira" <
>     >     > carlosrovira@apache.org>
>     >     >     > wrote:
>     >     >     >     >>
>     >     >     >     >>     Hi,
>     >     >     >     >>
>     >     >     >     >>     I'm in the process to migrate some
>     > ListCollectionView
>     >     > variables,
>     >     >     >     >> since we
>     >     >     >     >>     don't have ArrayCollection and Royale uses
> royale's
>     >     > ArrayList,
>     >     >     > I'd
>     >     >     >     >> like to
>     >     >     >     >>     know if we have already some strategy to
get
>     > filtered
>     >     > ArrayList
>     >     >     > with
>     >     >     >     >>     something like "filterFunction", "sort",...
> like in
>     >     >     > ListCollectionView
>     >     >     >     >>
>     >     >     >     >>     If not, what's doing other people here to
> deal with
>     > it?
>     >     >     >     >>
>     >     >     >     >>     thanks
>     >     >     >     >>
>     >     >     >     >>     --
>     >     >     >     >>     Carlos Rovira
>     >     >     >     >>
>     >     >     >     >>
>     >     >     >
>     >     >
>     >
> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&amp;data=02%7C01%7Caharui%40adobe.com%7C80e7f0669b8146cfde0208d639dc876c%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636760016669865153&amp;sdata=H6vVEQkMHgAmpqJYm5%2FoMY3dWV9IuPyu5nK1E3xTZKg%3D&amp;reserved=0
>     >     >     >     >>
>     >     >     >     >>
>     >     >     >     >>
>     >     >     >     >
>     >     >     >     > --
>     >     >     >     > Carlos Rovira
>     >     >     >     >
>     >     >     >
>     >     >
>     >
> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&amp;data=02%7C01%7Caharui%40adobe.com%7C80e7f0669b8146cfde0208d639dc876c%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636760016669865153&amp;sdata=H6vVEQkMHgAmpqJYm5%2FoMY3dWV9IuPyu5nK1E3xTZKg%3D&amp;reserved=0
>     >     >     >     >
>     >     >     >     >
>     >     >     >
>     >     >     >     --
>     >     >     >     Carlos Rovira
>     >     >     >
>     >     >     >
>     >     >
>     >
> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&amp;data=02%7C01%7Caharui%40adobe.com%7C80e7f0669b8146cfde0208d639dc876c%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636760016669865153&amp;sdata=H6vVEQkMHgAmpqJYm5%2FoMY3dWV9IuPyu5nK1E3xTZKg%3D&amp;reserved=0
>     >     >     >
>     >     >     >
>     >     >     >
>     >     >
>     >     >     --
>     >     >     Carlos Rovira
>     >     >
>     >     >
>     >
> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&amp;data=02%7C01%7Caharui%40adobe.com%7C80e7f0669b8146cfde0208d639dc876c%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636760016669865153&amp;sdata=H6vVEQkMHgAmpqJYm5%2FoMY3dWV9IuPyu5nK1E3xTZKg%3D&amp;reserved=0
>     >     >
>     >     >
>     >     >
>     >
>     >     --
>     >     Carlos Rovira
>     >
>     >
> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&amp;data=02%7C01%7Caharui%40adobe.com%7C80e7f0669b8146cfde0208d639dc876c%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636760016669865153&amp;sdata=H6vVEQkMHgAmpqJYm5%2FoMY3dWV9IuPyu5nK1E3xTZKg%3D&amp;reserved=0
>     >
>     >
>     >
>
>     --
>     Carlos Rovira
>
> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&amp;data=02%7C01%7Caharui%40adobe.com%7C80e7f0669b8146cfde0208d639dc876c%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636760016669865153&amp;sdata=H6vVEQkMHgAmpqJYm5%2FoMY3dWV9IuPyu5nK1E3xTZKg%3D&amp;reserved=0
>
>
>

-- 
Carlos Rovira
http://about.me/carlosrovira

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message