royale-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Carlos Rovira <carlosrov...@apache.org>
Subject Re: [royale-asjs] 03/04: get more Jewel components to show up without crasing on SWF side
Date Tue, 02 Oct 2018 16:36:32 GMT
Hi Alex,

when we first discussed about using SASS, the agreement was to have the
.css generated source to avoid the need to set up an SASS under ANT.
Right now maven is the only one that compiles the SASS into CSS. we could
remove .css if someone puts SASS compiler running.
As you already see for my commits SASS is needed in order to generate all
the Jewel Themes. We have right now only a subset, but as we get the rest of
components finished, I'll be creating the rest of theme projects that
involve the rest of compinations (flat-no flat, and light - dark)
This would mean about 140 projects if I can recall right, what means 140
css generation. And each update or fix, must be applied to all this .css
So that only can be done with a tool like this, or die in the process hehe
;)

After some months of using SASS, I think without doubt that was a really
good decision and we, as we embrace structured programing and compilation
of source code, its totally aligned with what we do, so I think we should
give more SASS support in Royale as we move to the future

just my 2...


El mar., 2 oct. 2018 a las 18:26, Alex Harui (<aharui@adobe.com.invalid>)
escribió:

> Hi Carlos,
>
> So the defaults.css is a generated file that is under source control?  I
> would think only our source would be under source control.
> And then this also means we cannot just run the Ant build in
> frameworks/projects/Jewel to see changes?
>
> That's probably going to be confusing to others as well.
>
> -Alex
>
> On 10/2/18, 1:11 AM, "Carlos Rovira" <carlos.rovira@codeoscopic.com>
> wrote:
>
>     Hi Alex,
>
>     in Jewel you can't change defaults.css directly since is generated by
> SASS.
>     It must be done in SASS files. In this case is
> "component/_button.sass",
>     otherwise those lines will get lost in the next sass generation. One
> thing
>     is important in SASS is tabulate lines correctly or SASS could fail.
>
>     thanks
>
>
>
>     El mar., 2 oct. 2018 a las 2:52, <aharui@apache.org> escribió:
>
>     > This is an automated email from the ASF dual-hosted git repository.
>     >
>     > aharui pushed a commit to branch develop
>     > in repository
> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%2Froyale-asjs.git&amp;data=02%7C01%7Caharui%40adobe.com%7C7d37eb4e203e423f9fd108d6283ea4a1%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636740646851942928&amp;sdata=m9RCOOl55hm93%2BeGxHl3teJ%2FBtI0n2trRe3FYaw68cw%3D&amp;reserved=0
>     >
>     > commit 949767d1e538c7d5e1544ae1bb115f4d92a97b08
>     > Author: Alex Harui <aharui@apache.org>
>     > AuthorDate: Mon Oct 1 17:50:51 2018 -0700
>     >
>     >     get more Jewel components to show up without crasing on SWF side
>     > ---
>     >  frameworks/projects/Jewel/src/main/resources/defaults.css     |  6
> ++++++
>     >  .../org/apache/royale/jewel/supportClasses/list/DataGroup.as  | 11
>     > ++++++++++-
>     >  2 files changed, 16 insertions(+), 1 deletion(-)
>     >
>     > diff --git
> a/frameworks/projects/Jewel/src/main/resources/defaults.css
>     > b/frameworks/projects/Jewel/src/main/resources/defaults.css
>     > index 226476f..58ac360 100644
>     > --- a/frameworks/projects/Jewel/src/main/resources/defaults.css
>     > +++ b/frameworks/projects/Jewel/src/main/resources/defaults.css
>     > @@ -120,6 +120,12 @@ j|Form {
>     >  }
>     >
>     >  @media -royale-swf {
>     > +  j|Button
>     > +  {
>     > +       IBeadModel:
>     > ClassReference("org.apache.royale.html.beads.models.TextModel");
>     > +       IBeadView:
>     > ClassReference("org.apache.royale.html.beads.CSSTextButtonView");
>     > +  }
>     > +
>     >    j|Container {
>     >      IContentView:
>     >
> ClassReference("org.apache.royale.html.supportClasses.ContainerContentArea");
>     >    }
>     > diff --git
>     >
> a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/supportClasses/list/DataGroup.as
>     >
> b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/supportClasses/list/DataGroup.as
>     > index 3962ca2..4309c85 100644
>     > ---
>     >
> a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/supportClasses/list/DataGroup.as
>     > +++
>     >
> b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/supportClasses/list/DataGroup.as
>     > @@ -20,6 +20,8 @@ package org.apache.royale.jewel.supportClasses.list
>     >  {
>     >         import org.apache.royale.html.supportClasses.DataGroup;
>     >         import org.apache.royale.html.DataContainer;
>     > +    import org.apache.royale.core.IBead;
>     > +    import org.apache.royale.core.IStrand;
>     >
>     >      COMPILE::JS
>     >      {
>     > @@ -38,7 +40,7 @@ package org.apache.royale.jewel.supportClasses.list
>     >          *  @playerversion AIR 2.6
>     >          *  @productversion Royale 0.9.4
>     >          */
>     > -       public class DataGroup extends DataContainer
>     > +       public class DataGroup extends DataContainer implements IBead
>     >         {
>     >                 /**
>     >                  *  constructor.
>     > @@ -55,6 +57,13 @@ package
> org.apache.royale.jewel.supportClasses.list
>     >                         typeNames = "jewel datagroup";
>     >                 }
>     >
>     > +        protected var host:IStrand;
>     > +
>     > +        public function set strand(value:IStrand):void
>     > +        {
>     > +            host = value;
>     > +        }
>     > +
>     >                 /**
>     >           * @royaleignorecoercion
> org.apache.royale.core.WrappedHTMLElement
>     >           */
>     >
>     >
>
>     --
>
>     <
> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.codeoscopic.com&amp;data=02%7C01%7Caharui%40adobe.com%7C7d37eb4e203e423f9fd108d6283ea4a1%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636740646851942928&amp;sdata=ou3qw0FvKT5RAm5qfQ1hQyMs1fpbhKAmDY3uE%2BmZ894%3D&amp;reserved=0
> >
>
>     Carlos Rovira
>
>     Director General
>
>     M: +34 607 22 60 05
>
>
> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.codeoscopic.com&amp;data=02%7C01%7Caharui%40adobe.com%7C7d37eb4e203e423f9fd108d6283ea4a1%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636740646851942928&amp;sdata=ou3qw0FvKT5RAm5qfQ1hQyMs1fpbhKAmDY3uE%2BmZ894%3D&amp;reserved=0
>
>
>     Conócenos en 1 minuto! <
> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Favant2.es%2F%23video&amp;data=02%7C01%7Caharui%40adobe.com%7C7d37eb4e203e423f9fd108d6283ea4a1%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636740646851942928&amp;sdata=OTbIgnImUr4iN8XLoLiK9GC%2BDE89vHoW1xA0nGopR%2BA%3D&amp;reserved=0
> >
>
>
>     AVISO LEGAL: La información contenida en este correo electrónico, y en
> su
>     caso en los documentos adjuntos, es información privilegiada para uso
>     exclusivo de la persona y/o personas a las que va dirigido. No está
>     permitido el acceso a este mensaje a cualquier otra persona distinta a
> los
>     indicados. Si Usted no es uno de los destinatarios, cualquier
> duplicación,
>     reproducción, distribución, así como cualquier uso de la información
>     contenida en él o cualquiera otra acción u omisión tomada en relación
> con
>     el mismo, está prohibida y puede ser ilegal. En dicho caso, por favor,
>     notifíquelo al remitente y proceda a la eliminación de este correo
>     electrónico, así como de sus adjuntos si los hubiere. En cumplimiento
> de la
>     legislación española vigente en materia de protección de datos de
> carácter
>     personal y del RGPD 679/2016 le informamos que sus datos están siendo
>     objeto de tratamiento por parte de CODEOSCOPIC S.A. con CIFA85677342,
> con
>     la finalidad del mantenimiento y gestión de relaciones comerciales y
>     administrativas. La base jurídica del tratamiento es el interés
> legítimo de
>     la empresa. No se prevén cesiones de sus datos, salvo que exista una
>     obligación legal. Para ejercitar sus derechos puede dirigirse a
> CODEOSCOPIC
>     S.A., domiciliada enPaseo de la Habana, 9-11, 28036 de Madrid
> (MADRID), o
>     bien por email adpd@codeoscopic.com, con el fin de ejercer sus
> derechos de
>     acceso, rectificación, supresión (derecho al olvido), limitación de
>     tratamiento, portabilidad de los datos, oposición, y a no ser objeto de
>     decisiones automatizadas, indicando como Asunto: “Derechos Ley
> Protección
>     de Datos”, y adjuntando fotocopia de su DNI. Delegado de protección de
>     datos:dpd@codeoscopic.com
>
>
>

-- 
Carlos Rovira
http://about.me/carlosrovira

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message