From dev-return-6328-archive-asf-public=cust-asf.ponee.io@royale.apache.org Wed Sep 12 11:40:20 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 60E5618067A for ; Wed, 12 Sep 2018 11:40:19 +0200 (CEST) Received: (qmail 52408 invoked by uid 500); 12 Sep 2018 09:40:18 -0000 Mailing-List: contact dev-help@royale.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@royale.apache.org Delivered-To: mailing list dev@royale.apache.org Received: (qmail 52352 invoked by uid 99); 12 Sep 2018 09:40:17 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 12 Sep 2018 09:40:17 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 5F6471807A0 for ; Wed, 12 Sep 2018 09:40:17 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.111 X-Spam-Level: X-Spam-Status: No, score=-0.111 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_DKIMWL_WL_MED=-0.01] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id NyF1VXZRPx2D for ; Wed, 12 Sep 2018 09:40:16 +0000 (UTC) Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id BFF935F47B for ; Wed, 12 Sep 2018 09:40:15 +0000 (UTC) Received: by mail-wm0-f43.google.com with SMTP id y139-v6so1611228wmc.2 for ; Wed, 12 Sep 2018 02:40:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:content-transfer-encoding:mime-version:subject:date:references :to:in-reply-to:message-id; bh=2Khv3eyvG8NlX2SMbF9ioWNpmRpITVG58ZeL7oEgLl0=; b=SLIQtW2polaH2CpoZjT29J1XRdSFxuUNyy1Ug4y1N+AI31bcJJxIlY1Dgg7M/6Tuui ELT6hVKB0TZzGGroGd8ksiKpznqATMTJ2JHnGLut0elAzGTOGNO202j47R/yJc+t948a uvMjCfY/yn0L7ePjc4n4ZqiWk6C4vrPkk537VyH/jq+xq+6YjKn90EqgZjQHEQmfdFSD 9jWYwZXGslv+ZgBlNlaWwOEypLdUnH2iVlnsXFwWLw5+qIUcjuiIvoYJx9g2EkrK4ra6 lKPdXk+MEcGfBv12XMurdZLDsA53v20zd4txPME3FG9dCpvad/mE28mVSBp+Fz+Spjhb wuiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:content-transfer-encoding:mime-version :subject:date:references:to:in-reply-to:message-id; bh=2Khv3eyvG8NlX2SMbF9ioWNpmRpITVG58ZeL7oEgLl0=; b=KvK2EPnyyHii7HqNcTfUGMq5+edqeA4Vl3F0BGPqy1JL6T9hH1TRmWuwW3QbHBye8k FYC7JBxbkbWG9pmtPgANTP5vfyLYJ0acdnN+zMIRWNcG5HGsfvnAUIInM4xYkwWUA3be fuOR6zScSku7Es6sE698ya5PSSYiiHQsv1sXMxNbP7CEnaTToETSnJky6AnVOQqYzrxs QWdiZ6URII4RCkopJVAdmE6uHZ0/2ci4LSXjFLQnTr0MO22DMhYeO+Jt0q+fRretdtv6 Sw3n/KprxBZCuyDHtbzDzjK/z4j8VPSBJ0cNYCMBqEnpREsBhbxiujIRR+JG1Hm/6TDd JyZg== X-Gm-Message-State: APzg51C5vd16MaAkh8oj84mboGHZWLXpuozAmFiCKpMMqEdhliUBQB/0 lHGOyprkvTmeOZTkcM0kvdSmtnzC X-Google-Smtp-Source: ANB0VdaGFIu9T7MpF41hFldpA9tQNqgh3/9DwRey892d97xDOXI3lGA+nKuNZJxjx1yzEBpzdsc2Vw== X-Received: by 2002:a1c:cb4d:: with SMTP id b74-v6mr1067260wmg.123.1536745215118; Wed, 12 Sep 2018 02:40:15 -0700 (PDT) Received: from [192.168.252.2] ([94.230.82.121]) by smtp.gmail.com with ESMTPSA id n11-v6sm333144wra.26.2018.09.12.02.40.13 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Sep 2018 02:40:14 -0700 (PDT) From: Harbs Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Re: GOOG::DEBUG Date: Wed, 12 Sep 2018 12:40:12 +0300 References: <39117E04-4092-4BDD-9C6C-B1AA38430ACD@gmail.com> <14365A3C-9881-46DC-A063-20A4893B2F82@adobe.com> <49017190-DC0F-4D60-95D7-B1C8EB5EF9BE@gmail.com> <72B2736F-643B-4328-BD88-BDC381C0EC88@adobe.com> <141A9C51-59AD-4E0F-B29C-EE1031125483@gmail.com> <2E04C797-DE2E-43DD-8126-B491A0B322AA@adobe.com> <84F739C8-D6CC-40AD-8D23-43374A74C82A@gmail.com> <981686D6-29CC-4421-85ED-69CEE144F2E1@gmail.com> <3AC386EA-D16C-47C8-9256-EAC6F50BBD1D@gmail.com> <562D3855-C02A-4BA9-A186-0530C16DF383@adobe.com> To: dev@royale.apache.org In-Reply-To: Message-Id: <88957DAE-8828-43A9-993F-F2CAB5B13DD5@gmail.com> X-Mailer: Apple Mail (2.3273) Sure. Good luck with the release process! > On Sep 12, 2018, at 12:37 PM, Piotr Zarzycki = wrote: >=20 > Harbs, >=20 > Sorry I miss that email, so ignore last question in other thread! >=20 > Piotr >=20 > wt., 11 wrz 2018 o 20:36 Harbs napisa=C5=82(a): >=20 >> OK. I reverted the rest param. >>=20 >> I=E2=80=99m now outputting rest =3D rest;if(!goog.DEBUG)return; = instead of >> if(!goog.DEBUG)return; if there=E2=80=99s a rest argument. >>=20 >> It=E2=80=99s a bit ugly, but it seems to make the closure compiler = happy and gets >> the desired result. >>=20 >> Thanks, >> Harbs >>=20 >>> On Sep 10, 2018, at 6:52 AM, Alex Harui >> wrote: >>>=20 >>>=20 >>>=20 >>> =EF=BB=BFOn 9/8/18, 10:05 AM, "Harbs" wrote: >>>=20 >>> I should have included a full explanation in my email. >>>=20 >>> I tried {=E2=80=A6*} but I got the same error as with {=E2=80=A6}. >>>=20 >>> {*} is not technically right as the arguments after the first is = not >> declared, but I tested trace with multiple arguments with the change = and >> the closure compiler did not complain. It=E2=80=99s the closest = annotation I could >> come up with that does not cause the error. (i.e. the first argument = is >> required) I can=E2=80=99t think of any downsides of leaving the rest = of the >> arguments out. Can you think of an issue with it? >>>=20 >>> If Closure Compiler did not notice that there were extra arguments, = some >> day they might fix it so it does notice. We should annotate our code >> correctly. >>>=20 >>> Maybe a better fix is to update the closure compiler? Not sure=E2=80= =A6 >>>=20 >>> IIRC, you recently added some code to the compiler to clean out = empty >> CSS selectors in release mode. I wonder if there is a way to special = case >> trace and rewrite it in a way that Closure Compiler will know to = remove >> it. Like remove every line of code or every line of code after the = rest >> handling. >>>=20 >>> I just wanted to fix the build in the meantime. >>>=20 >>> I do not wish to see us release with the wrong annotations. But = feel >> free to hack the final output code. >>>=20 >>> Suggestions? >>>=20 >>> Harbs >>>=20 >>>> On Sep 7, 2018, at 7:14 PM, Alex Harui >> wrote: >>>>=20 >>>> The fix does not look right to me. Here are a link that indicates = that >> variable number of arguments should be using "...". >>>>=20 >>>>=20 >> = https://na01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgithub.= com%2Fgoogle%2Fclosure-compiler%2Fwiki%2FAnnotating-JavaScript-for-the-Clo= sure-Compiler&data=3D02%7C01%7Caharui%40adobe.com%7C3049de2a8d7c4cfdfd= 6d08d615ad5849%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C63672023159060= 8291&sdata=3DjY1qMvlQPbXRJqTXanp6WLVxi9v5AvP%2BTUF38HiqDA8%3D&rese= rved=3D0 >> < >> = https://na01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgithub.= com%2Fgoogle%2Fclosure-compiler%2Fwiki%2FAnnotating-JavaScript-for-the-Clo= sure-Compiler&data=3D02%7C01%7Caharui%40adobe.com%7C3049de2a8d7c4cfdfd= 6d08d615ad5849%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C63672023159060= 8291&sdata=3DjY1qMvlQPbXRJqTXanp6WLVxi9v5AvP%2BTUF38HiqDA8%3D&rese= rved=3D0 >>>=20 >>>>=20 >>>> This link indicates that the annotation for trace should be {...*} >>>>=20 >>>>=20 >> = https://na01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fstackov= erflow.com%2Fquestions%2F25474311%2Fannotating-zero-or-more-parameters-wit= h-any-type-for-google-closure-compiler&data=3D02%7C01%7Caharui%40adobe= .com%7C3049de2a8d7c4cfdfd6d08d615ad5849%7Cfa7b1b5a7b34438794aed2c178decee1= %7C0%7C0%7C636720231590608291&sdata=3DheE3Aayf8LufbLIJwBJGXXDewL2J%2Fq= uKX6R9wTGHPEg%3D&reserved=3D0 >> < >> = https://na01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fstackov= erflow.com%2Fquestions%2F25474311%2Fannotating-zero-or-more-parameters-wit= h-any-type-for-google-closure-compiler&data=3D02%7C01%7Caharui%40adobe= .com%7C3049de2a8d7c4cfdfd6d08d615ad5849%7Cfa7b1b5a7b34438794aed2c178decee1= %7C0%7C0%7C636720231590608291&sdata=3DheE3Aayf8LufbLIJwBJGXXDewL2J%2Fq= uKX6R9wTGHPEg%3D&reserved=3D0 >>>=20 >>>>=20 >>>> What document led you to believe you could just use {*}, which >> indicates only one parameter. >>>>=20 >>>> Thanks, >>>> -Alex >>>>=20 >>>> On 9/7/18, 1:55 AM, "Harbs" > harbs.lists@gmail.com>> wrote: >>>>=20 >>>> I just committed a fix for this. >>>>=20 >>>> We can discuss further, but at least the build should work=E2=80=A6 >>>>=20 >>>>> On Sep 7, 2018, at 10:55 AM, Carlos Rovira = >> wrote: >>>>>=20 >>>>> Right, I'm seeing as well JewelExample failing on compile >>>>>=20 >>>>> thanks >>>>>=20 >>>>> El vie., 7 sept. 2018 a las 9:13, Harbs () >> escribi=C3=B3: >>>>>=20 >>>>>> I=E2=80=99m saying that a param defined as {=E2=80=A6} confuses = the closure compiler >> when >>>>>> you have the rest redefined as an array anywhere but the first = line >> of the >>>>>> function. It seems like a bug in the closure compiler. >>>>>>=20 >>>>>> Changing: >>>>>> rest =3D Array.prototype.slice.call(arguments, 0); >>>>>> to: >>>>>> var rest =3D Array.prototype.slice.call(arguments, 0); >>>>>>=20 >>>>>> also makes the error go away, but we do get a reassignment = warning. >>>>>>=20 >>>>>> I=E2=80=99m not sure what declaring a @param as {=E2=80=A6} = actually accomplishes in >> terms >>>>>> of type checking. >>>>>>=20 >>>>>>> On Sep 7, 2018, at 10:02 AM, Alex Harui = >>>>>> wrote: >>>>>>>=20 >>>>>>> Are you saying some recent change to the compiler is now = generating: >>>>>>> @param {...} rest >>>>>>>=20 >>>>>>> If so, what changed caused that output? If not, why did it not = fail >>>>>> before? >>>>>>>=20 >>>>>>> We should be generating whatever Google says we should generate = for >> rest >>>>>> parameters. Although I did ponder the impact of having Royale's >> trace not >>>>>> take extra parameters. Then folks would have to concat strings = before >>>>>> calling trace. >>>>>>>=20 >>>>>>> -Alex >>>>>>>=20 >>>>>>> On 9/6/18, 11:58 PM, "Harbs" wrote: >>>>>>>=20 >>>>>>> It looks like the problem is caused by: >>>>>>> * @param {...} rest >>>>>>>=20 >>>>>>> What would happen if we remove the @param or change it to @param = {*=3D} >>>>>> rest? >>>>>>>=20 >>>>>>> Both of those work. >>>>>>>=20 >>>>>>>> On Sep 7, 2018, at 8:35 AM, Alex Harui = >>>>>> wrote: >>>>>>>>=20 >>>>>>>> But first, I'm not sure your idea is going to work in all = cases. >> See >>>>>> if you get the same problem in JewelExample. >>>>>>>=20 >>>>>>>=20 >>>>>>>=20 >>>>>>=20 >>>>>>=20 >>>>>=20 >>>>> -- >>>>> Carlos Rovira >>>>>=20 >> = https://na01.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fabout.me= %2Fcarlosrovira&data=3D02%7C01%7Caharui%40adobe.com%7C3049de2a8d7c4cfd= fd6d08d615ad5849%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636720231590= 608291&sdata=3DrbbJA1WE6kM51gJyvUiMRF8%2FNm41wtUo7URuae9jKqE%3D&re= served=3D0 >> < >> = https://na01.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fabout.me= %2Fcarlosrovira&data=3D02%7C01%7Caharui%40adobe.com%7C3049de2a8d7c4cfd= fd6d08d615ad5849%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636720231590= 608291&sdata=3DrbbJA1WE6kM51gJyvUiMRF8%2FNm41wtUo7URuae9jKqE%3D&re= served=3D0 >>>=20 >>>=20 >>>=20 >>=20 >>=20 >=20 > --=20 >=20 > Piotr Zarzycki >=20 > Patreon: *https://www.patreon.com/piotrzarzycki > *