royale-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Piotr Zarzycki <piotrzarzyck...@gmail.com>
Subject Re: [Discuss] Start release process 0.9.3
Date Fri, 14 Sep 2018 16:13:09 GMT
Alex,

You understand it me wrong. I don't skip tests when I'm trying to create
release candidate. This command is test command - I run it just to check
what pure Maven build download for me - not connected with ant at all.

Thanks,
Piotr

pt., 14 wrz 2018 o 18:09 Alex Harui <aharui@adobe.com.invalid> napisał(a):

> Ant does not specify to use settings-template.  I never specify that
> anymore when running Maven from the command-line.
>
> FWIW, I think you should not skip tests or rat when trying to create a
> release candidate.
>
> Ant uses a "mvn" variable when trying to launch Maven so you can
> -Dmvn=<some other path> although I don't think you can add other options to
> that variable.
>
> I guess I will try this out myself on Windows.
>
> HTH
> -Alex
>
> On 9/14/18, 9:02 AM, "Piotr Zarzycki" <piotrzarzycki21@gmail.com> wrote:
>
>     For the tests I run in command line following: mvn -s
> settings-template.xml
>     -DskipTests -Drat.skip=true clean install - It uses my Apache Maven
> 3.5.4.
>     I would be surprised that Ant run some other Maven - I don't have any
> other
>     installed in my system. I will check as you propose from Ant.
>
>
>     pt., 14 wrz 2018 o 17:54 Alex Harui <aharui@adobe.com.invalid>
> napisał(a):
>
>     > The Ant script runs (on Windows) whatever mvn.cmd maps to in the
> PATH.
>     > What are you typing on the command-line to run Maven?
>     >
>     > There are some options for Ant that print out more info or you might
> add
>     > some other commands to the Ant script to help figure out what
> mvn.cmd it is
>     > running.  On Windows, I think you can run "where mvn.cmd" to see
> what it is
>     > picking up.
>     >
>     > HTH,
>     > -Alex
>     >
>     >
>     > On 9/14/18, 8:05 AM, "Piotr Zarzycki" <piotrzarzycki21@gmail.com>
> wrote:
>     >
>     >     I have spent on that again a bunch of time and something is
> really
>     > weird
>     >     happen. I've figure out that if Maven is using scm and we won't
> specify
>     >     inside pluginManagement tag what version of scm is used - It will
>     > download
>     >     some older one.
>     >
>     >     However there is something wrong on the line between
>     > releasecandidate.xml
>     >     and Maven.
>     >
>     >     1) If I run build of royale-compiler using cmd or even from
> Intellij -
>     > scm
>     >     1.10.0 is being downloaded - correct one.
>     >     2) If I run release process using releasecandidate.xml there is
> being
>     >     downloaded 1.9.4
>     >
>     >     Any idea why it could happen like that ? This file
>     > releasecandidate.xml is
>     >     used to just launch Maven build, why old scm is being
> downloaded?!
>     >
>     >     Thanks,
>     >     Piotr
>     >
>     >     czw., 13 wrz 2018 o 21:43 Alex Harui <aharui@adobe.com.invalid>
>     > napisał(a):
>     >
>     >     > I think the console output will show what versions of plugins
> are
>     >     > downloaded. You can also check out the local maven cache.
>     >     >
>     >     > Get Outlook for Android<
>     >
> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Faka.ms%2Fghei36&amp;data=02%7C01%7Caharui%40adobe.com%7C52945277f0d64479c60c08d61a5b879b%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636725377773552343&amp;sdata=SVi8NTxA06PTjMvNX9q9xzsEkOTle2FEUU%2BqvUz2G40%3D&amp;reserved=0
>     > >
>     >     >
>     >     > ________________________________
>     >     > From: Piotr Zarzycki <piotrzarzycki21@gmail.com>
>     >     > Sent: Thursday, September 13, 2018 11:02:29 AM
>     >     > To: dev@royale.apache.org
>     >     > Subject: Re: [Discuss] Start release process 0.9.3
>     >     >
>     >     > Unfortunately I don't know how to check that. I can check only
>     > "Effective
>     >     > Pom" - Intellij is able to show me what is behind the stage in
>     > specific
>     >     > pom. This is how it looks like for main pom in royale-asjs ->
>     >     >
>     >     >
>     >
> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpaste.apache.org%2FeVmK&amp;data=02%7C01%7Caharui%40adobe.com%7C52945277f0d64479c60c08d61a5b879b%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636725377773552343&amp;sdata=d7zASOCupeB7rwYmuW89NhgcSrrCI7aITzqKrXHJkks%3D&amp;reserved=0
>     >     >
>     >     > Piotr
>     >     >
>     >     >
>     >     >
>     >     > czw., 13 wrz 2018 o 19:42 Alex Harui <aharui@adobe.com.invalid
> >
>     >     > napisał(a):
>     >     >
>     >     > > Is maven using scm 1.10?
>     >     > >
>     >     > > Get Outlook for Android<
>     >     >
>     >
> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Faka.ms%2Fghei36&amp;data=02%7C01%7Caharui%40adobe.com%7C52945277f0d64479c60c08d61a5b879b%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636725377773552343&amp;sdata=SVi8NTxA06PTjMvNX9q9xzsEkOTle2FEUU%2BqvUz2G40%3D&amp;reserved=0
>     >     > >
>     >     > >
>     >     > > ________________________________
>     >     > > From: Piotr Zarzycki <piotrzarzycki21@gmail.com>
>     >     > > Sent: Thursday, September 13, 2018 8:55:29 AM
>     >     > > To: dev@royale.apache.org
>     >     > > Subject: Re: [Discuss] Start release process 0.9.3
>     >     > >
>     >     > > I'm unable to use releasecandidate.xml and prepare that
> release
>     > using
>     >     > that
>     >     > > script. It's failing constantly, despite my attempt of
> update scm.
>     >     > Failing
>     >     > > is happen only on royale-asjs.
>     >     > >
>     >     > > I see only option to prepare that release manually.
>     >     > >
>     >     > > Thanks,
>     >     > > Piotr
>     >     > >
>     >     > > czw., 13 wrz 2018 o 10:47 Alex Harui
> <aharui@adobe.com.invalid>
>     >     > > napisał(a):
>     >     > >
>     >     > > > Yes, that might work.  But you also have to run the
>     > update.version
>     >     > target
>     >     > > > in Ant.  It looks like I didn't write about it in the
> wiki.  I
>     > think
>     >     > the
>     >     > > > command would be something like:
>     >     > > >
>     >     > > >   Ant -f releasecandidate.xml update.version
>     > -Drelease.version=0.9.3
>     >     > > >
>     >     > > > I think it will ask you for the next version to use.  I'm
> done
>     > working
>     >     > > for
>     >     > > > today, so good luck.
>     >     > > >
>     >     > > > HTH,
>     >     > > > -Alex
>     >     > > >
>     >     > > > On 9/13/18, 12:52 AM, "Piotr Zarzycki" <
>     > piotrzarzycki21@gmail.com>
>     >     > > wrote:
>     >     > > >
>     >     > > >     Alex,
>     >     > > >
>     >     > > >     By that do you mean that I basically should go two
> times
>     > with third
>     >     > > > step of
>     >     > > >     your release steps ? It will give the results I think
> so.
>     >     > > >
>     >     > > >     [1]
>     >     > > >
>     >     > > >
>     >     > >
>     >     >
>     >
> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Froyale-asjs%2Fwiki%2FRelease-Manager-Notes%23release-steps&amp;data=02%7C01%7Caharui%40adobe.com%7C52945277f0d64479c60c08d61a5b879b%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636725377773552343&amp;sdata=Nl3e1gDXnVvW1oq%2BZtdSp7KXUR%2B6Axc5nRxLszvoIj8%3D&amp;reserved=0
>     >     > > >
>     >     > > >     Thanks,
>     >     > > >     Piotr
>     >     > > >
>     >     > > >     czw., 13 wrz 2018 o 09:46 Alex Harui
>     > <aharui@adobe.com.invalid>
>     >     > > > napisał(a):
>     >     > > >
>     >     > > >     > I also noticed that there are lots of references to
> 0.9.3
>     > in the
>     >     > > > repo.  If
>     >     > > >     > we want to use 0.9.4 as the version number, I think
> you
>     > will have
>     >     > > to
>     >     > > > run
>     >     > > >     > the update.version target in releasecandidate.xml and
>     > update the
>     >     > > > Maven poms
>     >     > > >     > as well.   We've never really tried to skip a version
>     > number
>     >     > > before,
>     >     > > > so not
>     >     > > >     > exactly sure what needs to be done.  One way that
> might
>     > work to
>     >     > > > update
>     >     > > >     > Maven poms is to create the release branches.  That
> should
>     > update
>     >     > > the
>     >     > > >     > version numbers in the develop branch.  Then toss the
>     > release
>     >     > > branch
>     >     > > >     > without reverting and create another release
> branch.  That
>     > should
>     >     > > > update
>     >     > > >     > the version numbers in develop to 0.9.5-SNAPSHOT
> which is
>     > what we
>     >     > > > want, and
>     >     > > >     > the release branches should have 0.9.4.
>     >     > > >     >
>     >     > > >     > HTH,
>     >     > > >     > -Alex
>     >     > > >     >
>     >     > > >     > On 9/12/18, 2:18 PM, "Alex Harui"
> <aharui@adobe.com.INVALID
>     > >
>     >     > > wrote:
>     >     > > >     >
>     >     > > >     >     The console output should include what version of
>     > plugins are
>     >     > > >     > downloaded.
>     >     > > >     >
>     >     > > >     >     Get Outlook for Android<
>     >     > > >     >
>     >     > > >
>     >     > >
>     >     >
>     >
> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Faka.ms%2Fghei36&amp;data=02%7C01%7Caharui%40adobe.com%7C52945277f0d64479c60c08d61a5b879b%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636725377773552343&amp;sdata=SVi8NTxA06PTjMvNX9q9xzsEkOTle2FEUU%2BqvUz2G40%3D&amp;reserved=0
>     >     > > >     > >
>     >     > > >     >
>     >     > > >     >     ________________________________
>     >     > > >     >     From: Piotr Zarzycki <piotrzarzycki21@gmail.com>
>     >     > > >     >     Sent: Wednesday, September 12, 2018 9:54:04 AM
>     >     > > >     >     To: dev@royale.apache.org
>     >     > > >     >     Subject: Re: [Discuss] Start release process
> 0.9.3
>     >     > > >     >
>     >     > > >     >     That's not good, because I was updated that
> stuff. It
>     > looks
>     >     > > like
>     >     > > > it
>     >     > > >     > didn't
>     >     > > >     >     work well. Let me investigate more scm plugin
> stuff
>     > and I'm
>     >     > > > reverting
>     >     > > >     >     current changes.
>     >     > > >     >
>     >     > > >     >     Thanks!
>     >     > > >     >
>     >     > > >     >     śr., 12 wrz 2018 o 18:39 Alex Harui
>     > <aharui@adobe.com.invalid
>     >     > >
>     >     > > >     > napisał(a):
>     >     > > >     >
>     >     > > >     >     > That error implies that maven-scm 1.10.0 is not
>     > being used.
>     >     > > > Some
>     >     > > >     > older
>     >     > > >     >     > version is.  I couldn't figure out from reading
>     > Maven doc
>     >     > > > exactly
>     >     > > >     > how to
>     >     > > >     >     > control that.  We might need to specify it in
> the
>     > main pom,
>     >     > > > but I was
>     >     > > >     >     > hoping that if you used the latest Maven it
> would
>     >     > > automatically
>     >     > > >     > bring in
>     >     > > >     >     > that version.
>     >     > > >     >     >
>     >     > > >     >     > Regarding canceling an RC:  the Ant scripts
> have
>     > targets
>     >     > that
>     >     > > > run
>     >     > > >     > other
>     >     > > >     >     > targets that have bunches of Ant commands.  So
> when
>     >     > something
>     >     > > > fails,
>     >     > > >     > and
>     >     > > >     >     > you re-start from some Ant target, it is
> expecting
>     > certain
>     >     > > > starting
>     >     > > >     >     > conditions.  So sometimes you have to revert
> commits
>     > or
>     >     > > delete
>     >     > > > the
>     >     > > >     > branch
>     >     > > >     >     > and tags or sometimes you just delete the
> working
>     > copy.  It
>     >     > > > depends
>     >     > > >     > where
>     >     > > >     >     > you are starting from.  There are some Ant
> tasks
>     > that start
>     >     > > at
>     >     > > >     > certain
>     >     > > >     >     > points (like after royale-compiler and
>     > royale-typedefs have
>     >     > > > been
>     >     > > >     > completed)
>     >     > > >     >     > but it isn't so fine grain that you can start
>     > exactly from
>     >     > > the
>     >     > > > point
>     >     > > >     > of
>     >     > > >     >     > failure.
>     >     > > >     >     >
>     >     > > >     >     > HTH,
>     >     > > >     >     > -Alex
>     >     > > >     >     >
>     >     > > >     >     > On 9/12/18, 8:46 AM, "Piotr Zarzycki" <
>     >     > > > piotrzarzycki21@gmail.com>
>     >     > > >     > wrote:
>     >     > > >     >     >
>     >     > > >     >     >     I got fail on royale-asjs repo ->
>     >     > > >     >     >
>     >     > > >     >
>     >     > > >
>     >     > >
>     >     >
>     >
> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpaste.apache.org%2FBzVx&amp;data=02%7C01%7Caharui%40adobe.com%7C52945277f0d64479c60c08d61a5b879b%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636725377773552343&amp;sdata=YgXZpgzT%2Fv%2BCcLGxXID9LugaJvb6nkEgnKPiJVnlWls%3D&amp;reserved=0
>     >     > > >     >     >
>     >     > > >     >     >     I don't understand one thing from the
>     > instruction.
>     >     > Since
>     >     > > >     > something
>     >     > > >     >     > failed
>     >     > > >     >     >     during branch creation I need to revert
> changes.
>     >     > Probably
>     >     > > > remove
>     >     > > >     >     > branches
>     >     > > >     >     >     and revert everything in develop. - Yes ?
>     >     > > >     >     >
>     >     > > >     >     >     Instruction is saying in Canceling RC: "To
>     > cancel an RC
>     >     > > and
>     >     > > >     > generate a
>     >     > > >     >     > new
>     >     > > >     >     >     RC, you have to revert certain changes that
>     > Maven made
>     >     > to
>     >     > > > the
>     >     > > >     > release
>     >     > > >     >     >     branch." - Why only release branch ?
>     >     > > >     >     >
>     >     > > >     >     >     Should I not remove release branch ?
>     >     > > >     >     >
>     >     > > >     >     >     Thanks,
>     >     > > >     >     >     Piotr
>     >     > > >     >     >
>     >     > > >     >     >     śr., 12 wrz 2018 o 17:38 Piotr Zarzycki <
>     >     > > >     > piotrzarzycki21@gmail.com>
>     >     > > >     >     >     napisał(a):
>     >     > > >     >     >
>     >     > > >     >     >     > I just tried it from Git Bash and
> something
>     > started
>     >     > to
>     >     > > > work :)
>     >     > > >     >     >     >
>     >     > > >     >     >     > śr., 12 wrz 2018 o 17:36 Piotr Zarzycki <
>     >     > > >     > piotrzarzycki21@gmail.com>
>     >     > > >     >     >     > napisał(a):
>     >     > > >     >     >     >
>     >     > > >     >     >     >> I just go through SSH instruction again
> and
>     > re-added
>     >     > > > rsa key
>     >     > > >     > to
>     >     > > >     >     > GitHub,
>     >     > > >     >     >     >> but no luck so far.
>     >     > > >     >     >     >>
>     >     > > >     >     >     >> śr., 12 wrz 2018 o 17:36 Piotr Zarzycki
> <
>     >     > > >     > piotrzarzycki21@gmail.com>
>     >     > > >     >     >     >> napisał(a):
>     >     > > >     >     >     >>
>     >     > > >     >     >     >>> Yes - I have exactly two files there -
> the
>     > same as
>     >     > > you.
>     >     > > >     >     >     >>>
>     >     > > >     >     >     >>> śr., 12 wrz 2018 o 17:34 Alex Harui
>     >     > > > <aharui@adobe.com.invalid
>     >     > > >     > >
>     >     > > >     >     >     >>> napisał(a):
>     >     > > >     >     >     >>>
>     >     > > >     >     >     >>>> Are you running releasecandidate.xml
> from an
>     >     > 'empty
>     >     > > > folder
>     >     > > >     > and
>     >     > > >     >     > not in
>     >     > > >     >     >     >>>> your working copy?  I think the only
> thing
>     > I have
>     >     > in
>     >     > > > the
>     >     > > >     > folder is
>     >     > > >     >     >     >>>> releasecandidate.xml and
> local.properties.
>     >     > > >     >     >     >>>>
>     >     > > >     >     >     >>>> Get Outlook for Android<
>     >     > > >     >     >
>     >     > > >     >
>     >     > > >
>     >     > >
>     >     >
>     >
> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Faka.ms%2Fghei36&amp;data=02%7C01%7Caharui%40adobe.com%7C52945277f0d64479c60c08d61a5b879b%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636725377773552343&amp;sdata=SVi8NTxA06PTjMvNX9q9xzsEkOTle2FEUU%2BqvUz2G40%3D&amp;reserved=0
>     >     > > >     >     > >
>     >     > > >     >     >     >>>>
>     >     > > >     >     >     >>>> ________________________________
>     >     > > >     >     >     >>>> From: Piotr Zarzycki <
>     > piotrzarzycki21@gmail.com>
>     >     > > >     >     >     >>>> Sent: Wednesday, September 12, 2018
> 7:42:06
>     > AM
>     >     > > >     >     >     >>>> To: dev@royale.apache.org
>     >     > > >     >     >     >>>> Subject: Re: [Discuss] Start release
>     > process 0.9.3
>     >     > > >     >     >     >>>>
>     >     > > >     >     >     >>>> Yes I follow the SSH link. I will
> review
>     > stuff
>     >     > > again.
>     >     > > >     >     >     >>>>
>     >     > > >     >     >     >>>>
>     >     > > >     >     >     >>>> On Wed, Sep 12, 2018, 4:06 PM Alex
> Harui
>     >     > > >     > <aharui@adobe.com.invalid
>     >     > > >     >     > >
>     >     > > >     >     >     >>>> wrote:
>     >     > > >     >     >     >>>>
>     >     > > >     >     >     >>>> > Did you follow the SSH link from
> here?
>     >     > > >     >     >     >>>> >
>     >     > > >     >     >     >>>>
>     >     > > >     >     >
>     >     > > >     >
>     >     > > >
>     >     > >
>     >     >
>     >
> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Froyale-asjs%2Fwiki%2FRelease-Manager-Notes&amp;data=02%7C01%7Caharui%40adobe.com%7C52945277f0d64479c60c08d61a5b879b%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636725377773552343&amp;sdata=fQ0TehEDZBXjsb8Yh03GL1KAdPMEal6pkmRBzAGVPQY%3D&amp;reserved=0
>     >     > > >     >     >     >>>> >
>     >     > > >     >     >     >>>> > HTH,
>     >     > > >     >     >     >>>> > -Alex
>     >     > > >     >     >     >>>> >
>     >     > > >     >     >     >>>> > On 9/12/18, 4:55 AM, "Piotr
> Zarzycki" <
>     >     > > >     >     > piotrzarzycki21@gmail.com>
>     >     > > >     >     >     >>>> wrote:
>     >     > > >     >     >     >>>> >
>     >     > > >     >     >     >>>> >     I got first fail using
>     > releasecandidate.xml
>     >     > > > script
>     >     > > >     > [1]. It
>     >     > > >     >     > is fail
>     >     > > >     >     >     >>>> > during
>     >     > > >     >     >     >>>> >     git push, so I thought that I
> will
>     > try to
>     >     > run
>     >     > > > that
>     >     > > >     > command
>     >     > > >     >     > which
>     >     > > >     >     >     >>>> seems
>     >     > > >     >     >     >>>> > to
>     >     > > >     >     >     >>>> >     be cause of the problem
>     >     > > >     >     >     >>>> >
>     >     > > >     >     >     >>>> >     git push git@github.com:
>     >     > > > apache/royale-compiler.git
>     >     > > >     >     >     >>>> >
>  refs/heads/develop:refs/heads/develop
>     >     > > >     >     >     >>>> >
>     >     > > >     >     >     >>>> >     but with fetch
>     >     > > >     >     >     >>>> >
>     >     > > >     >     >     >>>> >     git fetch "git@github.com:
>     >     > > > apache/royale-compiler.git"
>     >     > > >     >     >     >>>> >
>  refs/heads/develop:refs/heads/develop
>     >     > > >     >     >     >>>> >     Enter passphrase for key
>     >     > > > '/c/Users/piotr/.ssh/id_rsa':
>     >     > > >     >     >     >>>> >     fatal: Refusing to fetch into
> current
>     > branch
>     >     > > >     >     > refs/heads/develop of
>     >     > > >     >     >     >>>> > non-bare
>     >     > > >     >     >     >>>> >     repository
>     >     > > >     >     >     >>>> >
>     >     > > >     >     >     >>>> >     Anyone have problems like that
> during
>     >     > release
>     >     > > > process
>     >     > > >     > ? I
>     >     > > >     >     > do have
>     >     > > >     >     >     >>>> SSH
>     >     > > >     >     >     >>>> > keys
>     >     > > >     >     >     >>>> >     added to my manager and GitHub
>     > account.
>     >     > > >     >     >     >>>> >
>     >     > > >     >     >     >>>> >     [1]
>     >     > > >     >     >     >>>> >
>     >     > > >     >     >     >>>>
>     >     > > >     >     >
>     >     > > >     >
>     >     > > >
>     >     > >
>     >     >
>     >
> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpaste.apache.org%2Fuyba&amp;data=02%7C01%7Caharui%40adobe.com%7C52945277f0d64479c60c08d61a5b879b%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636725377773552343&amp;sdata=Uh4ZEdxb%2F12QFfZlVCFBrrKJrs0iWUsyE3Lz4Rsc24E%3D&amp;reserved=0
>     >     > > >     >     >     >>>> >
>     >     > > >     >     >     >>>> >     Thanks,
>     >     > > >     >     >     >>>> >     Piotr
>     >     > > >     >     >     >>>> >
>     >     > > >     >     >     >>>> >     śr., 12 wrz 2018 o 11:36 Piotr
>     > Zarzycki <
>     >     > > >     >     >     >>>> piotrzarzycki21@gmail.com>
>     >     > > >     >     >     >>>> >     napisał(a):
>     >     > > >     >     >     >>>> >
>     >     > > >     >     >     >>>> >     > Hi Harbs,
>     >     > > >     >     >     >>>> >     >
>     >     > > >     >     >     >>>> >     > What's your progress on
> fixing that
>     > or
>     >     > > > eventually
>     >     > > >     > moving
>     >     > > >     >     > to
>     >     > > >     >     >     >>>> branch ?
>     >     > > >     >     >     >>>> > Can I
>     >     > > >     >     >     >>>> >     > proceed with stuff ?
>     >     > > >     >     >     >>>> >     >
>     >     > > >     >     >     >>>> >     > Thanks,
>     >     > > >     >     >     >>>> >     > Piotr
>     >     > > >     >     >     >>>> >     >
>     >     > > >     >     >     >>>> >     > śr., 12 wrz 2018 o 07:33 Alex
> Harui
>     >     > > >     >     > <aharui@adobe.com.invalid>
>     >     > > >     >     >     >>>> > napisał(a):
>     >     > > >     >     >     >>>> >     >
>     >     > > >     >     >     >>>> >     >> Speaking of upgrading, I
> think you
>     > will
>     >     > > need
>     >     > > > to
>     >     > > >     > use the
>     >     > > >     >     > latest
>     >     > > >     >     >     >>>> > maven or
>     >     > > >     >     >     >>>> >     >> somehow get Maven to use
> version
>     > 1.10.0
>     >     > of
>     >     > > > the
>     >     > > >     > Maven SCM
>     >     > > >     >     >     >>>> Plugin.
>     >     > > >     >     >     >>>> >     >>
>     >     > > >     >     >     >>>> >     >> I have most recently tweaked
> the
>     > Ant
>     >     > > scripts
>     >     > > > to
>     >     > > >     > generate
>     >     > > >     >     > the
>     >     > > >     >     >     >>>> > required
>     >     > > >     >     >     >>>> >     >> file extension on the SHA
> hashes.
>     >     > Assuming
>     >     > > > those
>     >     > > >     > changes
>     >     > > >     >     >     >>>> work, we
>     >     > > >     >     >     >>>> > should
>     >     > > >     >     >     >>>> >     >> be good to go.
>     >     > > >     >     >     >>>> >     >>
>     >     > > >     >     >     >>>> >     >> Good luck,
>     >     > > >     >     >     >>>> >     >> -Alex
>     >     > > >     >     >     >>>> >     >>
>     >     > > >     >     >     >>>> >     >> On 9/11/18, 12:28 PM, "Piotr
>     > Zarzycki" <
>     >     > > >     >     >     >>>> piotrzarzycki21@gmail.com>
>     >     > > >     >     >     >>>> >     >> wrote:
>     >     > > >     >     >     >>>> >     >>
>     >     > > >     >     >     >>>> >     >>     In case of upgrading
> anything I
>     >     > really
>     >     > > > suggest
>     >     > > >     > to
>     >     > > >     >     > leave it
>     >     > > >     >     >     >>>> for
>     >     > > >     >     >     >>>> > the
>     >     > > >     >     >     >>>> >     >> next
>     >     > > >     >     >     >>>> >     >>     release. If you upgrade
>     > something you
>     >     > > > have to
>     >     > > >     > take
>     >     > > >     >     > care of
>     >     > > >     >     >     >>>> > upgrading
>     >     > > >     >     >     >>>> >     >>     maven's pom as well.
>     >     > > >     >     >     >>>> >     >>
>     >     > > >     >     >     >>>> >     >>     Piotr
>     >     > > >     >     >     >>>> >     >>
>     >     > > >     >     >     >>>> >     >>     On Tue, Sep 11, 2018,
> 8:54 PM
>     > Alex
>     >     > > Harui
>     >     > > >     >     >     >>>> > <aharui@adobe.com.invalid>
>     >     > > >     >     >     >>>> >     >> wrote:
>     >     > > >     >     >     >>>> >     >>
>     >     > > >     >     >     >>>> >     >>     > I am still trying to
> fix the
>     > Maven
>     >     > > > build of
>     >     > > >     > the
>     >     > > >     >     > examples.
>     >     > > >     >     >     >>>> > Harb's
>     >     > > >     >     >     >>>> >     >> change
>     >     > > >     >     >     >>>> >     >>     > seems satisfactory for
> at
>     > least
>     >     > now.
>     >     > > >     >     >     >>>> >     >>     >
>     >     > > >     >     >     >>>> >     >>     > -Alex
>     >     > > >     >     >     >>>> >     >>     >
>     >     > > >     >     >     >>>> >     >>     > On 9/11/18, 11:47 AM,
>     > "Harbs" <
>     >     > > >     >     > harbs.lists@gmail.com>
>     >     > > >     >     >     >>>> wrote:
>     >     > > >     >     >     >>>> >     >>     >
>     >     > > >     >     >     >>>> >     >>     >     It should be good
> to go
>     > now
>     >     > > unless
>     >     > > > Alex
>     >     > > >     > or
>     >     > > >     >     > someone
>     >     > > >     >     >     >>>> else
>     >     > > >     >     >     >>>> > has
>     >     > > >     >     >     >>>> >     >> objections…
>     >     > > >     >     >     >>>> >     >>     >
>     >     > > >     >     >     >>>> >     >>     >     > On Sep 11, 2018,
> at
>     > 8:55 PM,
>     >     > > > Piotr
>     >     > > >     > Zarzycki <
>     >     > > >     >     >     >>>> >     >>     >
> piotrzarzycki21@gmail.com>
>     > wrote:
>     >     > > >     >     >     >>>> >     >>     >     >
>     >     > > >     >     >     >>>> >     >>     >     > No problem.
> Thank you!
>     > If I
>     >     > > start
>     >     > > >     > anything
>     >     > > >     >     > with
>     >     > > >     >     >     >>>> release
>     >     > > >     >     >     >>>> > that
>     >     > > >     >     >     >>>> >     >> would be
>     >     > > >     >     >     >>>> >     >>     >     > tomorrow morning
> or
>     > evening
>     >     > my
>     >     > > > time.
>     >     > > >     >     >     >>>> >     >>     >     >
>     >     > > >     >     >     >>>> >     >>     >     > Piotr
>     >     > > >     >     >     >>>> >     >>     >     >
>     >     > > >     >     >     >>>> >     >>     >     > wt., 11 wrz 2018
> o
>     > 19:54
>     >     > Harbs
>     >     > > <
>     >     > > >     >     >     >>>> harbs.lists@gmail.com>
>     >     > > >     >     >     >>>> >     >> napisał(a):
>     >     > > >     >     >     >>>> >     >>     >     >
>     >     > > >     >     >     >>>> >     >>     >     >> I’m going to
> spend a
>     > few
>     >     > > > minutes now
>     >     > > >     > to see
>     >     > > >     >     > if I
>     >     > > >     >     >     >>>> can
>     >     > > >     >     >     >>>> > resolve
>     >     > > >     >     >     >>>> >     >> this
>     >     > > >     >     >     >>>> >     >>     > simply.
>     >     > > >     >     >     >>>> >     >>     >     >> If not, I’ll
> revert.
>     >     > > >     >     >     >>>> >     >>     >     >>
>     >     > > >     >     >     >>>> >     >>     >     >> Harbs
>     >     > > >     >     >     >>>> >     >>     >     >>
>     >     > > >     >     >     >>>> >     >>     >     >>> On Sep 11,
> 2018, at
>     > 8:50
>     >     > PM,
>     >     > > > Piotr
>     >     > > >     >     > Zarzycki <
>     >     > > >     >     >     >>>> >     >>     >
> piotrzarzycki21@gmail.com>
>     >     > > >     >     >     >>>> >     >>     >     >> wrote:
>     >     > > >     >     >     >>>> >     >>     >     >>>
>     >     > > >     >     >     >>>> >     >>     >     >>> Hi Harbs,
>     >     > > >     >     >     >>>> >     >>     >     >>>
>     >     > > >     >     >     >>>> >     >>     >     >>> It would be
> great if
>     > you
>     >     > > could
>     >     > > > do
>     >     > > >     > that.
>     >     > > >     >     > You could
>     >     > > >     >     >     >>>> > bring back
>     >     > > >     >     >     >>>> >     >>     > changes
>     >     > > >     >     >     >>>> >     >>     >     >> again
>     >     > > >     >     >     >>>> >     >>     >     >>> after release
> and
>     > discuss
>     >     > > > whatever
>     >     > > >     > needed.
>     >     > > >     >     >     >>>> >     >>     >     >>> I think we are
> using
>     >     > > following
>     >     > > >     > version from
>     >     > > >     >     >     >>>> 20170626.
>     >     > > >     >     >     >>>> >     >>     >     >>>
>     >     > > >     >     >     >>>> >     >>     >     >>> Thanks,
>     >     > > >     >     >     >>>> >     >>     >     >>> Piotr
>     >     > > >     >     >     >>>> >     >>     >     >>>
>     >     > > >     >     >     >>>> >     >>     >     >>> wt., 11 wrz
> 2018 o
>     > 19:39
>     >     > > Harbs
>     >     > > > <
>     >     > > >     >     >     >>>> harbs.lists@gmail.com
>     >     > > >     >     >     >>>> > >
>     >     > > >     >     >     >>>> >     >> napisał(a):
>     >     > > >     >     >     >>>> >     >>     >     >>>
>     >     > > >     >     >     >>>> >     >>     >     >>>> I can revert
> the
>     > changes
>     >     > if
>     >     > > > that’s
>     >     > > >     > what
>     >     > > >     >     > folks
>     >     > > >     >     >     >>>> want.
>     >     > > >     >     >     >>>> > We’re
>     >     > > >     >     >     >>>> >     >> going
>     >     > > >     >     >     >>>> >     >>     > to have
>     >     > > >     >     >     >>>> >     >>     >     >>>> trace calls
> output
>     > if I do
>     >     > > > that,
>     >     > > >     > but we
>     >     > > >     >     > can
>     >     > > >     >     >     >>>> resolve
>     >     > > >     >     >     >>>> > that
>     >     > > >     >     >     >>>> >     >> for the
>     >     > > >     >     >     >>>> >     >>     > next
>     >     > > >     >     >     >>>> >     >>     >     >>>> release.
>     >     > > >     >     >     >>>> >     >>     >     >>>>
>     >     > > >     >     >     >>>> >     >>     >     >>>> I’m going to
> see if
>     > a
>     >     > > > different
>     >     > > >     > version
>     >     > > >     >     > of the
>     >     > > >     >     >     >>>> > closure
>     >     > > >     >     >     >>>> >     >> compiler
>     >     > > >     >     >     >>>> >     >>     > plays
>     >     > > >     >     >     >>>> >     >>     >     >>>> better. The
> latest
>     > version
>     >     > > > throws a
>     >     > > >     >     > NoSuchMethod
>     >     > > >     >     >     >>>> > error on
>     >     > > >     >     >     >>>> >     >>     >     >>>>
>     >     > > >     >     >     >>>> >     >>     >
>     >     > > >     >     >     >>>> >     >>
>     >     > > >     >     >     >>>> >
>     >     > > >     >     >
>     >     > > >
>     > com.google.javascript.jscomp.CompilerOptions.setInlineLocalFunctions.
>     >     > > >     >     >     >>>> >     >>     >     >>>>
>     >     > > >     >     >     >>>> >     >>     >     >>>> Anyone know
> which
>     > version
>     >     > > > we’re
>     >     > > >     > using now?
>     >     > > >     >     >     >>>> >     >>     >     >>>>
>     >     > > >     >     >     >>>> >     >>     >     >>>>> On Sep 11,
> 2018,
>     > at 9:09
>     >     > > AM,
>     >     > > > Carlos
>     >     > > >     >     > Rovira <
>     >     > > >     >     >     >>>> >     >>     >
> carlosrovira@apache.org>
>     >     > > >     >     >     >>>> >     >>     >     >>>> wrote:
>     >     > > >     >     >     >>>> >     >>     >     >>>>>
>     >     > > >     >     >     >>>> >     >>     >     >>>>> I think is
> better
>     > move
>     >     > that
>     >     > > >     > changes to a
>     >     > > >     >     >     >>>> branch and
>     >     > > >     >     >     >>>> >     >> release.
>     >     > > >     >     >     >>>> >     >>     >     >>>>> thanks
>     >     > > >     >     >     >>>> >     >>     >     >>>>>
>     >     > > >     >     >     >>>> >     >>     >     >>>>> El lun., 10
> sept.
>     > 2018 a
>     >     > > las
>     >     > > >     > 20:59, Piotr
>     >     > > >     >     >     >>>> Zarzycki
>     >     > > >     >     >     >>>> > (<
>     >     > > >     >     >     >>>> >     >>     >     >>>>>
>     >     > piotrzarzycki21@gmail.com
>     >     > > >)
>     >     > > >     > escribió:
>     >     > > >     >     >     >>>> >     >>     >     >>>>>
>     >     > > >     >     >     >>>> >     >>     >     >>>>>> Harbs,
>     >     > > >     >     >     >>>> >     >>     >     >>>>>>
>     >     > > >     >     >     >>>> >     >>     >     >>>>>> Can you
> comment
>     > on that
>     >     > ?
>     >     > > > Any
>     >     > > >     > chance to
>     >     > > >     >     > move
>     >     > > >     >     >     >>>> that
>     >     > > >     >     >     >>>> >     >> changes to
>     >     > > >     >     >     >>>> >     >>     > branch ?
>     >     > > >     >     >     >>>> >     >>     >     >>>>>>
>     >     > > >     >     >     >>>> >     >>     >     >>>>>> Thanks,
>     >     > > >     >     >     >>>> >     >>     >     >>>>>> Piotr
>     >     > > >     >     >     >>>> >     >>     >     >>>>>>
>     >     > > >     >     >     >>>> >     >>     >     >>>>>> pon., 10
> wrz 2018
>     > o
>     >     > 20:54
>     >     > > > Alex
>     >     > > >     > Harui
>     >     > > >     >     >     >>>> >     >> <aharui@adobe.com.invalid>
>     >     > > >     >     >     >>>> >     >>     >     >>>>>> napisał(a):
>     >     > > >     >     >     >>>> >     >>     >     >>>>>>
>     >     > > >     >     >     >>>> >     >>     >     >>>>>>> Yes.  I
> think we
>     > are
>     >     > > using
>     >     > > > the
>     >     > > >     > wrong
>     >     > > >     >     >     >>>> annotation
>     >     > > >     >     >     >>>> > for
>     >     > > >     >     >     >>>> >     >> variable
>     >     > > >     >     >     >>>> >     >>     > number
>     >     > > >     >     >     >>>> >     >>     >     >> of
>     >     > > >     >     >     >>>> >     >>     >     >>>>>>> parameters.
>     >     > > >     >     >     >>>> >     >>     >     >>>>>>>
>     >     > > >     >     >     >>>> >     >>     >     >>>>>>> -Alex
>     >     > > >     >     >     >>>> >     >>     >     >>>>>>>
>     >     > > >     >     >     >>>> >     >>     >     >>>>>>> On 9/10/18,
>     > 11:49 AM,
>     >     > > > "Piotr
>     >     > > >     > Zarzycki"
>     >     > > >     >     > <
>     >     > > >     >     >     >>>> >     >>     >
> piotrzarzycki21@gmail.com>
>     >     > > >     >     >     >>>> >     >>     >     >>>>>> wrote:
>     >     > > >     >     >     >>>> >     >>     >     >>>>>>>
>     >     > > >     >     >     >>>> >     >>     >     >>>>>>>  Alex,
>     >     > > >     >     >     >>>> >     >>     >     >>>>>>>
>     >     > > >     >     >     >>>> >     >>     >     >>>>>>>  What
> trace hack
>     > are
>     >     > you
>     >     > > >     > referring to
>     >     > > >     >     > ? This
>     >     > > >     >     >     >>>> is
>     >     > > >     >     >     >>>> > related
>     >     > > >     >     >     >>>> >     >> what
>     >     > > >     >     >     >>>> >     >>     > Harbs
>     >     > > >     >     >     >>>> >     >>     >     >>>>>>> commits ?
>     >     > > >     >     >     >>>> >     >>     >     >>>>>>>
>     >     > > >     >     >     >>>> >     >>     >     >>>>>>>  Thanks,
>     >     > > >     >     >     >>>> >     >>     >     >>>>>>>  Piotr
>     >     > > >     >     >     >>>> >     >>     >     >>>>>>>
>     >     > > >     >     >     >>>> >     >>     >     >>>>>>>  pon., 10
> wrz
>     > 2018 o
>     >     > > 20:47
>     >     > > > Alex
>     >     > > >     > Harui
>     >     > > >     >     >     >>>> >     >> <aharui@adobe.com.invalid
>     >     > > >     >     >     >>>> >     >>     > >
>     >     > > >     >     >     >>>> >     >>     >     >>>>>>> napisał(a):
>     >     > > >     >     >     >>>> >     >>     >     >>>>>>>
>


-- 

Piotr Zarzycki

Patreon: *https://www.patreon.com/piotrzarzycki
<https://www.patreon.com/piotrzarzycki>*

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message