royale-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Carlos Rovira <carlosrov...@apache.org>
Subject Re: [Discuss] Start release process 0.9.3
Date Sun, 02 Sep 2018 15:22:08 GMT
HI Piotr,

sorry about that, I can't never imagine that a normal var in maven (i.e:
${someVar}), would break something else in the other side of the world
(i.e: lexUnit test).
It's like if we insert a private var someVar:String in AS3 and this break a
build.

This one is very difficult, and I think something is not ok there. My bet
is that ${} tokens are ok, and FlexUnit are using it in a bad way (since is
code, and that code can be instructed to read ${} instead {}

Anyway is not important right now, but will be after release and will need
to find a solution

Thanks




El dom., 2 sept. 2018 a las 13:35, Piotr Zarzycki (<
piotrzarzycki21@gmail.com>) escribió:

> Hi Carlos,
>
> Please let's do not make such drastical steps. It looks like Harbs found
> where the issue is.
>
> Let's make the changes and see whether it is working.
>
> Harbs can you do this?
>
> Thanks,
> Piotr
>
> On Sun, Sep 2, 2018, 12:42 PM Harbs <harbs.lists@gmail.com> wrote:
>
> > To tell you the truth, I don’t understand exactly how the tokens are
> > working, but the $ prefix definitely breaks it.
> >
> > I’m guessing the brackets is an XML construct recognized as a variable in
> > things like E4X.
> >
> > Harbs
> >
> > > On Sep 2, 2018, at 1:30 PM, Carlos Rovira <carlosrovira@apache.org>
> > wrote:
> > >
> > > Hi Habs,
> > >
> > > El dom., 2 sept. 2018 a las 11:42, Harbs (<harbs.lists@gmail.com>)
> > escribió:
> > >
> > >> I found the problem.
> > >>
> > >> Carlos, I don’t know why you changed the tokens in the config files,
> but
> > >> changing them made them unrecognized and caused the FlexUnit tests to
> > fail.
> > >>
> > >>
> > > I thought the tokens you refer was not correctly setup, since doesn't
> > have
> > > the $ symbol and this way those are not interpreted and changed by
> maven.
> > > What I tried to do is fix maven build distribution. When I create a SDK
> > vía
> > > Maven, I get flex-config.xml and other files with
> > >
> > >
> > >
> >
> <path-element>{playerglobalHome}/{targetPlayerMajorVersion}.{targetPlayerMinorVersion}/playerglobal.swc</path-element>
> > >
> > > instead of
> > >
> > >          <path-element>libs/path/20.0/playerglobal.swc</path-element>
> > >
> > > that is what IDEs expect.
> > >
> > > Maybe this is not the way to get this? if not how could we get maven
> > > generates those files?. In the other hand, Can FlexUnit change to
> > recognize
> > > token with $ prefix?
> > >
> > > Thanks
> > >
> > >
> > > --
> > > Carlos Rovira
> > > http://about.me/carlosrovira
> >
> >
>


-- 
Carlos Rovira
http://about.me/carlosrovira

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message