royale-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Harbs <harbs.li...@gmail.com>
Subject Re: [royale-asjs] branch develop updated: fix maven examples
Date Tue, 11 Sep 2018 20:31:54 GMT
I once spent time on this and things started unraveling pretty quickly.

This was a very long time ago, so it might be easier now…

> On Sep 11, 2018, at 11:29 PM, Carlos Rovira <carlosrovira@apache.org> wrote:
> 
> Ok I undertand now.
> 
> It seems it will be right to change it, but maybe other things has priority
> 
> thanks
> 
> El mar., 11 sept. 2018 a las 22:23, Alex Harui (<aharui@adobe.com.invalid>)
> escribió:
> 
>> I'm pretty sure this has been discussed before.  In SWF, MouseEvent does
>> not subclass org.apache.royale.events.Event since MouseEvent subclasses
>> flash.events.MouseEvent.  Nobody is really happy about it, but that's the
>> way it is right now.  Volunteers are welcome to try to change it.
>> 
>> -Alex
>> 
>> On 9/11/18, 1:18 PM, "Carlos Rovira" <carlosrovira@apache.org> wrote:
>> 
>>    Hi Alex,
>> 
>>    so this was incorrect? we can't use Event instead of MouseEvent, or is
>> just
>>    to improve the actual code?
>>    thanks!
>> 
>>    El mar., 11 sept. 2018 a las 22:05, <aharui@apache.org> escribió:
>> 
>>> This is an automated email from the ASF dual-hosted git repository.
>>> 
>>> aharui pushed a commit to branch develop
>>> in repository
>> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%2Froyale-asjs.git&amp;data=02%7C01%7Caharui%40adobe.com%7C22d5029a52ff43e1179e08d61823ccbd%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636722939372313398&amp;sdata=%2B89SaOGpAMqKOj%2F21QIslYwu3zNQU8rbDBVUZevaMdw%3D&amp;reserved=0
>>> 
>>> 
>>> The following commit(s) were added to refs/heads/develop by this
>> push:
>>>     new 64a0795  fix maven examples
>>> 64a0795 is described below
>>> 
>>> commit 64a0795f6ddd71a0c7c2a8449c3b316fa3ea62b3
>>> Author: Alex Harui <aharui@apache.org>
>>> AuthorDate: Tue Sep 11 13:05:31 2018 -0700
>>> 
>>>    fix maven examples
>>> ---
>>> .../royale/BE0004_Adding_an_item_to_a_Jewel_List.mxml   |  4 +++-
>>> .../src/main/royale/org/apache/royale/jewel/CheckBox.as | 17
>>> +++++++++++++++++
>>> 2 files changed, 20 insertions(+), 1 deletion(-)
>>> 
>>> diff --git
>>> 
>> a/examples/blog/BE0004_Adding_an_item_to_a_Jewel_List/src/main/royale/BE0004_Adding_an_item_to_a_Jewel_List.mxml
>>> 
>> b/examples/blog/BE0004_Adding_an_item_to_a_Jewel_List/src/main/royale/BE0004_Adding_an_item_to_a_Jewel_List.mxml
>>> index 8fe8349..f8d451c 100644
>>> ---
>>> 
>> a/examples/blog/BE0004_Adding_an_item_to_a_Jewel_List/src/main/royale/BE0004_Adding_an_item_to_a_Jewel_List.mxml
>>> +++
>>> 
>> b/examples/blog/BE0004_Adding_an_item_to_a_Jewel_List/src/main/royale/BE0004_Adding_an_item_to_a_Jewel_List.mxml
>>> @@ -24,11 +24,13 @@
>>> 
>>>     <fx:Script>
>>>                <![CDATA[
>>> +            import org.apache.royale.events.MouseEvent;
>>> +
>>>             private function changeHandler(event:Event):void {
>>>                 selected.text = "Selected: " + list.selectedItem;
>>>             }
>>> 
>>> -            private function clickHandler(event:Event):void {
>>> +            private function clickHandler(event:MouseEvent):void {
>>>                 avengersCharacters.addItem("Hawkeye");
>>>             }
>>>                ]]>
>>> diff --git
>>> 
>> a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/CheckBox.as
>>> 
>> b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/CheckBox.as
>>> index 2380089..e0b310d 100644
>>> ---
>>> 
>> a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/CheckBox.as
>>> +++
>>> 
>> b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/CheckBox.as
>>> @@ -128,6 +128,23 @@ package org.apache.royale.jewel
>>>                        IToggleButtonModel(model).selected = value;
>>>                }
>>> 
>>> +        /**
>>> +         *  The value associated with the CheckBox.
>>> +         *
>>> +         *  @langversion 3.0
>>> +         *  @playerversion Flash 10.2
>>> +         *  @playerversion AIR 2.6
>>> +         *  @productversion Royale 0.9
>>> +         */
>>> +        public function get value():String
>>> +        {
>>> +            return IToggleButtonModel(model).html;
>>> +        }
>>> +        public function set value(newValue:String):void
>>> +        {
>>> +            IToggleButtonModel(model).html = newValue;
>>> +        }
>>> +
>>>                private function
>>> internalMouseHandler(event:org.apache.royale.events.MouseEvent) :
>> void
>>>                {
>>>                        selected = !selected;
>>> 
>>> 
>> 
>>    --
>>    Carlos Rovira
>> 
>> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&amp;data=02%7C01%7Caharui%40adobe.com%7C22d5029a52ff43e1179e08d61823ccbd%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636722939372313398&amp;sdata=tNecYSfwEi5ZVKxo%2FB5vD%2BEjwBtOWbpFKcvJ24i%2Bz4s%3D&amp;reserved=0
>> 
>> 
>> 
> 
> -- 
> Carlos Rovira
> http://about.me/carlosrovira


Mime
View raw message