royale-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Harbs <harbs.li...@gmail.com>
Subject Re: [royale-asjs] 05/06: try listening for both click or mouseup. Menu needs mouse up probably because it is gone before click comes through
Date Thu, 13 Sep 2018 09:26:42 GMT
Which Menu component is this?

> On Sep 13, 2018, at 11:57 AM, Alex Harui <aharui@adobe.com.INVALID> wrote:
> 
> Menu doesn't seem to get a click.  I think the menu is dismissed on mouseUp so the click
never happens.  Your change in June broke menu.
> 
> Why would renderers dispatch the same event on both mouseUp and click?  Seems like they
should use one or the other.  It might be that we should change Menu to rely on click and
not mouseUp, but that seems like something other people will trip over.
> 
> HTH,
> -Alex
> 
> On 9/13/18, 1:30 AM, "Harbs" <harbs.lists@gmail.com <mailto:harbs.lists@gmail.com>>
wrote:
> 
>    This causes two events to be fired when an item renderer is selected.
> 
>    Mouse up causes the event to be fired even when you mouse down outside the item renderer
and then mouse up inside the item renderer. I changed it from mouse up to click in June.
> 
>    What was the exact issue that you were trying to fix? I’m not sure what the right
solution is here, but both events is definitely wrong.
> 
>    Harbs
> 
>> On Sep 7, 2018, at 3:02 AM, aharui@apache.org <mailto:aharui@apache.org> wrote:
>> 
>> This is an automated email from the ASF dual-hosted git repository.
>> 
>> aharui pushed a commit to branch develop
>> in repository https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%2Froyale-asjs.git&amp;data=02%7C01%7Caharui%40adobe.com%7Cf17b2087bf704cec99d408d619532577%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636724242241298190&amp;sdata=Qg1UtYbkV8GXqaO3hIrxQvbvz%2BynVLx413UMT3qOWtA%3D&amp;reserved=0
<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%2Froyale-asjs.git&amp;data=02%7C01%7Caharui%40adobe.com%7Cf17b2087bf704cec99d408d619532577%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636724242241298190&amp;sdata=Qg1UtYbkV8GXqaO3hIrxQvbvz%2BynVLx413UMT3qOWtA%3D&amp;reserved=0>
>> 
>> commit 7d9a1a1330ab6732ae9d7963fb694c5594b5f24d
>> Author: Alex Harui <aharui@apache.org>
>> AuthorDate: Thu Sep 6 17:01:12 2018 -0700
>> 
>>   try listening for both click or mouseup.  Menu needs mouse up probably because
it is gone before click comes through
>> ---
>> .../apache/royale/html/beads/controllers/ItemRendererMouseController.as  | 1 +
>> 1 file changed, 1 insertion(+)
>> 
>> diff --git a/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/beads/controllers/ItemRendererMouseController.as
b/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/beads/controllers/ItemRendererMouseController.as
>> index 6073264..f408a71 100644
>> --- a/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/beads/controllers/ItemRendererMouseController.as
>> +++ b/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/beads/controllers/ItemRendererMouseController.as
>> @@ -92,6 +92,7 @@ COMPILE::JS {
>> 				goog.events.listen(element, goog.events.EventType.MOUSEOUT, this.handleMouseOut);
>> 				goog.events.listen(element, goog.events.EventType.MOUSEDOWN, this.handleMouseDown);
>> 				goog.events.listen(element, goog.events.EventType.CLICK, this.handleMouseUp);
>> +                goog.events.listen(element, goog.events.EventType.MOUSEUP, this.handleMouseUp);
>> 			}
>> 		}


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message