royale-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Harbs <harbs.li...@gmail.com>
Subject Re: [royale-asjs] branch feature/MXRoyale updated: Update ApplicationDomain.as
Date Thu, 06 Sep 2018 16:31:14 GMT
I get that. I was just curious why the setter was removed…

Either way, if there’s some low hanging fruit in the emulation that you think I should work
on, let me know… I don’t have a lot of time right now, but I’m happy to help with what
I can.

Harbs

> On Sep 6, 2018, at 7:19 PM, Alex Harui <aharui@adobe.com.INVALID> wrote:
> 
> Alina's primary goal is to get all of her code to compile, so many emulation APIs are
currently stubs that return null or 0 or "".  
> 
> My goal is to get this stuff to run, so I fill in the method bodies with real code. 
Hopefully other committers will pitch in soon.
> 
> -Alex
> 
> On 9/6/18, 9:17 AM, "Harbs" <harbs.lists@gmail.com <mailto:harbs.lists@gmail.com>>
wrote:
> 
>    Dunno. It just seems odd to me that it was changed to always return null.
> 
>    I was just asking. I was not following the work on this closely enough.
> 
>> On Sep 6, 2018, at 6:55 PM, Alex Harui <aharui@adobe.com.INVALID <mailto:aharui@adobe.com.INVALID>>
wrote:
>> 
>> Harbs, what was wrong with this commit?  It looked ok to me.  currentDomain is static.
>> 
>> -Alex
>> 
>> On 9/6/18, 2:27 AM, "Alina Kazi" <alina.kazi@d-bz.com <mailto:alina.kazi@d-bz.com>
<mailto:alina.kazi@d-bz.com <mailto:alina.kazi@d-bz.com>>> wrote:
>> 
>>   Reverting this Commit. 
>> 
>>   -----Original Message-----
>>   From: Harbs [mailto:harbs.lists@gmail.com <mailto:harbs.lists@gmail.com>]

>>   Sent: Thursday, September 06, 2018 1:08 PM
>>   To: dev@royale.apache.org <mailto:dev@royale.apache.org>
>>   Subject: Re: [royale-asjs] branch feature/MXRoyale updated: Update
>>   ApplicationDomain.as
>> 
>>   Why was the currentDomain setter removed?
>> 
>>> On Sep 6, 2018, at 8:15 AM, alinakazi@apache.org <mailto:alinakazi@apache.org>
wrote:
>>> 
>>> This is an automated email from the ASF dual-hosted git repository.
>>> 
>>> alinakazi pushed a commit to branch feature/MXRoyale in repository 
>>> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%2Froyale-asjs.git&amp;data=02%7C01%7Caharui%40adobe.com%7C133b6ea757c849b9a69308d614143aa5%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636718474443813011&amp;sdata=gjL3N4gZJkwiW%2Bj9w2Og%2BQnt93CcSmzHTdgBgrgyWhE%3D&amp;reserved=0
<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%2Froyale-asjs.git&amp;data=02%7C01%7Caharui%40adobe.com%7C133b6ea757c849b9a69308d614143aa5%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636718474443813011&amp;sdata=gjL3N4gZJkwiW%2Bj9w2Og%2BQnt93CcSmzHTdgBgrgyWhE%3D&amp;reserved=0>
<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%2Froyale-asjs.git&amp;data=02%7C01%7Caharui%40adobe.com%7C133b6ea757c849b9a69308d614143aa5%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636718474443813011&amp;sdata=gjL3N4gZJkwiW%2Bj9w2Og%2BQnt93CcSmzHTdgBgrgyWhE%3D&amp;reserved=0
<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%2Froyale-asjs.git&amp;data=02%7C01%7Caharui%40adobe.com%7C133b6ea757c849b9a69308d614143aa5%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636718474443813011&amp;sdata=gjL3N4gZJkwiW%2Bj9w2Og%2BQnt93CcSmzHTdgBgrgyWhE%3D&amp;reserved=0>>
>>> 
>>> 
>>> The following commit(s) were added to refs/heads/feature/MXRoyale by this
>>   push:
>>>   new aa1b2d8  Update ApplicationDomain.as
>>> aa1b2d8 is described below
>>> 
>>> commit aa1b2d855088e68d2dddc6e400dfb7281705ab2a
>>> Author: alinakazi <ALINAKAZI1990@GMAIL.COM <mailto:ALINAKAZI1990@GMAIL.COM>>
>>> AuthorDate: Thu Sep 6 10:15:16 2018 +0500
>>> 
>>>  Update ApplicationDomain.as
>>> ---
>>> .../src/main/royale/mx/system/ApplicationDomain.as    | 19
>>   ++++++++-----------
>>> 1 file changed, 8 insertions(+), 11 deletions(-)
>>> 
>>> diff --git 
>>> a/frameworks/projects/MXRoyale/src/main/royale/mx/system/ApplicationDo
>>> main.as 
>>> b/frameworks/projects/MXRoyale/src/main/royale/mx/system/ApplicationDo
>>> main.as
>>> index 156ac2d..59474bf 100644
>>> --- 
>>> a/frameworks/projects/MXRoyale/src/main/royale/mx/system/ApplicationDo
>>> main.as
>>> +++ b/frameworks/projects/MXRoyale/src/main/royale/mx/system/Applicati
>>> +++ onDomain.as
>>> @@ -47,25 +47,22 @@ public class ApplicationDomain extends Object
>>>    *  @playerversion AIR 1.1
>>>    *  @productversion Royale 0.0
>>>    */
>>> -	private var _currentDomain:Object;
>>> -
>>> -	public function get currentDomain():Object
>>> +	
>>> +	
>>> +    public function ApplicationDomain()
>>>   {
>>> -        return _currentDomain;
>>> +        super();
>>>   }
>>> -    
>>> -    public function set currentDomain(obj:Object):void
>>> -    {
>>> -		_currentDomain = obj;
>>> +
>>> +	public static function get currentDomain():ApplicationDomain
>>> +	{
>>> +		return null;
>>> 	}
>>> 	
>>> -	
>>> -	
>>>   public function ApplicationDomain()
>>>   {
>>>       super();
>>>   }
>>> -
>>> }
>>> 
>>> }


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message