royale-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Harui <aha...@adobe.com.INVALID>
Subject Re: Possible compiler error
Date Tue, 28 Aug 2018 16:45:30 GMT
If ListView is in a different SWC and that SWC doesn't get re-compiled, you can run into this
sort of problem.  If ListView is in a different SWC, make sure that SWC does compile cleanly
by examining the console output.  I think I've seen some errors fail to rebuild the SWC but
still report success to Ant and Maven.

HTH,
-Alex

On 8/28/18, 9:36 AM, "Harbs" <harbs.lists@gmail.com> wrote:

    There’s a number of places in the framework where there’s overrides with parameters
that default to null:
    ElementWrapper has:         override public function addEventListener(type:String, handler:Function,
opt_capture:Boolean = false, opt_handlerScope:Object = null):void
    TableLeafElement has: 		public override function getNextLeaf(limitElement:IFlowGroupElement=null):IFlowLeafElement
    
    etc.
    
    There must be something else going on in your case.
    
    Harbs
    
    > On Aug 28, 2018, at 6:57 PM, Carlos Rovira <carlosrovira@apache.org> wrote:
    > 
    > Hi,
    > thanks for the responses, but maybe I didn't express right. I mean the
    > superclass signature is in ListView
    > 
    > protected function selectionChangeHandler(event:Event):void
    > 
    > and I want to change it to have default "= null":
    > 
    > protected function selectionChangeHandler(event:Event = null):void
    > 
    > then child class (TableView) will need to be like the following override:
    > 
    > override protected function selectionChangeHandler(event:Event = null):void
    > 
    > this throws:
    > 
    > /Users/carlosrovira/Dev/Royale/Source/royale-asjs/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/views/TableView.as(99):
    > col: 31 Error: Incompatible override.
    > 
    >        override protected function selectionChangeHandler(event:Event =
    > null):void
    >         ^
    > 
    > /Users/carlosrovira/Dev/Royale/Source/royale-asjs/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/views/TableView.as(99):
    > col: 31 Incompatible override.
    > 
    >        override protected function selectionChangeHandler(event:Event =
    > null):void
    > 
    > If like Harbs said is an AS3 restriction is ok for me, in fact I don't need
    > it now, since I took other path to make what I want.
    > If is a compiler bug then we must to write an issue.
    > 
    > 
    > 
    > 
    > El mar., 28 ago. 2018 a las 13:03, Olaf Krueger (<mail@olafkrueger.net>)
    > escribió:
    > 
    >> Hi Carlos,
    >> as Harbs mentioned, my experience is also, that implemented interface
    >> methods or overridden methods always has to be implemented with the entire
    >> same signature, including optional (default parameters) and required
    >> parameters.
    >> 
    >> From the AS3 docs regarding interfaces [1]:
    >> "You also have some flexibility with default parameter values. An interface
    >> definition can include function declarations with default parameter values.
    >> A method that implements such a function declaration must have a default
    >> parameter value that is a member of the same data type as the value
    >> specified in the interface definition, but the actual value does not have
    >> to
    >> match"
    >> 
    >> Why do you think that this doesn't make sense?
    >> 
    >> Olaf
    >> 
    >> [1]
    >> 
    >> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fhelp.adobe.com%2Fen_US%2Fas3%2Flearn%2FWS5b3ccc516d4fbf351e63e3d118a9b90204-7f41.html%23WS5b3ccc516d4fbf351e63e3d118a9b90204-7f20&amp;data=02%7C01%7Caharui%40adobe.com%7C7fd740aa9f8745ec0bd908d60d046adf%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636710709957739902&amp;sdata=G%2FRlWCRC3jzjnrOUqk%2FnfT7kC3iyYVWoRVR7G0COdCU%3D&amp;reserved=0
    >> 
    >> 
    >> 
    >> 
    >> --
    >> Sent from: https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapache-royale-development.20373.n8.nabble.com%2F&amp;data=02%7C01%7Caharui%40adobe.com%7C7fd740aa9f8745ec0bd908d60d046adf%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636710709957739902&amp;sdata=yF2EZpkCKhTmfPfpeFsP2JTG31GBNQnHwGfi62251BY%3D&amp;reserved=0
    >> 
    >> --
    >> Carlos Rovira
    >> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&amp;data=02%7C01%7Caharui%40adobe.com%7C7fd740aa9f8745ec0bd908d60d046adf%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636710709957739902&amp;sdata=Hc4z9dO0jzVVmCTe7pFMmZqcRS24xbhuT3gb9tHxHoc%3D&amp;reserved=0
    >> 
    >> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapache-royale-development.20373.n8.nabble.com%2F&amp;data=02%7C01%7Caharui%40adobe.com%7C7fd740aa9f8745ec0bd908d60d046adf%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636710709957739902&amp;sdata=yF2EZpkCKhTmfPfpeFsP2JTG31GBNQnHwGfi62251BY%3D&amp;reserved=0>
    >> 
    >> 
    
    

Mime
View raw message