royale-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Carlos Rovira <carlosrov...@apache.org>
Subject Re: [royale-asjs] branch develop updated: Fixes #258. But is that a proper fix?
Date Mon, 04 Jun 2018 07:20:43 GMT
Hi Yishay,

this seems like a bug to be fixed at the core of the component, or the
layout system.

I was not aware about Layout Challenges page. But for me I'll prefer to
discuss in mailing list, since GitHub pages seems more like a reference
site, more than a discussion place. Said that this weekend I was making
some important changes to jewel layouts, I want to fix some left things and
write about it to let you all know what's all about.

thanks


2018-06-03 12:21 GMT+02:00 Yishay Weiss <yishayjobs@hotmail.com>:

> This could be a good topic to put down here…
>
> https://github.com/apache/royale-asjs/wiki/Layout-Challenges
>
>
> ________________________________
> From: Yishay Weiss <yishayjobs@hotmail.com>
> Sent: Sunday, June 3, 2018 1:18:03 PM
> To: dev@royale.apache.org
> Subject: RE: [royale-asjs] branch develop updated: Fixes #258. But is that
> a proper fix?
>
> I’ve seen several instances where the offsetParent hasn’t been set yet
> when layout is run, which messes things up. I solved this here by running
> another layout at a later time but I’m interested to hear others on how
> this should be solved.
>
> From: yishayw@apache.org<mailto:yishayw@apache.org>
> Sent: Sunday, June 3, 2018 1:12 PM
> To: commits@royale.apache.org<mailto:commits@royale.apache.org>
> Subject: [royale-asjs] branch develop updated: Fixes #258. But is that a
> proper fix?
>
> This is an automated email from the ASF dual-hosted git repository.
>
> yishayw pushed a commit to branch develop
> in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
>
>
> The following commit(s) were added to refs/heads/develop by this push:
>      new 37a3a6d  Fixes #258. But is that a proper fix?
> 37a3a6d is described below
>
> commit 37a3a6d5a433d97b654b134f4d354214224172b6
> Author: DESKTOP-RH4S838\Yishay <yishayjobs@hotmail.com>
> AuthorDate: Sun Jun 3 13:11:31 2018 +0300
>
>     Fixes #258. But is that a proper fix?
> ---
>  examples/royale/TreeExample/src/main/royale/MyInitialView.mxml | 7
> ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/examples/royale/TreeExample/src/main/royale/MyInitialView.mxml
> b/examples/royale/TreeExample/src/main/royale/MyInitialView.mxml
> index 8b70a52..f25bfdf 100644
> --- a/examples/royale/TreeExample/src/main/royale/MyInitialView.mxml
> +++ b/examples/royale/TreeExample/src/main/royale/MyInitialView.mxml
> @@ -39,6 +39,11 @@ limitations under the License.
>
>          <fx:Script>
>                  <![CDATA[
> +               override public function addedToParent():void
> +               {
> +                       super.addedToParent();
> +                       treeGrid.dispatchEvent(new Event('layoutNeeded'));
> +               }
>                  ]]>
>          </fx:Script>
>
> @@ -56,7 +61,7 @@ limitations under the License.
>                  </js:beads>
>          </js:Tree>
>
> -       <js:TreeGrid x="450" y="30" width="500" height="500"
> rowHeight="40">
> +       <js:TreeGrid id="treeGrid" x="450" y="30" width="500" height="500"
> rowHeight="40">
>                  <js:beads>
>                          <js:ConstantBinding
>                                  sourceID="applicationModel"
>
> --
> To stop receiving notification emails like this one, please contact
> yishayw@apache.org.
>
>


-- 
Carlos Rovira
http://about.me/carlosrovira

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message