royale-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yishay Weiss <yishayj...@hotmail.com>
Subject RE: [royale-asjs] branch develop updated: fix latest commit, since binary data to string method was not really working
Date Mon, 11 Jun 2018 09:02:44 GMT
Carols,



This breaks our app on IE and Edge, as they don’t support TextDecoder. Can you fix this?



________________________________
From: carlosrovira@apache.org <carlosrovira@apache.org>
Sent: Sunday, May 27, 2018 11:29:14 PM
To: commits@royale.apache.org
Subject: [royale-asjs] branch develop updated: fix latest commit, since binary data to string
method was not really working

This is an automated email from the ASF dual-hosted git repository.

carlosrovira pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git


The following commit(s) were added to refs/heads/develop by this push:
     new 028a26a  fix latest commit, since binary data to string method was not really working
028a26a is described below

commit 028a26ad29aac3740f150f9b971e310731a69db9
Author: Carlos Rovira <carlosrovira@apache.org>
AuthorDate: Sun May 27 22:28:57 2018 +0200

    fix latest commit, since binary data to string method was not really working
---
 .../Core/src/main/royale/org/apache/royale/utils/BinaryData.as        | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/frameworks/projects/Core/src/main/royale/org/apache/royale/utils/BinaryData.as
b/frameworks/projects/Core/src/main/royale/org/apache/royale/utils/BinaryData.as
index 0aa3097..5500c8f 100644
--- a/frameworks/projects/Core/src/main/royale/org/apache/royale/utils/BinaryData.as
+++ b/frameworks/projects/Core/src/main/royale/org/apache/royale/utils/BinaryData.as
@@ -213,7 +213,7 @@ public class BinaryData implements IBinaryDataInput, IBinaryDataOutput

         COMPILE::JS
         {
-            return String.fromCharCode.apply(null, new Uint16Array(ba));
+            return (new TextDecoder("utf-8")).decode(ba);
         }
         }

@@ -804,7 +804,7 @@ public class BinaryData implements IBinaryDataInput, IBinaryDataOutput
         }
         COMPILE::JS
         {
-            return _len;;
+            return _len;
         }
     }


--
To stop receiving notification emails like this one, please contact
carlosrovira@apache.org.

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message