royale-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Harui <aha...@adobe.com.INVALID>
Subject Re: Container change
Date Mon, 07 May 2018 05:25:25 GMT
For something to be in Core, it really should be a "universal implementation", meaning it contains
code that just about every component set will need.

I don't think Container is universal.  ContainerBase might be.
ItemRendererMouseController and DataItemRenderer?  Not sure.

FWIW, trying to eliminate all dependencies from Jewel to Basic doesn't make sense to me. 
Especially if it is going to result in duplication of code.  So what if Jewel components want
to use some Basic class?  Sometimes a Basic implementation is all you need.

My 2 cents,
-Alex

On 5/6/18, 10:28 AM, "carlos.rovira@gmail.com on behalf of Carlos Rovira" <carlos.rovira@gmail.com
on behalf of carlosrovira@apache.org> wrote:

    Hi Harbs,
    
    just commited a change that return the controller to Basic to html package
    let me now if that fixes your problem
    
    thanks
    
    Carlos
    
    
    2018-05-06 12:25 GMT+02:00 Carlos Rovira <carlosrovira@apache.org>:
    
    > Just returned Container to Basic without problem.
    >
    > But seems to me that this change should not make any problem at all for
    > anyone, since is in the same package (core) and all examples build without
    > problem, so any other App should as well build without any change.
    >
    >
    >
    >
    > 2018-05-06 12:00 GMT+02:00 Carlos Rovira <carlosrovira@apache.org>:
    >
    >> Hi
    >>
    >> dealing with ItemRendererMouseController there's a dependency in
    >> DataItemRenderer, and that was needed to move to Core, since is core in
    >> itself. Thinking about it that controller seems to have a very core
    >> functionality, so IMHO is that is better to upgrade Apps changing "html"
    >> package to "core". If I'm not missing something that change should be
    >> very straight forward to do (I made lots of this in examples, and use to be
    >> one or two places)
    >>
    >> I'll go to revise Container
    >>
    >>
    >>
    >> 2018-05-06 11:39 GMT+02:00 Carlos Rovira <carlosrovira@apache.org>:
    >>
    >>> Hi Piotr,
    >>>
    >>> I'm using HTML only for some headings, at the moment, but as Harbs said
    >>> in the other thread about HTML, it was depending from Group and that wasn't
    >>> needed, and that make HTML pull the complete Basic dependency when not
    >>> required, and that's made lots of CSS be linked.
    >>>
    >>> So HTML for me was only used to use some H3, headings, and SPAN
    >>>
    >>> In the other hand the controller seems to me more from Basic so I think
    >>> is ok to return it to Basic, it doesn't nothing to do with HTML.
    >>>
    >>> In the end some last fixes are normal in a refactor like this.
    >>>
    >>> thanks! :)
    >>>
    >>> 2018-05-06 10:09 GMT+02:00 Piotr Zarzycki <piotrzarzycki21@gmail.com>:
    >>>
    >>>> I'm a bit afraid to pull down changes. :) Let's think a bit more about
    >>>> that. Carlos wanted to totally separate each module. He didn't want to
    >>>> have
    >>>> dependency in Jewel from Basic.
    >>>>
    >>>> As I understand he was using HTML module which seems to be dependent
on
    >>>> Basic as well.
    >>>>
    >>>> His changes are get rid off Basic things not only from Jewel, but also
    >>>> from
    >>>> HTML which makes Jewel clear - Am I right Carlos?
    >>>>
    >>>> If yes - what does that mean that such controller like
    >>>> ItemRendererMouseController is in HTML?
    >>>>
    >>>> Is it mean that it does use only HTML module thing not Basic at all?
It
    >>>> is
    >>>> JS only controller?
    >>>>
    >>>> Piotr
    >>>>
    >>>> On Sun, May 6, 2018, 10:02 AM Harbs <harbs.lists@gmail.com> wrote:
    >>>>
    >>>> > Actually my whole app is broken now… :-(
    >>>> >
    >>>> > > On May 6, 2018, at 10:14 AM, Harbs <harbs.lists@gmail.com>
wrote:
    >>>> > >
    >>>> > > org.apache.royale.html.beads.controllers.ItemRendererMouseController
    >>>> was
    >>>> > changed to the core package as well (which also broke my app)
    >>>> > >
    >>>> > > I did not notice discussion about this. Why the package name
    >>>> change? How
    >>>> > many more changes were there like this?
    >>>> > >
    >>>> > > Harbs
    >>>> > >
    >>>> > >> On May 6, 2018, at 10:07 AM, Harbs <harbs.lists@gmail.com>
wrote:
    >>>> > >>
    >>>> > >> Why did Container become org.apache.royale.core.Container
instead
    >>>> of
    >>>> > org.apache.royale.html.Container?
    >>>> > >>
    >>>> > >> Why is Container Core at all?
    >>>> > >>
    >>>> > >> This change broke my app. While it’s not a big deal to
fix it, I
    >>>> don’t
    >>>> > understand why the change. Unless we decide on a wholesale change
of
    >>>> > components, this seems like a gratuitous breaking change for no
good
    >>>> reason.
    >>>> > >>
    >>>> > >> Harbs
    >>>> > >
    >>>> >
    >>>> >
    >>>>
    >>>
    >>>
    >>>
    >>> --
    >>> Carlos Rovira
    >>> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7Ce40f3ba553f14920812308d5b376bf3d%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636612244963192035&sdata=nSssLK0o7uOVNnfJiNiIeMc9JLEVNPBq%2ByYAcle3ROc%3D&reserved=0
    >>>
    >>>
    >>
    >>
    >> --
    >> Carlos Rovira
    >> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7Ce40f3ba553f14920812308d5b376bf3d%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636612244963192035&sdata=nSssLK0o7uOVNnfJiNiIeMc9JLEVNPBq%2ByYAcle3ROc%3D&reserved=0
    >>
    >>
    >
    >
    > --
    > Carlos Rovira
    > https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7Ce40f3ba553f14920812308d5b376bf3d%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636612244963192035&sdata=nSssLK0o7uOVNnfJiNiIeMc9JLEVNPBq%2ByYAcle3ROc%3D&reserved=0
    >
    >
    
    
    -- 
    Carlos Rovira
    https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7Ce40f3ba553f14920812308d5b376bf3d%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636612244963192035&sdata=nSssLK0o7uOVNnfJiNiIeMc9JLEVNPBq%2ByYAcle3ROc%3D&reserved=0
    

Mime
View raw message