royale-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Carlos Rovira <carlosrov...@apache.org>
Subject Re: two things: Clean components final HTML Output - Button basic styles still around
Date Tue, 06 Mar 2018 14:26:52 GMT
In fact, If I remove the styles in basic, I end with some visual changes in
JewelExample, like SVG strokes more thick in the buttons. Don't know
exactly why this is happening, but it's clear that styles from basic
component should be exactly 0, and then if people wants basic styles they
should use basic theme as a dependency.

I should have a 0 styles start so Jewel styles don't be affected by any
other inherit rule

2018-03-06 15:16 GMT+01:00 Carlos Rovira <carlosrovira@apache.org>:

> Hi,
>
> I want to share some things that affect my work on Jewel UI set and thing
> we should fix:
>
> 1.- Get rid of "style" configurations
>
> For example, I'm getting this output for some buttons
>
> <button type="button" class="TextButton" style="margin: 0px; display:
> block;">Some</button>
>
> <button type="button" class="TextButton" style="margin: 10px 0px 0px;
> display: block;">Button</button>
>
> I think display: block; should be part of the basic.css
>
> In the case of margins, I think this come from the
>
> <js:VerticalLayoutWithPaddingAndGap gap="10"/>
>
> In this case, I think would be better to affect some CSS to left the HTML
> as clean as possible
>
> For me the output should be:
>
> <button type="button" class="TextButton">Some Label</button>
>
>
> 2.- When Alex did changes to basic css and remove "*" I check that
> textfield was behaving correctly, but I think button is getting some styles
> that shouldn't be in my app
>
>
> Button {
>         border: 1px solid #808080;
>         padding: 4px;
>         background-color: #f8f8f8;
>         margin: 0px;
>         border-radius: 2px;
> }
>
>
> Button:hover {
>         border: 1px solid #808080;
>         padding: 4px;
>         background-color: #e8e8e8;
> }
>
>
> Button:active {
>         border: 1px solid #808080;
>         padding: 4px;
>         background-color: #d8d8d8;
> }
>
> Why this styles are still there? can I remove them or put in other place?
>
>
> --
> Carlos Rovira
> http://about.me/carlosrovira
>
>


-- 
Carlos Rovira
http://about.me/carlosrovira

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message