royale-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Harui <aha...@adobe.com.INVALID>
Subject Re: How to get assets (svg, png,...) inside *-js.swc and *-swf.swc libraries
Date Sat, 24 Feb 2018 23:12:22 GMT
It is true that copying assets is not normally the job of the compiler,
but ignoring SWF output for now, the JS compiler certainly copies lots of
files around.

It should be simple to have the JS compiler copy EVERY asset out of EVERY
theme swc.  Harder would be figuring out exactly which assets were needed
by reading the final CSS file.

Any objections to copying EVERY file out of the assets folder?

-Alex

On 2/24/18, 12:44 PM, "carlos.rovira@gmail.com on behalf of Carlos Rovira"
<carlos.rovira@gmail.com on behalf of carlosrovira@apache.org> wrote:

>Hi Gabe,
>
>since we're talking about a theme feature, it will be very strange that
>the
>implementation of that feature will left things unfinished. I think in
>this
>case is part of the compiler responsibility to provide to the final app
>with the assets the theme needs for its use. I'm talking from a conceptual
>point of view. In the end, users will not understand that the theme only
>manage CSS files.
>
>or at least that's how I understand it.
>
>Carlos
>
>
>
>2018-02-24 21:07 GMT+01:00 Gabe Harbs <harbs.lists@gmail.com>:
>
>> Copying is generally not done by the compiler itself. It’s usually
>>handled
>> by a compiler script or tooling.
>>
>> > On Feb 24, 2018, at 8:53 PM, Carlos Rovira <carlosrovira@apache.org>
>> wrote:
>> >
>> > Hi Alex,
>> >
>> > now the SWCs has all files needed, but when compile VividExample, the
>> > assets are not copied to VividExample target folder.
>> > How this is done?
>> >
>> > Thanks
>> >
>> > Carlos
>> >
>> >
>> >
>> > 2018-02-24 19:48 GMT+01:00 Carlos Rovira
>><carlos.rovira@codeoscopic.com
>> <mailto:carlos.rovira@codeoscopic.com>>:
>> >
>> >> I get it with:
>> >>
>> >> <include-file>
>> >> <name>assets/*</name>
>> >> <path>../src/main/resources/assets/*</path>
>> >> </include-file>
>> >>
>> >> Thanks!
>> >>
>> >> Carlos
>> >>
>> >>
>> >>
>> >> 2018-02-24 19:28 GMT+01:00 Alex Harui <aharui@adobe.com.invalid>:
>> >>
>> >>> I think any assets need to be listed in the <include-files> in
the
>> pom.xml
>> >>> (and for Ant, the src/main/config/compile*.xml files).
>> >>> AFAIK, there is no automatic including.  I believe you can use
>> wildcards
>> >>> in the <include-files>.
>> >>>
>> >>> -Alex
>> >>>
>> >>> On 2/24/18, 9:35 AM, "carlos.rovira@gmail.com on behalf of Carlos
>> Rovira"
>> >>> <carlos.rovira@gmail.com on behalf of carlosrovira@apache.org>
>>wrote:
>> >>>
>> >>>> Hi,
>> >>>>
>> >>>> the final "environment" problem I've is that SVGs that I put in
>> >>>> src/main/resources/assets are not in
>> >>>> final VividBlueTheme-0.9.2-SNAPSHOT-js.swc
>> >>>>
>> >>>> I see it copied to target/classes as usual in maven build, but are
>>not
>> >>>> part
>> >>>> of the theme swc file.
>> >>>>
>> >>>> it's something missing in the theme implementation? or maybe
>> something I
>> >>>> need to setup in pom.xml?
>> >>>>
>> >>>>
>> >>>> thanks
>> >>>>
>> >>>> --
>> >>>> Carlos Rovira
>> >>>> https://na01.safelinks.protection.outlook.com/?url=http%3A%
>> >>> 2F%2Fabout.me%2
>> >>>> Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7C973b4725a
>> >>> eaf4542d16308d5
>> >>>> 7bacfdd8%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C63655
>> >>> 0905283794125&s
>> >>>> 
>>data=GeImt6g%2FONQJO8aKdkb%2BR8LgspIJ4jimlwrweM%2BCV8M%3D&reserved=0
>> >>>
>> >>>
>> >>
>> >>
>> >> --
>> >>
>> >> 
>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.code
>>oscopic.com&data=02%7C01%7Caharui%40adobe.com%7Ccfc781eb803e4e6e379908d57
>>bc76d85%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636551018854655510&s
>>data=UcSVQjR2NGihdeCRBzYyn0yL2QzPnMmDbeNh%2FIQ2Cd8%3D&reserved=0>
>> >>
>> >> Carlos Rovira
>> >>
>> >> Director General
>> >>
>> >> M: +34 607 22 60 05 <607%2022%2060%2005>
>> >>
>> >> 
>>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.codeo
>>scopic.com&data=02%7C01%7Caharui%40adobe.com%7Ccfc781eb803e4e6e379908d57b
>>c76d85%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636551018854655510&sd
>>ata=UcSVQjR2NGihdeCRBzYyn0yL2QzPnMmDbeNh%2FIQ2Cd8%3D&reserved=0
>> >>
>> >>
>> >> Conócenos en 1 minuto!
>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Favant2.
>>es%2F%23video&data=02%7C01%7Caharui%40adobe.com%7Ccfc781eb803e4e6e379908d
>>57bc76d85%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636551018854655510
>>&sdata=fMcxQzFpFfEkjVvLkysxHKBDiEj8QJkwFaY%2F2Z%2BelDg%3D&reserved=0>
>> >>
>> >>
>> >> Este mensaje se dirige exclusivamente a su destinatario y puede
>>contener
>> >> información privilegiada o confidencial. Si ha recibido este mensaje
>>por
>> >> error, le rogamos que nos lo comunique inmediatamente por esta misma
>> vía y
>> >> proceda a su destrucción.
>> >>
>> >> De la vigente Ley Orgánica de Protección de Datos (15/1999), le
>> >> comunicamos que sus datos forman parte de un fichero cuyo
>>responsable es
>> >> CODEOSCOPIC S.A. La finalidad de dicho tratamiento es facilitar la
>> >> prestación del servicio o información solicitados, teniendo usted
>> derecho
>> >> de acceso, rectificación, cancelación y oposición de sus datos
>> dirigiéndose
>> >> a nuestras oficinas c/ Paseo de la Habana 9-11, 28036, Madrid con la
>> >> documentación necesaria.
>> >>
>> >>
>> >
>> >
>> > --
>> > Carlos Rovira
>> > 
>>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%
>>2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7Ccfc781eb803e4e6e379908
>>d57bc76d85%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C63655101885465551
>>0&sdata=FH63GlfMgFzaIZA4jTKSCaW3RkZg75CAL1Qeac3EmWY%3D&reserved=0
>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me
>>%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7Ccfc781eb803e4e6e37990
>>8d57bc76d85%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C6365510188546555
>>10&sdata=FH63GlfMgFzaIZA4jTKSCaW3RkZg75CAL1Qeac3EmWY%3D&reserved=0>
>>
>
>
>
>-- 
>Carlos Rovira
>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2
>Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7Ccfc781eb803e4e6e379908d5
>7bc76d85%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636551018854655510&s
>data=FH63GlfMgFzaIZA4jTKSCaW3RkZg75CAL1Qeac3EmWY%3D&reserved=0

Mime
View raw message