royale-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Peter Ent <p...@adobe.com.INVALID>
Subject Re: [Royale] ICollectionView
Date Tue, 16 Jan 2018 21:19:34 GMT
Now that I've checked in TreeGrid and my changes to DataGrid (not much) I
can look into this with you.

I created an interface, IDataGridColumn so that TreeGrid and DataGrid can
share a lot of the same code, although the two are separate at the moment.
I want TreeGrid to be able to use most of the same beads DataGrid does or
will have available to it in the future. The styling should be the same,
too.

‹peter

On 1/12/18, 6:35 PM, "piotrz" <piotrz@apache.org> wrote:

>Peter,
>
>I see one more issue. In DataGridColumnList we have following line:
>"typeNames = "DataGridColumnList";". After compilation each div which
>represents DataGridColumnList have class="List".
>
><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapache-ro
>yale-development.20373.n8.nabble.com%2Ffile%2Ft1%2Flist_each_datagridcolum
>nlist.png&data=02%7C01%7Cpent%40adobe.com%7Ca95e03b494894e2bf8ba08d55a1536
>ef%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636513969542441416&sdata=j
>avj1cU%2BeNSJvY%2FwHzRtOQDDCGJKSNEUP2QCWWWZpug%3D&reserved=0>
>
>This gives us some borders because default List style has css which is
>doing
>for us border etc. [1]
>
><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapache-ro
>yale-development.20373.n8.nabble.com%2Ffile%2Ft1%2Fborder_grid.png&data=02
>%7C01%7Cpent%40adobe.com%7Ca95e03b494894e2bf8ba08d55a1536ef%7Cfa7b1b5a7b34
>438794aed2c178decee1%7C0%7C0%7C636513969542441416&sdata=D%2BVI5eYn%2FTXqG1
>DDvfS5GSfGctc0JptwQZ%2BHNG1hT3s%3D&reserved=0>
>
>However if I add to the column some style as we are doing it in
>DataGridExample for as second grid, we are ending up with something weird:
>
><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapache-ro
>yale-development.20373.n8.nabble.com%2Ffile%2Ft1%2Fno_border_grid.png&data
>=02%7C01%7Cpent%40adobe.com%7Ca95e03b494894e2bf8ba08d55a1536ef%7Cfa7b1b5a7
>b34438794aed2c178decee1%7C0%7C0%7C636513969542441416&sdata=nxtvREgcMz6kgZ0
>wwZV5bmUbkhvAuckEnUETYmFpgrs%3D&reserved=0>
>
>There is no border, cause DataGridColumnList style doesn't have it [2].
>
>I think we should:
>1) Set className = "DataGridColumnList" - here [3]
>2) Add those border to class "DataGridColumnList" in css
>
>What do you think ?
>
>[1] 
>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgoo.gl%2F
>n27aYN&data=02%7C01%7Cpent%40adobe.com%7Ca95e03b494894e2bf8ba08d55a1536ef%
>7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636513969542441416&sdata=rOBo
>byCAc2i92Vmlu0eniYIkCaEtWRA%2BTox08IMOFhQ%3D&reserved=0
>[2] 
>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgoo.gl%2F
>N4S9PK&data=02%7C01%7Cpent%40adobe.com%7Ca95e03b494894e2bf8ba08d55a1536ef%
>7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636513969542441416&sdata=dQ0p
>WvYbK4Yn0RNJOKhZkKLbJzF4T54%2BSikI7bes1%2Bw%3D&reserved=0
>[3] 
>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgoo.gl%2F
>8mF2Lr&data=02%7C01%7Cpent%40adobe.com%7Ca95e03b494894e2bf8ba08d55a1536ef%
>7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636513969542441416&sdata=mPbe
>gCAynPs5olJlaFDMFew5Bfb5mkP6lYIplrrqMd0%3D&reserved=0
>
>Thanks,
>Piotr
>
>
>
>--
>Sent from: 
>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapache-roy
>ale-development.20373.n8.nabble.com%2F&data=02%7C01%7Cpent%40adobe.com%7Ca
>95e03b494894e2bf8ba08d55a1536ef%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0
>%7C636513969542441416&sdata=aLSGgQj1G%2F24n9AS97pDZgY59%2FycIbacHt0xUtKnCz
>c%3D&reserved=0


Mime
View raw message