royale-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Harui <aha...@adobe.com.INVALID>
Subject Re: Code style guidelines
Date Tue, 19 Dec 2017 21:21:37 GMT
IMO, folks editing AS and Java should set tabs to 4.  It would be great if
all tools replaced tabs with 4 spaces for AS and Java (and maybe MXML),
but I generally consider how hard it would be to follow changes into
history if a lot of changes are made to whitespaces or braces before
deciding whether to clean it up or not.

HTML, JS and XML (and thus MXML) can have two space indents.  IMO, not a
big deal if it has 4 space indents.  It is a bit more important to oust
tabs from 2-space indented files, but again, consider following history
before cleaning up.

I like curly on the next line, and none for one-line clauses, but again I
generally don't clean it up when folks do something else.  If it bugs you,
again, consider history before cleaning.

I wish we could get to zero warnings, especially in the compiler, but
maybe that is a different topic.  If someone really wants to do a full
sweep of the code bases I will not object too strongly.  We don't hit
history too often right now and have moved plenty of stuff around but I
think we have bigger fish to fry and don't really want to stop and fix new
contribution from editors that aren't conforming.

My 2 cents,
-Alex

On 12/19/17, 12:52 PM, "Piotr Zarzycki" <piotrzarzycki21@gmail.com> wrote:

>I don't care either about Spaces, Tabs, but I do care about curly brackets
>and I'm using it exactly same as Harbs describe. I know that in Java more
>often people tend to started by curly brackets in the same line, not next.
>
>Thanks, Piotr
>
>2017-12-19 21:45 GMT+01:00 Harbs <harbs.lists@gmail.com>:
>
>> I think the practice for curly braces is that they are on the next line
>> and are only used if there’s more than one line of code.
>>
>> Spaces vs tabs: There’s no consistency on that, and I really don’t care
>>to
>> invest any energy in it. Either four spaces or a tab. All the same to
>>me.
>>
>> Do folks care about this?
>>
>> Harbs
>>
>> > On Dec 19, 2017, at 9:40 PM, Olaf Krueger <mail@olafkrueger.net>
>>wrote:
>> >
>> > Erik de Bruin wrote
>> >> Since there will now be at least 2 folks working in the compiler
>> projects,
>> >> maybe it's time to agree on some code style guidelines?l
>> >
>> > Doesn't it make sense to basically follow some coding guidelines for
>>all
>> the
>> > Royale stuff?
>> > Or is the style depending on the particular programming language?
>> >
>> > Olaf
>> >
>> >
>> >
>> >
>> > --
>> > Sent from: 
>>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapache-ro
>>yale-development.20373.n8.nabble.com%2F&data=02%7C01%7Caharui%40adobe.com
>>%7C191b50127a7949b32ab608d5472275ed%7Cfa7b1b5a7b34438794aed2c178decee1%7C
>>0%7C0%7C636493135690286889&sdata=msI5CyJDdPNTlJzTEP4gW65aLbiopcbUXSdL2mrd
>>aAY%3D&reserved=0
>>
>>
>
>
>-- 
>
>Piotr Zarzycki
>
>Patreon: 
>*https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patr
>eon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7C191b50127a7949
>b32ab608d5472275ed%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C6364931356
>90286889&sdata=FptRcV8Gie4f95GQmQ%2BboAgGNERA2aNG07lAj%2BayFJs%3D&reserved
>=0
><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patr
>eon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7C191b50127a7949
>b32ab608d5472275ed%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C6364931356
>90286889&sdata=FptRcV8Gie4f95GQmQ%2BboAgGNERA2aNG07lAj%2BayFJs%3D&reserved
>=0>*

Mime
View raw message