royale-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Harui <aha...@adobe.com.INVALID>
Subject Re: Duplicated TextNode in HTML module
Date Tue, 19 Dec 2017 03:30:31 GMT
Flash Builder does not seem to be showing duplicates.

At minimum, it can just sort all of the classes it finds and toss out
duplicates.

The way the compiler deals with duplicates is by using the compile time
stamp in the catalog.xml and always let source-path entries win over
library-path entries.

HTH,
-Alex

On 12/18/17, 2:52 PM, "Piotr Zarzycki" <piotrzarzycki21@gmail.com> wrote:

>Alex,
>
>Flash Builder has such tolerance ? Do you have any knowledge how that IDE
>handles such thing ? I will spend some time to setup Intellij and see how
>am I seeing this thing there.
>
>I completely agree with you that we have big fish to fry - This is exactly
>one of them. It affects two IDEs which widely supports that framework. We
>can always bump into library which will provide us such duplication in the
>real world applications, but why it need to be Royale...
>
>I have very little knowledge about language server from Josh, although I'm
>following each change which is being committed there, that is why I'm not
>sure whether this "tolerance" is easy to achieve.
>
>Thanks, Piotr
>
>
>2017-12-18 23:35 GMT+01:00 Alex Harui <aharui@adobe.com.invalid>:
>
>> I think Josh correctly analyzed that the JS SWCs have duplicate entries.
>>
>> As Harbs says, the compiler doesn't have an easy way to distinguish
>> between external definitions that don't need goog.require and ones that
>> do, so we currently have duplicate entries by putting upstream SWCs on
>>the
>> library-path in order to generate the correct goog.requires.
>>
>> There may be a way to use existing compiler options to keep duplicate
>> entries out of the SWCs, but realize that the compiler is has always
>>been
>> tolerant of duplicate entries.  IMO, the code completion system should
>>be
>> tolerant of duplicate entries as it doesn't seem reasonable to not allow
>> them on the library path.  Folks may someday want to create aggregate
>>SWCs
>> and that will increase the chance that the app dev will find duplicate
>> entries on the library-path.
>>
>> IMO, monkey-patching might also cause duplicate entries to be found as
>> well as a definition on the source-path will try to override the
>> definition on the library-path.
>>
>> Thus, I think the code completion system needs to be tolerant of
>>duplicate
>> entries and we should not be changing the SWCs right now. I think there
>> are much bigger fish to fry than trying to remove duplicate entries from
>> the SWCs.
>>
>> My 2 cents,
>> -Alex
>>
>>
>> On 12/18/17, 2:15 PM, "Harbs" <harbs.lists@gmail.com> wrote:
>>
>> >I think the problem is a bit deeper.
>> >
>> >Using external-library-path is not going to work for js compiles
>>because
>> >it needs to link the includes when compiling to JS.
>> >
>> >catalog.xml needs to be generates sans the dependency classes though (I
>> >think). I’m not sure the right way to go about that. For most classes,
>>it
>> >could be copied from the SWF output, but that’s not going to work for
>>any
>> >JS-only classes.
>> >
>> >Harbs
>> >
>> >> On Dec 18, 2017, at 10:22 PM, Piotr Zarzycki
>> >><piotrzarzycki21@gmail.com> wrote:
>> >>
>> >> Hi Guys,
>> >>
>> >> It  look like those duplication that is something on the Royale. Josh
>> >>took
>> >> a look into the problem [1]. Should we change compile-js-config.xml
>>or
>> >>it
>> >> is something which we need to look deeper somewhere ?
>> >>
>> >> [1]
>> >>
>> >>https://na01.safelinks.protection.outlook.com/?url=
>> https%3A%2F%2Fgithub.c
>> >>om%2Fprominic%2FMoonshine-IDE%2Fissues%2F87%
>> 23issuecomment-352525906&data
>> >>=02%7C01%7Caharui%40adobe.com%7Cfc0c6a1ce36f4839a8e208d54664
>> ecf2%7Cfa7b1b
>> >>5a7b34438794aed2c178decee1%7C0%7C0%7C636492321639637240&
>> sdata=y4dyN4rICjw
>> >>Bp%2FYN9PUzqxQPjsb04%2B1DPwpivX%2FoWQw%3D&reserved=0
>> >>
>> >> Thanks, Piotr
>> >>
>> >>
>> >> 2017-12-18 11:17 GMT+01:00 Piotr Zarzycki
>><piotrzarzycki21@gmail.com>:
>> >>
>> >>> Hi Alex,
>> >>>
>> >>> Thanks for the information. I'm still not sure where the bug is. It
>>is
>> >>>for
>> >>> sure not in the Moonshine code - I have checked it and Harbs
>>confirmed
>> >>>that
>> >>> he is seeing the same in VSCode. I don't have such problems with
>>Flex
>> >>>SDK.
>> >>>
>> >>> Thanks, Piotr
>> >>>
>> >>>
>> >>>
>> >>> 2017-12-18 6:39 GMT+01:00 Alex Harui <aharui@adobe.com.invalid>:
>> >>>
>> >>>> In FB, ContainerBase only shows up once in AS code completion and
>>not
>> >>>>in
>> >>>> MXML (since it isn't in a manifest).
>> >>>>
>> >>>> HTH,
>> >>>> -Alex
>> >>>>
>> >>>> On 12/16/17, 9:56 AM, "Piotr Zarzycki" <piotrzarzycki21@gmail.com>
>> >>>>wrote:
>> >>>>
>> >>>>> Anyone who use Flash Builder seeing also duplication ?
>> >>>>>
>> >>>>> Thanks, Piotr
>> >>>>>
>> >>>>> 2017-12-16 18:47 GMT+01:00 Piotr Zarzycki
>> >>>>><piotrzarzycki21@gmail.com>:
>> >>>>>
>> >>>>>> I see the same in Moonshine. Do you think that is problem
in
>> >>>>>>extension
>> >>>>>> or
>> >>>>>> somewhere in our code ? I was digging into the modules but
didn't
>> >>>>>>found
>> >>>>>> anything. I have checked also for Jsonly package what actually
>>is in
>> >>>>>> swcs,
>> >>>>>> but also no clue what is happen.
>> >>>>>>
>> >>>>>> Piotr
>> >>>>>>
>> >>>>>>
>> >>>>>> 2017-12-16 18:42 GMT+01:00 Harbs <harbs.lists@gmail.com>:
>> >>>>>>
>> >>>>>>> Yes. I see duplication. In some places many times. For
example,
>> >>>>>>> ContainerBase shows up 9 times.
>> >>>>>>>
>> >>>>>>>> On Dec 16, 2017, at 7:37 PM, Piotr Zarzycki
>> >>>>>>> <piotrzarzycki21@gmail.com>
>> >>>>>>> wrote:
>> >>>>>>>>
>> >>>>>>>> Ok Thanks.
>> >>>>>>>>
>> >>>>>>>> Another question - Do you see in VSCode duplicate
definition in
>> >>>>>>>>code
>> >>>>>>>> completion for example Accordion ?
>> >>>>>>>>
>> >>>>>>>> Thanks, Piotr
>> >>>>>>>>
>> >>>>>>>>
>> >>>>>>>> 2017-12-16 18:26 GMT+01:00 Harbs <harbs.lists@gmail.com>:
>> >>>>>>>>
>> >>>>>>>>> It was on purpose. That lets you use TextNode
and InnerHTML
>>using
>> >>>>>>> both
>> >>>>>>> the
>> >>>>>>>>> basic and the html namespaces. Those are likely
to be used
>>with
>> >>>>>>> Basic
>> >>>>>>>>> components in addition to HTML ones.
>> >>>>>>>>>
>> >>>>>>>>>> On Dec 16, 2017, at 6:58 PM, Piotr Zarzycki
<
>> >>>>>>> piotrzarzycki21@gmail.com>
>> >>>>>>>>> wrote:
>> >>>>>>>>>>
>> >>>>>>>>>> Hi Harbs,
>> >>>>>>>>>>
>> >>>>>>>>>> I'm investigating some issue in Moonshine
with Royale and I
>>have
>> >>>>>>> noticed
>> >>>>>>>>>> that after your changes in HTML module component
TextNode and
>> >>>>>>> InnerHTML
>> >>>>>>>>> is
>> >>>>>>>>>> in "html-manifest.xml" and in "basic-manifest.xml"
of that
>> >>>>>>>>>>module.
>> >>>>>>>>>>
>> >>>>>>>>>> Is it for purpose or simply mistake ?
>> >>>>>>>>>>
>> >>>>>>>>>> Thanks,
>> >>>>>>>>>> --
>> >>>>>>>>>>
>> >>>>>>>>>> Piotr Zarzycki
>> >>>>>>>>>>
>> >>>>>>>>>> Patreon:
>> >>>>>>> *https://na01.safelinks.protection.outlook.com/?url=https
>> >>>> %3A%2F%2Fwww.pa
>> >>>>>>> treon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com
>> >>>> %7C7c49358ec5
>> >>>>>>> 864659628b08d544ae4c9d%7Cfa7b1b5a7b34438794aed2c178decee1
>> >>>> %7C0%7C0%7C6364
>> >>>>>>> 90437757714963&sdata=MoKWBh9XTEh714TRb1lFVmaoCsfyOh645BH0
>> >>>> GJSn0rI%3D&rese
>> >>>>>>> rved=0
>> >>>>>>>>>>
>> >>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https
>> >>>> %3A%2F%2Fwww.pa
>> >>>>>>> treon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com
>> >>>> %7C7c49358ec5
>> >>>>>>> 864659628b08d544ae4c9d%7Cfa7b1b5a7b34438794aed2c178decee1
>> >>>> %7C0%7C0%7C6364
>> >>>>>>> 90437757714963&sdata=MoKWBh9XTEh714TRb1lFVmaoCsfyOh645BH0
>> >>>> GJSn0rI%3D&rese
>> >>>>>>> rved=0>*
>> >>>>>>>>>
>> >>>>>>>>>
>> >>>>>>>>
>> >>>>>>>>
>> >>>>>>>> --
>> >>>>>>>>
>> >>>>>>>> Piotr Zarzycki
>> >>>>>>>>
>> >>>>>>>> Patreon:
>> >>>>>>> *https://na01.safelinks.protection.outlook.com/?url=https
>> >>>> %3A%2F%2Fwww.pa
>> >>>>>>> treon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com
>> >>>> %7C7c49358ec5
>> >>>>>>> 864659628b08d544ae4c9d%7Cfa7b1b5a7b34438794aed2c178decee1
>> >>>> %7C0%7C0%7C6364
>> >>>>>>> 90437757714963&sdata=MoKWBh9XTEh714TRb1lFVmaoCsfyOh645BH0
>> >>>> GJSn0rI%3D&rese
>> >>>>>>> rved=0
>> >>>>>>>>
>> >>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https
>> >>>> %3A%2F%2Fwww.pa
>> >>>>>>> treon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com
>> >>>> %7C7c49358ec5
>> >>>>>>> 864659628b08d544ae4c9d%7Cfa7b1b5a7b34438794aed2c178decee1
>> >>>> %7C0%7C0%7C6364
>> >>>>>>> 90437757714963&sdata=MoKWBh9XTEh714TRb1lFVmaoCsfyOh645BH0
>> >>>> GJSn0rI%3D&rese
>> >>>>>>> rved=0>*
>> >>>>>>>
>> >>>>>>>
>> >>>>>>
>> >>>>>>
>> >>>>>> --
>> >>>>>>
>> >>>>>> Piotr Zarzycki
>> >>>>>>
>> >>>>>> Patreon:
>> >>>>>> *https://na01.safelinks.protection.outlook.com/?url=https%
>> >>>> 3A%2F%2Fwww.pat
>> >>>>>> reon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com
>> >>>> %7C7c49358ec586
>> >>>>>> 4659628b08d544ae4c9d%7Cfa7b1b5a7b34438794aed2c178decee1%
>> >>>> 7C0%7C0%7C6364904
>> >>>>>> 37757714963&sdata=MoKWBh9XTEh714TRb1lFVmaoCsfyOh645BH0GJSn
>> >>>> 0rI%3D&reserved
>> >>>>>> =0
>> >>>>>>
>> >>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%
>> >>>> 3A%2F%2Fwww.pat
>> >>>>>> reon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com
>> >>>> %7C7c49358ec586
>> >>>>>> 4659628b08d544ae4c9d%7Cfa7b1b5a7b34438794aed2c178decee1%
>> >>>> 7C0%7C0%7C6364904
>> >>>>>> 37757714963&sdata=MoKWBh9XTEh714TRb1lFVmaoCsfyOh645BH0GJSn
>> >>>> 0rI%3D&reserved
>> >>>>>> =0>*
>> >>>>>>
>> >>>>>
>> >>>>>
>> >>>>>
>> >>>>> --
>> >>>>>
>> >>>>> Piotr Zarzycki
>> >>>>>
>> >>>>> Patreon:
>> >>>>> *https://na01.safelinks.protection.outlook.com/?url=https%
>> >>>> 3A%2F%2Fwww.patr
>> >>>>> eon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7
>> >>>> C7c49358ec58646
>> >>>>> 59628b08d544ae4c9d%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%
>> >>>> 7C0%7C6364904377
>> >>>>>
>> >>>>>57714963&sdata=MoKWBh9XTEh714TRb1lFVmaoCsfyOh
>> 645BH0GJSn0rI%3D&reserved
>> >>>>>=0
>> >>>>> <https://na01.safelinks.protection.outlook.com/?url=https%
>> >>>> 3A%2F%2Fwww.patr
>> >>>>> eon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7
>> >>>> C7c49358ec58646
>> >>>>> 59628b08d544ae4c9d%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%
>> >>>> 7C0%7C6364904377
>> >>>>> 57714963&sdata=MoKWBh9XTEh714TRb1lFVmaoCsfyOh645BH0GJSn0rI%
>> >>>> 3D&reserved=0>*
>> >>>>
>> >>>>
>> >>>
>> >>>
>> >>> --
>> >>>
>> >>> Piotr Zarzycki
>> >>>
>> >>> Patreon:
>> >>>*https://na01.safelinks.protection.outlook.com/?url=
>> https%3A%2F%2Fwww.pa
>> >>>treon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com
>> %7Cfc0c6a1ce3
>> >>>6f4839a8e208d54664ecf2%7Cfa7b1b5a7b34438794aed2c178de
>> cee1%7C0%7C0%7C6364
>> >>>92321639637240&sdata=LCilka5hakK%2Bx5Qw0iysqfmvAoRjfZQfwDgAXOSv
>> kfU%3D&re
>> >>>served=0
>> >>>
>> >>><https://na01.safelinks.protection.outlook.com/?url=
>> https%3A%2F%2Fwww.pa
>> >>>treon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com
>> %7Cfc0c6a1ce3
>> >>>6f4839a8e208d54664ecf2%7Cfa7b1b5a7b34438794aed2c178de
>> cee1%7C0%7C0%7C6364
>> >>>92321639637240&sdata=LCilka5hakK%2Bx5Qw0iysqfmvAoRjfZQfwDgAXOSv
>> kfU%3D&re
>> >>>served=0>*
>> >>>
>> >>
>> >>
>> >>
>> >> --
>> >>
>> >> Piotr Zarzycki
>> >>
>> >> Patreon:
>> >>*https://na01.safelinks.protection.outlook.com/?url=
>> https%3A%2F%2Fwww.pat
>> >>reon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com
>> %7Cfc0c6a1ce36f
>> >>4839a8e208d54664ecf2%7Cfa7b1b5a7b34438794aed2c178de
>> cee1%7C0%7C0%7C6364923
>> >>21639637240&sdata=LCilka5hakK%2Bx5Qw0iysqfmvAoRjfZQfwDgAXOSv
>> kfU%3D&reserv
>> >>ed=0
>> >>
>> >><https://na01.safelinks.protection.outlook.com/?url=
>> https%3A%2F%2Fwww.pat
>> >>reon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com
>> %7Cfc0c6a1ce36f
>> >>4839a8e208d54664ecf2%7Cfa7b1b5a7b34438794aed2c178de
>> cee1%7C0%7C0%7C6364923
>> >>21639637240&sdata=LCilka5hakK%2Bx5Qw0iysqfmvAoRjfZQfwDgAXOSv
>> kfU%3D&reserv
>> >>ed=0>*
>> >
>>
>>
>
>
>-- 
>
>Piotr Zarzycki
>
>Patreon: 
>*https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patr
>eon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7C622929b31b0c4c
>7d44ce08d5466a1366%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C6364923438
>06258624&sdata=4GoIispeI5ShL8TSuqPptcX%2FQaLGblD0r2pDtSXSwQk%3D&reserved=0
><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patr
>eon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7C622929b31b0c4c
>7d44ce08d5466a1366%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C6364923438
>06258624&sdata=4GoIispeI5ShL8TSuqPptcX%2FQaLGblD0r2pDtSXSwQk%3D&reserved=0
>>*

Mime
View raw message