royale-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Peter Ent <p...@adobe.com.INVALID>
Subject Re: Slider Component
Date Tue, 12 Dec 2017 21:46:16 GMT
If you set the slider's width and height explicitly, the layout should
work fine. Found two issues:

The SliderMouseController is oriented toward a horizontal slider. I will
create a HorizontalSliderMouseController and a
VerticalSLiderMouseController.

Second, on the HTML/JS side, the slider controller is supposed to receive
a BrowserEvent, but is actually receiving a "native" (I think) MouseEvent.
This event's properties do not provide actual local x & y (or client x &
y) values which is throwing the mouse tracking off. It looks like there is
an override in HTMLElementWrapper that is discarding the BrowserEvent and
sending a native event instead.

—peter

On 12/12/17, 3:53 PM, "Peter Ent" <pent@adobe.com.INVALID> wrote:

>Hi Carlos,
>
>I've pushed some changes to Slider. I created HorizontalSliderLayout to
>size and position the components of the Slider. I also fixed the layout on
>the HTML/JS side by adding some style commands in defaults.css.
>
>There are a couple of issues, but you should be able to make some
>progress.
>
>The tracking of the Slider thumb on HTML/JS is very jittery and not always
>accurate. I'm not sure why so I will be looking into that next. I also
>created a VerticalSliderLayout, but that doesn't work at all; it may have
>something to do with the graphics for the track and maybe there needs to
>be a vertical track.
>
>So it is "better" and I'll continue to work on it.
>
>—peter
>
>On 12/12/17, 1:27 PM, "carlos.rovira@gmail.com on behalf of Carlos Rovira"
><carlos.rovira@gmail.com on behalf of carlosrovira@apache.org> wrote:
>
>>Thanks Peter,
>>
>>This is one of the components I want to stylize, so if you upgrade it, I
>>could as well work on the visuals ( and use it for the demo controls too)
>>
>>Carlos
>>
>>2017-12-12 16:35 GMT+01:00 Peter Ent <pent@adobe.com.invalid>:
>>
>>> I just saw this email. I'll be happy to look at it. I think it was made
>>> early in FlexJS. I imagine it could be crude. I'm also sure it is
>>> horizontal. I'll keep vertical in mind - maybe it needs different
>>>layouts
>>> to handle that.
>>>
>>> ‹peter
>>>
>>> On 12/12/17, 5:00 AM, "carlos.rovira@gmail.com on behalf of Carlos
>>>Rovira"
>>> <carlos.rovira@gmail.com on behalf of carlosrovira@apache.org> wrote:
>>>
>>> >Hi,
>>> >
>>> >I'm planning to start working soon in the theme feature and one thing
>>>I
>>> >was
>>> >trying to use is the Slider component (both for styling and for use to
>>> >control styling change in examples in real time)
>>> >
>>> >I found some weeks ago that the Slider component was not working as
>>> >expected, as I move the thumb it was doing very strange things
>>>(flickering
>>> >and jumping) and I think the layout is only horizontal but not
>>>vertical.
>>> >
>>> >I think Peter made this component and want to ask if he could review
>>>it to
>>> >see if something was broken and improve it in order to use it in this
>>> >styling effort
>>> >
>>> >Thanks
>>> >
>>> >--
>>> >Carlos Rovira
>>> >https://na01.safelinks.protection.outlook.com/?url=
>>> http%3A%2F%2Fabout.me%2
>>> >Fcarlosrovira&data=02%7C01%7Cpent%40adobe.com%
>>> 7Cb1bd73ec13ef4fb75c6408d541
>>> >4732ba%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%
>>> 7C636486696475000148&sda
>>> >ta=MDUaZWs7b8savnySNQ653fWLrdWLkkw%2FSKbY%2Bg00J38%3D&reserved=0
>>>
>>>
>>
>>
>>-- 
>>Carlos Rovira
>>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%
>>2
>>Fcarlosrovira&data=02%7C01%7Cpent%40adobe.com%7Cbc3147dc43414b511a6a08d54
>>1
>>8dfe47%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636487000472376988&sd
>>a
>>ta=Y%2BcJd6LoUXLPxTfL82s39hRQz74SSOZtLNcX3EVWPQc%3D&reserved=0
>

Mime
View raw message