royale-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Piotr Zarzycki <piotrzarzyck...@gmail.com>
Subject Re: Distinguish description in "royale-sdk-description.xml" between asjs and JSOnly
Date Sun, 31 Dec 2017 09:49:40 GMT
Harbs,

I'm sorry!! I thought that you would like to get rid off
flex-sdk-description ! Ok in that case I need to check what's I will have
to change in Moonshine, but that probably a minor things. :)

Thanks, Piotr

2017-12-31 10:28 GMT+01:00 Gabe Harbs <harbs.lists@gmail.com>:

> What’s the harm in having two files? One named flex-sdk-description for
> backwards compatibility and a second one named sdk-description for forward
> compatibility. The sooner we have a generic file, the sooner IDEs can start
> using it.
>
> Harbs
>
> > On Dec 31, 2017, at 11:03 AM, Piotr Zarzycki <piotrzarzycki21@gmail.com>
> wrote:
> >
> > Alex,
> >
> > I like this format and I can apply it. The question was whether condition
> > to determined targets are ok?
> >
> > Harbs,
> >
> > I'm against change the name of that file now. Maybe once we release 0.9.0
> > and IDEs integrate it.
> > Once we try Royale in Intellij which is still in play.
> > Jetbrains haven't claim as I thought that they won't support
> Royale/FlexJS.
> > Maybe some day they will.
> >
> > Than we can experiment what can happen with change the name.
> >
> > Piotr
> >
> > On Sun, Dec 31, 2017, 09:16 Gabe Harbs <harbs.lists@gmail.com <mailto:
> harbs.lists@gmail.com>> wrote:
> >
> >> To be clear, I understand that “flex-idk-decription” is needed for the
> >> current Flash Builder implementation, but I don’t think we should be
> held
> >> back by that forever, so I’m suggesting *adding* a name not specific to
> >> flex.
> >>
> >>> On Dec 31, 2017, at 9:41 AM, Gabe Harbs <harbs.lists@gmail.com> wrote:
> >>>
> >>> I added it. The reason I did was that was how I was able to get VS Code
> >> to recognize the SDK.
> >>>
> >>> I have no problem reworking the description file, but I do think we
> >> should drop the “flex” from the name.
> >>>
> >>> In fact, we can probably just make it sdk-description.xml and the root
> >> tag could be <sdk-description>
> >>>
> >>> Harbs
> >>>
> >>>> On Dec 31, 2017, at 9:13 AM, Alex Harui <aharui@adobe.com.INVALID
> >> <mailto:aharui@adobe.com.INVALID <mailto:aharui@adobe.com.INVALID>>>
> wrote:
> >>>>
> >>>> I didn't have anything to do with the creation of
> >> royale-sdk-description.
> >>>> It looks like someone copied the flex-sdk-description generation
> script.
> >>>> Is there any reason for that?
> >>>>
> >>>> IMO, parsing a string in an XML file to understand the SDK contents
> >>>> doesn’t make sense to me.  If the only current consumer of this file
> is
> >> VS
> >>>> Code and it is only using the presence of the file, now would be a
> good
> >>>> time to set the contents of royale-sdk-description in a way that is
> more
> >>>> future-proof.  Plus, the VS Code extension can probably be adjusted
if
> >>>> needed.
> >>>>
> >>>> I'd suggest something like:
> >>>>
> >>>> <!-- Description of Apache Royale SDK -->
> >>>> <royale-sdk-description>
> >>>> <product>Apache Royale</product>
> >>>> <version>0.8.0</version>
> >>>> <build>20171230</build>
> >>>> <output-targets>
> >>>>   <output-target name="js" version="Ecma5Strict" />
> >>>>   <output-target name="swf" version="AS3" AIR="25.0" Flash="25.0"
/>
> >>>> </output-targets>
> >>>> </royale-sdk-description>
> >>>>
> >>>> That way everything is an XML tag or attribute and no parsing is
> >> required.
> >>>> I'm regretting calling things "JSOnly".  I'd rather focus on what you
> >>>> have instead of what you don't have.
> >>>>
> >>>> Thoughts?
> >>>> -Alex
> >>>>
> >>>> On 12
> >>>>
> >>>>
> >>>>
> >>>> On 12/30/17, 3:33 AM, "Piotr Zarzycki" <piotrzarzycki21@gmail.com
> <mailto:piotrzarzycki21@gmail.com>
> >> <mailto:piotrzarzycki21@gmail.com <mailto:piotrzarzycki21@gmail.com>>>
> wrote:
> >>>>
> >>>>> Here is my thoughts about that, cause I don't want to break anything.
> >> In
> >>>>> ANT build royale-sdk-description is being created in target
> "prebuild"
> >> ->
> >>>>> "
> >>>>> create-description". I see following option:
> >>>>>
> >>>>> - Check whether we have environment variables set up:
> >>>>> env.PLAYERGLOBAL_HOME
> >>>>> OR env.AIR_HOME  if not make short description with "Apache Royale
> >> 0.9.0
> >>>>> en_US (JS)"
> >>>>>
> >>>>> What do you think ? Is it sufficient ?
> >>>>>
> >>>>> Thanks, Piotr
> >>>>>
> >>>>>
> >>>>> 2017-12-30 12:04 GMT+01:00 Piotr Zarzycki <piotrzarzycki21@gmail.com
> <mailto:piotrzarzycki21@gmail.com>
> >> <mailto:piotrzarzycki21@gmail.com <mailto:piotrzarzycki21@gmail.com>>>:
> >>>>>
> >>>>>> I think I have found where those files are generated. I will
think
> how
> >>>>>> to
> >>>>>> change them, but if someone have other thoughts let me know!
:)
> >>>>>>
> >>>>>> Thanks, Piotr
> >>>>>>
> >>>>>> 2017-12-30 11:59 GMT+01:00 piotrz <piotrz@apache.org <mailto:
> piotrz@apache.org> <mailto:
> >> piotrz@apache.org <mailto:piotrz@apache.org>>>:
> >>>>>>
> >>>>>>> Alex,
> >>>>>>>
> >>>>>>> Currently in Moonshine we are using flex-sdk-description,
but
> >> probably
> >>>>>>> after
> >>>>>>> first release of Royale we will use royale-sdk-description.
> >> Information
> >>>>>>> from
> >>>>>>> that file is being used to display name of the SDK.
> >>>>>>>
> >>>>>>>
> >>>>>>> <
> >> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapache-
> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapache->
> <
> >> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapache-
> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapache->>
> >>>>>>> royale-development.20373.n8.nabble.com <http://royale-development.
> 20373.n8.nabble.com/> <
> >> http://royale-development.20373.n8.nabble.com/ <
> http://royale-development.20373.n8.nabble.com/>
> >>> %2Ffile%2F&data=02%7C01%7Caharui%4
> >>>>>>> 0adobe.com <http://0adobe.com/> <http://0adobe.com/
<
> http://0adobe.com/>
> >>> %7C2a19eab2ec1f4efeea9b08d54f7923c0%7Cfa7b1b5a7b34438794aed2c1
> >>>>>>>
> >> 78decee1%7C0%7C0%7C636502304073200067&sdata=
> OrjKd30bpS9CjjBH0xl9t8VlHcN6
> >>>>>>> gaQQvhBwCdD%2Bjug%3D&reserved=0
> >>>>>>> t1/royale_sdk_description.png>
> >>>>>>>
> >>>>>>> Currently I have implemented logic which showing there (JSOnly),
> but
> >> I
> >>>>>>> thought that we can have such information in those files.
> >>>>>>>
> >>>>>>> May proposition having your thoughts in mind are:
> >>>>>>>
> >>>>>>> Royale JS: "Apache Royale 0.9.0 en_US (JS)"
> >>>>>>> Royale ASJS: "Apache Royale 0.9.0 FP11.7 AIR14.0 en_US (JS,
SWF)"
> >>>>>>>
> >>>>>>> The question is where actually this file is created ? I
will try to
> >>>>>>> find
> >>>>>>> code, but any tip would be great.
> >>>>>>>
> >>>>>>> Thanks, Piotr
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>> --
> >>>>>>> Sent from:
> >>>>>>>
> >> https://na01.safelinks.protection.outlook.com/?url=
> http%3A%2F%2Fapache-r <https://na01.safelinks.protection.outlook.com/?url=
> http%3A%2F%2Fapache-r> <
> >> https://na01.safelinks.protection.outlook.com/?url=
> http%3A%2F%2Fapache-r <https://na01.safelinks.protection.outlook.com/?url=
> http%3A%2F%2Fapache-r>>
> >>>>>>> oyale-development.20373.n8.nabble.com <http://oyale-development.
> 20373.n8.nabble.com/> <
> >> http://oyale-development.20373.n8.nabble.com/ <
> http://oyale-development.20373.n8.nabble.com/>
> >>> %2F&data=02%7C01%7Caharui%40adobe.c
> >>>>>>>
> >> om%7C2a19eab2ec1f4efeea9b08d54f7923c0%7Cfa7b1b5a7b34438794aed2c178de
> cee1
> >>>>>>>
> >> %7C0%7C0%7C636502304073200067&sdata=cWk4J6XPAOiogm4%
> 2BnrSw7AEYnIgtP7c4ZF
> >>>>>>> U2Z184T3A%3D&reserved=0
> >>>>>>>
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>> --
> >>>>>>
> >>>>>> Piotr Zarzycki
> >>>>>>
> >>>>>> Patreon:
> >>>>>> *
> >> https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fwww.pat <https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fwww.pat> <
> >> https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fwww.pat <https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fwww.pat>>
> >>>>>> reon.com <http://reon.com/> <http://reon.com/ <http://reon.com/>>%
> 2Fpiotrzarzycki&data=02%7C01%7Caharui%
> >> 40adobe.com <http://40adobe.com/> <http://40adobe.com/ <
> http://40adobe.com/>>%7C2a19eab2ec1f
> >>>>>>
> >> 4efeea9b08d54f7923c0%7Cfa7b1b5a7b34438794aed2c178de
> cee1%7C0%7C0%7C6365023
> >>>>>>
> >> 04073200067&sdata=trB5QDMp7NylryBjWLUQjFzP2grJoO
> jEk7yv3aoQKbg%3D&reserved
> >>>>>> =0
> >>>>>>
> >>>>>> <
> >> https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fwww.pat <https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fwww.pat> <
> >> https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fwww.pat <https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fwww.pat>>
> >>>>>> reon.com <http://reon.com/> <http://reon.com/ <http://reon.com/>>%
> 2Fpiotrzarzycki&data=02%7C01%7Caharui%
> >> 40adobe.com <http://40adobe.com/> <http://40adobe.com/ <
> http://40adobe.com/>>%7C2a19eab2ec1f
> >>>>>>
> >> 4efeea9b08d54f7923c0%7Cfa7b1b5a7b34438794aed2c178de
> cee1%7C0%7C0%7C6365023
> >>>>>>
> >> 04073200067&sdata=trB5QDMp7NylryBjWLUQjFzP2grJoO
> jEk7yv3aoQKbg%3D&reserved
> >>>>>> =0>*
> >>>>>>
> >>>>>
> >>>>>
> >>>>>
> >>>>> --
> >>>>>
> >>>>> Piotr Zarzycki
> >>>>>
> >>>>> Patreon:
> >>>>> *
> >> https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fwww.patr <https://na01.safelinks.
> protection.outlook.com/?url=https%3A%2F%2Fwww.patr>
> >> <https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fwww.patr <https://na01.safelinks.
> protection.outlook.com/?url=https%3A%2F%2Fwww.patr>
> >>>
> >>>>> eon.com <http://eon.com/> <http://eon.com/ <http://eon.com/>>%
> 2Fpiotrzarzycki&data=02%7C01%7Caharui%
> >> 40adobe.com <http://40adobe.com/> <http://40adobe.com/ <
> http://40adobe.com/>>%7C2a19eab2ec1f4e
> >>>>>
> >> feea9b08d54f7923c0%7Cfa7b1b5a7b34438794aed2c178de
> cee1%7C0%7C0%7C6365023040
> >>>>>
> >> 73200067&sdata=trB5QDMp7NylryBjWLUQjFzP2grJoO
> jEk7yv3aoQKbg%3D&reserved=0
> >>>>> <
> >> https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fwww.patr <https://na01.safelinks.
> protection.outlook.com/?url=https%3A%2F%2Fwww.patr>
> >> <https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fwww.patr <https://na01.safelinks.
> protection.outlook.com/?url=https%3A%2F%2Fwww.patr>
> >>>
> >>>>> eon.com <http://eon.com/> <http://eon.com/ <http://eon.com/>>%
> 2Fpiotrzarzycki&data=02%7C01%7Caharui%
> >> 40adobe.com <http://40adobe.com/> <http://40adobe.com/ <
> http://40adobe.com/>>%7C2a19eab2ec1f4e
> >>>>>
> >> feea9b08d54f7923c0%7Cfa7b1b5a7b34438794aed2c178de
> cee1%7C0%7C0%7C6365023040
> >>>>>
> >> 73200067&sdata=trB5QDMp7NylryBjWLUQjFzP2grJoO
> jEk7yv3aoQKbg%3D&reserved=0>*
>
>


-- 

Piotr Zarzycki

Patreon: *https://www.patreon.com/piotrzarzycki
<https://www.patreon.com/piotrzarzycki>*

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message