Mailing-List: contact dev-help@royale.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@royale.apache.org
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\))
Subject: Re: [royale-asjs] branch develop updated: Fixed event dispatching on tba view change
From: Harbs <harbs.lists@gmail.com>
In-Reply-To: <151178147455.7244.16892257237469906462@gitbox.apache.org>
Date: Mon, 27 Nov 2017 13:40:14 +0200
Content-Transfer-Encoding: quoted-printable
Message-Id: <CC318014-6E8B-43C4-AB51-805E8AD64908@gmail.com>
References: <151178147455.7244.16892257237469906462@gitbox.apache.org>
To: dev@royale.apache.org
archived-at: Mon, 27 Nov 2017 11:40:24 -0000

I=E2=80=99m not sure that viewChanged is the best event to be =
dispatching here.

It turns out that viewChanged is dispatched in two unrelated cases:
1. When the IViewManagerView is assigned to the ViewManagerBase.
2. When the current view is set by the IViewManagerView.

The way it is, it=E2=80=99s currently difficult to differentiate between =
the two cases.

It feels like the correct event to be dispatching for case 2 is =
=E2=80=9CcurrentViewChanged=E2=80=9D or =E2=80=9CactiveViewChanged=E2=80=9D=
 or =E2=80=9CselectedViewChanged=E2=80=9D.

Thoughts?

Harbs

> On Nov 27, 2017, at 1:17 PM, harbs@apache.org wrote:
>=20
> This is an automated email from the ASF dual-hosted git repository.
>=20
> harbs pushed a commit to branch develop
> in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
>=20
>=20
> The following commit(s) were added to refs/heads/develop by this push:
>     new 6711a8d  Fixed event dispatching on tba view change
> 6711a8d is described below
>=20
> commit 6711a8d137ecca2d4dfaa48f1c0689282157df47
> Author: Harbs <harbs@in-tools.com>
> AuthorDate: Mon Nov 27 13:17:42 2017 +0200
>=20
>    Fixed event dispatching on tba view change
>=20
>    Removed an extra layoutNeeded
>    Dispatch viewChanged
> ---
> .../org/apache/royale/mobile/beads/TabbedViewManagerView.as      | 9 =
+++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>=20
> diff --git =
a/frameworks/projects/Mobile/src/main/royale/org/apache/royale/mobile/bead=
s/TabbedViewManagerView.as =
b/frameworks/projects/Mobile/src/main/royale/org/apache/royale/mobile/bead=
s/TabbedViewManagerView.as
> index 64c7b80..bef33ee 100644
> --- =
a/frameworks/projects/Mobile/src/main/royale/org/apache/royale/mobile/bead=
s/TabbedViewManagerView.as
> +++ =
b/frameworks/projects/Mobile/src/main/royale/org/apache/royale/mobile/bead=
s/TabbedViewManagerView.as
> @@ -104,6 +104,11 @@ package org.apache.royale.mobile.beads
> 	=09
> 		private var _currentView:IViewManagerView;
> 	=09
> +		/**
> +		 * @royaleignorecoercion org.apache.royale.core.UIBase
> +		 * @royaleignorecoercion =
org.apache.royale.mobile.IViewManagerView
> +		 * @royaleignorecoercion =
org.apache.royale.mobile.IViewManager
> +		 */
> 		protected function showViewByIndex(index:int):void
> 		{
> 			var model:ViewManagerModel =3D =
_strand.getBeadByType(IBeadModel) as ViewManagerModel;
> @@ -117,9 +122,8 @@ package org.apache.royale.mobile.beads
> 		=09
> 			COMPILE::JS {
> 				if (_currentView) {
> -					=
UIBase(_currentView).element.style["flex-grow"] =3D "1";
> +					(_currentView as =
UIBase).element.style["flex-grow"] =3D "1";
> 				}
> -				getHost().dispatchEvent(new =
Event("layoutNeeded"));
> 			}
> 			COMPILE::SWF {
> 				if (UIBase(_currentView).style =3D=3D =
null) {
> @@ -131,6 +135,7 @@ package org.apache.royale.mobile.beads
> 		=09
> 			// Now that the view has changed, refresh the =
layout on this component.
> 			getHost().dispatchEvent(new =
Event("layoutNeeded"));
> +			getHost().dispatchEvent(new =
Event("viewChanged"));
> 		}
> 		protected function =
insertCurrentView(view:IViewManagerView):void{
> 			getHost().addElementAt(view,(navigationBar ? 1 : =
0));
>=20
> --=20
> To stop receiving notification emails like this one, please contact
> ['"commits@royale.apache.org" <commits@royale.apache.org>'].