royale-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yishay Weiss <yishayj...@hotmail.com>
Subject RE: [royale-asjs] branch develop updated: isHeightSizedToContent is a method, not a prop
Date Tue, 21 Nov 2017 11:29:11 GMT
Should there be a compiler warning when methods are implicitly converted to Booleans?



________________________________
From: yishayw@apache.org <yishayw@apache.org>
Sent: Tuesday, November 21, 2017 1:24:31 PM
To: commits@royale.apache.org
Subject: [royale-asjs] branch develop updated: isHeightSizedToContent is a method, not a prop

This is an automated email from the ASF dual-hosted git repository.

yishayw pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git


The following commit(s) were added to refs/heads/develop by this push:
     new 6dd1416  isHeightSizedToContent is a method, not a prop
     new 93febf1  Merge branch 'develop' of https://github.com/apache/royale-asjs into develop
6dd1416 is described below

commit 6dd1416ed790c99604ed4d0e96edbfb630354ecf
Author: DESKTOP-RH4S838\Yishay <yishayjobs@hotmail.com>
AuthorDate: Tue Nov 21 13:19:12 2017 +0200

    isHeightSizedToContent is a method, not a prop
---
 .../main/royale/org/apache/royale/html/beads/layouts/TileLayout.as    | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/beads/layouts/TileLayout.as
b/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/beads/layouts/TileLayout.as
index ce06f4e..63182bb 100644
--- a/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/beads/layouts/TileLayout.as
+++ b/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/beads/layouts/TileLayout.as
@@ -152,7 +152,7 @@ package org.apache.royale.html.beads.layouts
                                 if (isNaN(useHeight)) {
                                         // given the width and total number of items, how
many rows?
                                         var numRows:Number = Math.floor(realN/numColumns);
-                                       if (host.isHeightSizedToContent) useHeight = 30; //
default height
+                                       if (host.isHeightSizedToContent()) useHeight = 30;
// default height
                                         else useHeight = Math.floor(adjustedHeight / numRows);
                                 }

@@ -229,7 +229,7 @@ package org.apache.royale.html.beads.layouts
                                 if (isNaN(useHeight)) {
                                         // given the width and total number of items, how
many rows?
                                         var numRows:Number = Math.floor(realN / numColumns);
-                                       if (host.isHeightSizedToContent) useHeight = 30; //
default height
+                                       if (host.isHeightSizedToContent()) useHeight = 30;
// default height
                                         else useHeight = Math.floor(adjustedHeight / numRows);
                                 }


--
To stop receiving notification emails like this one, please contact
['"commits@royale.apache.org" <commits@royale.apache.org>'].

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message