royale-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Piotr Zarzycki <piotrzarzyck...@gmail.com>
Subject Re: [royale-compiler] 09/20: change more flexjs to royale per Issue #17
Date Thu, 05 Oct 2017 05:02:36 GMT
I believe there are options to change pushed commit messages, but I see
that you already created issues, so we can stick with it.

Btw. Make sure that branch for renaming have same name for typedefs and
asjs repo. Create them in order to monitor changes for Maven.

Thanks,
Piotr

On Thu, Oct 5, 2017, 05:17 Alex Harui <aharui@adobe.com.invalid> wrote:

> I came up with an idea.  I created enough issues to track other things I
> noticed in changing over to Royale such that I could create issue #17 for
> the change over.
>
> HTH,
> -Alex
>
> On 10/4/17, 7:58 PM, "Alex Harui" <aharui@adobe.com.INVALID> wrote:
>
> >Hi Piotr,
> >
> >I have no idea how to fix this.  I will try to do better next time.
> >
> >Sorry,
> >-Alex
> >
> >On 10/4/17, 3:43 PM, "Piotr Zarzycki" <piotrzarzycki21@gmail.com> wrote:
> >
> >>Hi Alex,
> >>
> >>If we would like to point to the issue in commit message from one repo
> >>(royale-compiler) to the other one (royale-asjs) - it should look:
> >>
> >>"Commit message (reference apache/royale-asjs#17) - Commit message to
> >>royale-compiler, but issue is raised in royale-asjs.
> >>
> >>If some day in royale-compiler we will raise issue number 17 those
> >>commits
> >>may point to that.
> >>
> >>Thanks,
> >>Piotr
> >>
> >>
> >>2017-10-05 0:35 GMT+02:00 <aharui@apache.org>:
> >>
> >>> This is an automated email from the ASF dual-hosted git repository.
> >>>
> >>> aharui pushed a commit to branch feature/rename
> >>> in repository
> >>>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox
> .
> >>>a
> >>>pache.org
> %2Frepos%2Fasf%2Froyale-compiler.git&data=02%7C01%7C%7C60118b04
> >>>c
> >>>c804aff6eb608d50b7966f8%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636
> >>>4
> >>>27538410858041&sdata=z7fhOECHDeBHnMINms5g4FeootpfFJAi3HV3S9z2aug%3D&rese
> >>>r
> >>>ved=0
> >>>
> >>> commit ff91950a9a5b41c5dac21cca06f91c0a01a8cd23
> >>> Author: Alex Harui <aharui@apache.org>
> >>> AuthorDate: Tue Oct 3 11:42:24 2017 -0700
> >>>
> >>>     change more flexjs to royale per Issue #17
> >>> ---
> >>>  .../royale/maven/{flexjs => }/extension/FlexJsLanguageSupport.java 
|
> >>>6
> >>> +++---
> >>>  .../royale/maven/{flexjs => }/extension/FlexJsScopeDeriver.java    
|
> >>>2
> >>> +-
> >>>  .../royale/maven/{flexjs => }/extension/FlexJsScopeSelector.java   
|
> >>>2
> >>> +-
> >>>  .../src/main/java/org/apache/royale/maven/CompileASDocMojo.java     |
> >>>2
> >>> +-
> >>>  .../src/main/java/org/apache/royale/maven/CompileASMojo.java        |
> >>>2
> >>> +-
> >>>  .../src/main/java/org/apache/royale/maven/CompileAppMojo.java       |
> >>>2
> >>> +-
> >>>  .../src/main/java/org/apache/royale/maven/CompileJSMojo.java        |
> >>>2
> >>> +-
> >>>  .../src/main/java/org/apache/royale/maven/CompileTypedefsMojo.java  |
> >>>2
> >>> +-
> >>>  8 files changed, 10 insertions(+), 10 deletions(-)
> >>>
> >>> diff --git a/royale-maven-extension/src/main/java/org/apache/royale/
> >>> maven/flexjs/extension/FlexJsLanguageSupport.java
> >>>
> >>>b/royale-maven-extension/src/main/java/org/apache/royale/maven/extension
> >>>/
> >>> FlexJsLanguageSupport.java
> >>> similarity index 92%
> >>> rename from royale-maven-extension/src/main/java/org/apache/royale/
> >>> maven/flexjs/extension/FlexJsLanguageSupport.java
> >>> rename to royale-maven-extension/src/main/java/org/apache/royale/
> >>> maven/extension/FlexJsLanguageSupport.java
> >>> index 4ae6fdd..d5707d7 100644
> >>> --- a/royale-maven-extension/src/main/java/org/apache/royale/
> >>> maven/flexjs/extension/FlexJsLanguageSupport.java
> >>> +++ b/royale-maven-extension/src/main/java/org/apache/royale/
> >>> maven/extension/FlexJsLanguageSupport.java
> >>> @@ -12,7 +12,7 @@
> >>>   * limitations under the License.
> >>>   */
> >>>
> >>> -package org.apache.royale.maven.flexjs.extension;
> >>> +package org.apache.royale.maven.extension;
> >>>
> >>>  import org.apache.maven.repository.internal.LanguageSupport;
> >>>  import org.codehaus.plexus.component.annotations.Component;
> >>> @@ -26,7 +26,7 @@ import javax.inject.Named;
> >>>   * Created by christoferdutz on 18.07.16.
> >>>   */
> >>>  @Named
> >>> -@Component( role = LanguageSupport.class, hint = "flexjs" )
> >>> +@Component( role = LanguageSupport.class, hint = "royale" )
> >>>  public class FlexJsLanguageSupport implements LanguageSupport {
> >>>
> >>>      private static final FlexJsScopeSelector SCOPE_SELECTOR = new
> >>> FlexJsScopeSelector();
> >>> @@ -38,7 +38,7 @@ public class FlexJsLanguageSupport implements
> >>> LanguageSupport {
> >>>
> >>>      @Override
> >>>      public String getLanguageName() {
> >>> -        return "flexjs";
> >>> +        return "royale";
> >>>      }
> >>>
> >>>      @Override
> >>> diff --git a/royale-maven-extension/src/main/java/org/apache/royale/
> >>> maven/flexjs/extension/FlexJsScopeDeriver.java
> >>>
> >>>b/royale-maven-extension/src/main/java/org/apache/royale/maven/extension
> >>>/
> >>> FlexJsScopeDeriver.java
> >>> similarity index 94%
> >>> rename from royale-maven-extension/src/main/java/org/apache/royale/
> >>> maven/flexjs/extension/FlexJsScopeDeriver.java
> >>> rename to royale-maven-extension/src/main/java/org/apache/royale/
> >>> maven/extension/FlexJsScopeDeriver.java
> >>> index dfa3f41..18f6013 100644
> >>> --- a/royale-maven-extension/src/main/java/org/apache/royale/
> >>> maven/flexjs/extension/FlexJsScopeDeriver.java
> >>> +++ b/royale-maven-extension/src/main/java/org/apache/royale/
> >>> maven/extension/FlexJsScopeDeriver.java
> >>> @@ -12,7 +12,7 @@
> >>>   * limitations under the License.
> >>>   */
> >>>
> >>> -package org.apache.royale.maven.flexjs.extension;
> >>> +package org.apache.royale.maven.extension;
> >>>
> >>>  import org.eclipse.aether.RepositoryException;
> >>>  import org.eclipse.aether.util.graph.transformer.ConflictResolver;
> >>> diff --git a/royale-maven-extension/src/main/java/org/apache/royale/
> >>> maven/flexjs/extension/FlexJsScopeSelector.java
> >>>
> >>>b/royale-maven-extension/src/main/java/org/apache/royale/maven/extension
> >>>/
> >>> FlexJsScopeSelector.java
> >>> similarity index 94%
> >>> rename from royale-maven-extension/src/main/java/org/apache/royale/
> >>> maven/flexjs/extension/FlexJsScopeSelector.java
> >>> rename to royale-maven-extension/src/main/java/org/apache/royale/
> >>> maven/extension/FlexJsScopeSelector.java
> >>> index f44a597..98a516f 100644
> >>> --- a/royale-maven-extension/src/main/java/org/apache/royale/
> >>> maven/flexjs/extension/FlexJsScopeSelector.java
> >>> +++ b/royale-maven-extension/src/main/java/org/apache/royale/
> >>> maven/extension/FlexJsScopeSelector.java
> >>> @@ -12,7 +12,7 @@
> >>>   * limitations under the License.
> >>>   */
> >>>
> >>> -package org.apache.royale.maven.flexjs.extension;
> >>> +package org.apache.royale.maven.extension;
> >>>
> >>>  import org.eclipse.aether.RepositoryException;
> >>>  import org.eclipse.aether.util.graph.transformer.ConflictResolver;
> >>> diff --git
> >>>a/royale-maven-plugin/src/main/java/org/apache/royale/maven/CompileASDoc
> >>>M
> >>>ojo.java
> >>> b/royale-maven-plugin/src/main/java/org/apache/royale/
> >>> maven/CompileASDocMojo.java
> >>> index dc9ab79..4fc07e8 100644
> >>> --- a/royale-maven-plugin/src/main/java/org/apache/royale/
> >>> maven/CompileASDocMojo.java
> >>> +++ b/royale-maven-plugin/src/main/java/org/apache/royale/
> >>> maven/CompileASDocMojo.java
> >>> @@ -125,7 +125,7 @@ public class CompileASDocMojo
> >>>      @Override
> >>>      protected List<String> getCompilerArgs(File configFile) throws
> >>> MojoExecutionException {
> >>>          List<String> args = super.getCompilerArgs(configFile);
> >>> -        args.add("-js-output-type=flexjs_dita");
> >>> +        args.add("-js-output-type=royale_dita");
> >>>          return args;
> >>>      }
> >>>
> >>> diff --git
> >>>a/royale-maven-plugin/src/main/java/org/apache/royale/maven/CompileASMoj
> >>>o
> >>>.java
> >>> b/royale-maven-plugin/src/main/java/org/apache/royale/
> >>> maven/CompileASMojo.java
> >>> index 654af32..6891f3e 100644
> >>> --- a/royale-maven-plugin/src/main/java/org/apache/royale/
> >>> maven/CompileASMojo.java
> >>> +++ b/royale-maven-plugin/src/main/java/org/apache/royale/
> >>> maven/CompileASMojo.java
> >>> @@ -28,7 +28,7 @@ import java.util.LinkedList;
> >>>  import java.util.List;
> >>>
> >>>  /**
> >>> - * goal which compiles a project into a flexjs swc library.
> >>> + * goal which compiles a project into a royale swc library.
> >>>   */
> >>>  @Mojo(name="compile-as",defaultPhase = LifecyclePhase.PROCESS_SOURCES)
> >>>  public class CompileASMojo
> >>> diff --git
> >>>a/royale-maven-plugin/src/main/java/org/apache/royale/maven/CompileAppMo
> >>>j
> >>>o.java
> >>> b/royale-maven-plugin/src/main/java/org/apache/royale/
> >>> maven/CompileAppMojo.java
> >>> index b2d4297..e415cdd 100644
> >>> --- a/royale-maven-plugin/src/main/java/org/apache/royale/
> >>> maven/CompileAppMojo.java
> >>> +++ b/royale-maven-plugin/src/main/java/org/apache/royale/
> >>> maven/CompileAppMojo.java
> >>> @@ -26,7 +26,7 @@ import java.io.File;
> >>>  import java.util.List;
> >>>
> >>>  /**
> >>> - * goal which compiles a project into a flexjs sef application.
> >>> + * goal which compiles a project into a royale sef application.
> >>>   */
> >>>  @Mojo(name="compile-app",defaultPhase =
> >>>LifecyclePhase.PROCESS_SOURCES)
> >>>  public class CompileAppMojo
> >>> diff --git
> >>>a/royale-maven-plugin/src/main/java/org/apache/royale/maven/CompileJSMoj
> >>>o
> >>>.java
> >>> b/royale-maven-plugin/src/main/java/org/apache/royale/
> >>> maven/CompileJSMojo.java
> >>> index 65212cd..ad207e7 100644
> >>> --- a/royale-maven-plugin/src/main/java/org/apache/royale/
> >>> maven/CompileJSMojo.java
> >>> +++ b/royale-maven-plugin/src/main/java/org/apache/royale/
> >>> maven/CompileJSMojo.java
> >>> @@ -31,7 +31,7 @@ import java.util.zip.ZipEntry;
> >>>  import java.util.zip.ZipOutputStream;
> >>>
> >>>  /**
> >>> - * goal which compiles a project into a flexjs swc library.
> >>> + * goal which compiles a project into a royale swc library.
> >>>   */
> >>>  @Mojo(name="compile-js",defaultPhase = LifecyclePhase.PROCESS_SOURCES)
> >>>  public class CompileJSMojo
> >>> diff --git
> >>>a/royale-maven-plugin/src/main/java/org/apache/royale/maven/CompileTyped
> >>>e
> >>>fsMojo.java
> >>> b/royale-maven-plugin/src/main/java/org/apache/royale/
> >>> maven/CompileTypedefsMojo.java
> >>> index d62ccbf..270bcc7 100644
> >>> --- a/royale-maven-plugin/src/main/java/org/apache/royale/
> >>> maven/CompileTypedefsMojo.java
> >>> +++ b/royale-maven-plugin/src/main/java/org/apache/royale/
> >>> maven/CompileTypedefsMojo.java
> >>> @@ -28,7 +28,7 @@ import java.util.LinkedList;
> >>>  import java.util.List;
> >>>
> >>>  /**
> >>> - * goal which compiles a project into a flexjs swc library.
> >>> + * goal which compiles a project into a royale swc library.
> >>>   */
> >>>  @Mojo(name="compile-extern",defaultPhase = LifecyclePhase.PROCESS_
> >>> SOURCES)
> >>>  public class CompileTypedefsMojo
> >>>
> >>> --
> >>> To stop receiving notification emails like this one, please contact
> >>> "commits@royale.apache.org" <commits@royale.apache.org>.
> >>>
> >>
> >>
> >>
> >>--
> >>
> >>Piotr Zarzycki
> >>
> >>mobile: +48 880 859 557
> >>skype: zarzycki10
> >>
> >>LinkedIn:
> >>
> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.linke
> >>d
> >>in.com
> %2Fpiotrzarzycki&data=02%7C01%7C%7C60118b04cc804aff6eb608d50b7966f8
> >>%
> >>7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636427538410858041&sdata=7Cg
> >>U
> >>76aMaHjve5rY7FOMXK1db%2BvM59C84Rek0pdUTOE%3D&reserved=0
> >><
> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpl.link
> >>e
> >>din.com
> %2Fin%2Fpiotr-zarzycki-92a53552&data=02%7C01%7C%7C60118b04cc804aff
> >>6
> >>eb608d50b7966f8%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636427538410
> >>8
> >>58041&sdata=Bii7kXIDfa4bv8t4H75oezgrXL4FkUZxEAs49M3DyYI%3D&reserved=0>
> >>
> >>GitHub:
> >>
> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.c
> >>o
> >>m%2Fpiotrzarzycki21&data=02%7C01%7C%7C60118b04cc804aff6eb608d50b7966f8%7C
> >>f
> >>a7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636427538410858041&sdata=qRclBU
> >>g
> >>NufxB22O%2Bmv3EPSOOQh%2FrbHm6uIWb%2BTWYbb8%3D&reserved=0
> >
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message