royale-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Harbs <harbs.li...@gmail.com>
Subject Re: [Maven] Core module reporting errors
Date Tue, 31 Oct 2017 19:19:39 GMT
Yeah. It looks like Sonar doesn’t know what to do with some valid code. In particular, it
seems to have trouble with CONFIG::debug in TLF code.

> On Oct 31, 2017, at 9:16 PM, Harbs <harbs.lists@gmail.com> wrote:
> 
> It looks like those errors are coming from SonarQube.
> 
> Some of them are definitely wrong. The following is perfectly fine code:
> 
> itIs = Language.is <http://language.is/>(leftOperand, rightOperand);
> 
> Harbs
> 
>> On Oct 31, 2017, at 9:11 PM, Harbs <harbs.lists@gmail.com <mailto:harbs.lists@gmail.com>>
wrote:
>> 
>> Interesting. It looks like there’s 18 of these.
>> 
>> What’s reporting those errors?
>> 
>> In the case of LocalFile, the error appears to be a real error. I don’t know why
the compiler didn’t catch that.
>> 
>> In the case of AMFBinaryData, it’s a weird construct, but I’m not sure whether
it’s valid code or not:
>> if (e == 0)
>>    (i = v * Math.pow(2, 23) / 2, v = Math.round(v * POW_2_52 / 2))
>> 
>>> On Oct 31, 2017, at 8:19 PM, Piotr Zarzycki <piotrzarzycki21@gmail.com <mailto:piotrzarzycki21@gmail.com>>
wrote:
>>> 
>>> Hi Guys,
>>> 
>>> I just looked into the Maven latest build [1] and I see errors reported in
>>> module Core. Build itself is not failing, but it should be actually.
>>> 
>>> Just search console build using [ERROR] [2]. The worse thing is that I'm
>>> not getting those problems in my local Maven build.
>>> 
>>> [1] https://builds.apache.org/job/Royale-asjs/180/consoleFull <https://builds.apache.org/job/Royale-asjs/180/consoleFull>
>>> [2] https://paste.apache.org/bk0F <https://paste.apache.org/bk0F>
>>> 
>>> Piotr,
>>> -- 
>>> 
>>> Piotr Zarzycki
>>> 
>>> mobile: +48 880 859 557
>>> skype: zarzycki10
>>> 
>>> LinkedIn: http://www.linkedin.com/piotrzarzycki <http://www.linkedin.com/piotrzarzycki>
>>> <https://pl.linkedin.com/in/piotr-zarzycki-92a53552 <https://pl.linkedin.com/in/piotr-zarzycki-92a53552>>
>>> 
>>> GitHub: https://github.com/piotrzarzycki21 <https://github.com/piotrzarzycki21>
>> 
> 


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message