royale-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From carlosrov...@apache.org
Subject [royale-asjs] branch develop updated: fix toggle in some code for IE11
Date Mon, 17 Sep 2018 13:59:16 GMT
This is an automated email from the ASF dual-hosted git repository.

carlosrovira pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git


The following commit(s) were added to refs/heads/develop by this push:
     new 0eeb6b7  fix toggle in some code for IE11
0eeb6b7 is described below

commit 0eeb6b7fd98319aa733444a232f13ba34b3127c3
Author: Carlos Rovira <carlosrovira@apache.org>
AuthorDate: Mon Sep 17 15:59:08 2018 +0200

    fix toggle in some code for IE11
---
 .../main/royale/org/apache/royale/jewel/Drawer.as  |  2 +-
 .../royale/jewel/beads/layouts/GridLayout.as       |  2 +-
 .../supportClasses/textinput/TextInputBase.as      | 42 +++++++++++-----------
 3 files changed, 22 insertions(+), 24 deletions(-)

diff --git a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/Drawer.as b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/Drawer.as
index 4377bd1..500927f 100644
--- a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/Drawer.as
+++ b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/Drawer.as
@@ -133,7 +133,7 @@ package org.apache.royale.jewel
 					document.body.classList.remove("viewport");
 				} else
 				{
-					document.body.classList.toggle("viewport", _isOpen);
+					_isOpen ? document.body.classList.add("viewport") : document.body.classList.remove("viewport")
 				}
 			}
 		}
diff --git a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/layouts/GridLayout.as
b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/layouts/GridLayout.as
index 451f435..2c1c380 100644
--- a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/layouts/GridLayout.as
+++ b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/layouts/GridLayout.as
@@ -117,7 +117,7 @@ package org.apache.royale.jewel.beads.layouts
 		COMPILE::JS
 		private function setGap(value:Boolean):void
 		{
-			hostClassList.toggle("gap", value);
+			value ? hostClassList.add("gap") : hostClassList.remove("gap");
 		}
 
 		// protected var _gap:Number = 0;
diff --git a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/supportClasses/textinput/TextInputBase.as
b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/supportClasses/textinput/TextInputBase.as
index f3ce7f5..34cd0b5 100644
--- a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/supportClasses/textinput/TextInputBase.as
+++ b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/supportClasses/textinput/TextInputBase.as
@@ -244,28 +244,26 @@ package org.apache.royale.jewel.supportClasses.textinput
 		 */
         public var div:HTMLDivElement;
 
-        private var _isInvalid:Boolean = false;
-        /**
-		 *  A boolean flag to activate "is-invalid" effect selector.
-         *  Defines the textinput as invalid on initial load.
-         *  Optional
-		 *
-		 *  @langversion 3.0
-		 *  @playerversion Flash 10.2
-		 *  @playerversion AIR 2.6
-		 *  @productversion Royale 0.9.4
-		 */
-        public function get isInvalid():Boolean
-        {
-            return _isInvalid;
-        }
-        public function set isInvalid(value:Boolean):void
-        {
-            _isInvalid = value;
+        // private var _isInvalid:Boolean = false;
+        // /**
+		//  *  A boolean flag to activate "is-invalid" effect selector.
+        //  *  Defines the textinput as invalid on initial load.
+        //  *  Optional
+		//  *
+		//  *  @langversion 3.0
+		//  *  @playerversion Flash 10.2
+		//  *  @playerversion AIR 2.6
+		//  *  @productversion Royale 0.9.4
+		//  */
+        // public function get isInvalid():Boolean
+        // {
+        //     return _isInvalid;
+        // }
+        // public function set isInvalid(value:Boolean):void
+        // {
+        //     _isInvalid = value;
 
-            toggleClass("is-invalid", _isInvalid);
-            //positioner.classList.toggle("is-invalid", _isInvalid);
-            //typeNames = positioner.className;
-        }
+        //     toggleClass("is-invalid", _isInvalid);
+        // }
 	}
 }


Mime
View raw message