royale-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ha...@apache.org
Subject [royale-asjs] branch develop updated: Setting stringables a second time caused bad things to happen.
Date Wed, 15 Nov 2017 19:17:02 GMT
This is an automated email from the ASF dual-hosted git repository.

harbs pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git


The following commit(s) were added to refs/heads/develop by this push:
     new cb62cec  Setting stringables a second time caused bad things to happen.
cb62cec is described below

commit cb62cec4e506eac91f19b92b4b3e75228f6f0693
Author: Harbs <harbs@in-tools.com>
AuthorDate: Wed Nov 15 21:16:56 2017 +0200

    Setting stringables a second time caused bad things to happen.
---
 frameworks/projects/XML/src/main/royale/XML.as | 2 +-
 manualtests/XMLTest/src/MyInitialView.mxml     | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/frameworks/projects/XML/src/main/royale/XML.as b/frameworks/projects/XML/src/main/royale/XML.as
index 34da441..c151d2d 100644
--- a/frameworks/projects/XML/src/main/royale/XML.as
+++ b/frameworks/projects/XML/src/main/royale/XML.as
@@ -2078,7 +2078,7 @@ package
 					removeChild(chldrn[i]);
 				}
 				chld = chldrn[i];
-				chld.appendChild(stringable);
+				chld.setChildren(stringable);
 				return chld;
 			}
 			
diff --git a/manualtests/XMLTest/src/MyInitialView.mxml b/manualtests/XMLTest/src/MyInitialView.mxml
index 742fc99..1734384 100644
--- a/manualtests/XMLTest/src/MyInitialView.mxml
+++ b/manualtests/XMLTest/src/MyInitialView.mxml
@@ -119,6 +119,8 @@ limitations under the License.
 				newContent.Properties.Leading = 36;
 				trace("Leading should be @type=string: " + (newContent.Properties.Leading.@type=="string"));
 				trace("Leading should be 36: " + newContent.Properties.Leading);
+				newContent.Properties.Leading = 72;
+				trace("Leading should be 72: " + newContent.Properties.Leading);
 
         var child:XML = <pop><child name="Sam"/></pop>;
         xml1.appendChild(child);

-- 
To stop receiving notification emails like this one, please contact
['"commits@royale.apache.org" <commits@royale.apache.org>'].

Mime
View raw message