From commits-return-10272-archive-asf-public=cust-asf.ponee.io@roller.apache.org Sat May 11 21:17:03 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id BCBC9180651 for ; Sat, 11 May 2019 23:17:02 +0200 (CEST) Received: (qmail 81235 invoked by uid 500); 11 May 2019 21:17:02 -0000 Mailing-List: contact commits-help@roller.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@roller.apache.org Delivered-To: mailing list commits@roller.apache.org Received: (qmail 81226 invoked by uid 99); 11 May 2019 21:17:02 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 11 May 2019 21:17:02 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 35D10E2BD2 for ; Sat, 11 May 2019 21:17:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id A02AB2581A for ; Sat, 11 May 2019 21:17:00 +0000 (UTC) Date: Sat, 11 May 2019 21:17:00 +0000 (UTC) From: "David Johnson (JIRA)" To: commits@roller.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ROL-2137) Require setting rememberme.key MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ROL-2137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16837934#comment-16837934 ] David Johnson commented on ROL-2137: ------------------------------------ PR is ready for review https://github.com/apache/roller/pull/27 > Require setting rememberme.key > ------------------------------- > > Key: ROL-2137 > URL: https://issues.apache.org/jira/browse/ROL-2137 > Project: Apache Roller > Issue Type: Improvement > Reporter: David Johnson > Assignee: David Johnson > Priority: Major > Fix For: 5.2.3 > > Time Spent: 10m > Remaining Estimate: 0h > > If you are going to enable rememberMe in Roller then you really MUST set a unique (and secret) key for Spring Security's remember me feature. > Change Roller so that remember-me will not work unless a ''rememberme.key' property set and it is set to something other than the old default value 'springRocks' -- This message was sent by Atlassian JIRA (v7.6.3#76005)