roller-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kohei Nozaki (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (ROL-2087) "macro.weblog.searchgoogle" in translated ApplicationResources produces wrong Google URL
Date Sat, 05 Dec 2015 02:07:10 GMT

     [ https://issues.apache.org/jira/browse/ROL-2087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Kohei Nozaki updated ROL-2087:
------------------------------
    Attachment: ROL-2087.patch

Replaced the expression for the query parameter {{q}} in translated ones by default (English)
one.

> "macro.weblog.searchgoogle" in translated ApplicationResources produces wrong Google
URL
> ----------------------------------------------------------------------------------------
>
>                 Key: ROL-2087
>                 URL: https://issues.apache.org/jira/browse/ROL-2087
>             Project: Apache Roller
>          Issue Type: Bug
>    Affects Versions: 5.1.2
>            Reporter: Kohei Nozaki
>            Assignee: Roller Unassigned
>            Priority: Minor
>         Attachments: ROL-2087.patch
>
>
> {{ApplicationResources.properties}} has an entry which is for produce a hyperlink for
Google search as follows:
> {noformat}
> macro.weblog.searchgoogle=<em>You can also \
> <a href="http://google.com/search?q={0}%20site:{1}/{3}" \
> class="google">try this same search</a> on Google.</em>
> {noformat}
> The same entry in {{ApplicationResources_ja.properties}}:
> {noformat}
> macro.weblog.searchgoogle=<em>Google\u3067<a href="http://www.google.co.jp/search?q={0}%20site:{1}/page/{3}"
class="google">...</a>...</em>
> {noformat}
> For example, This produces a hyperlink for the something like following URL:
> {{http://www.google.co.jp/search?q=someWord%20site:https://roller.example.com/page/myblog}}
> I believe the part {{/page/}} in translated resources is unnecessary and it makes the
search result will contain only the pages under {{/page/}} so I think the part {{/page/}}
should be removed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message