Return-Path: 
 <commits-return-9325-apmail-roller-commits-archive=roller.apache.org@roller.apache.org>
X-Original-To: apmail-roller-commits-archive@www.apache.org
Delivered-To: apmail-roller-commits-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 97AC517575
	for <apmail-roller-commits-archive@www.apache.org>;
 Sun,  1 Mar 2015 19:13:05 +0000 (UTC)
Received: (qmail 30665 invoked by uid 500); 1 Mar 2015 19:13:05 -0000
Delivered-To: apmail-roller-commits-archive@roller.apache.org
Received: (qmail 30636 invoked by uid 500); 1 Mar 2015 19:13:05 -0000
Mailing-List: contact commits-help@roller.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:commits-help@roller.apache.org>
List-Unsubscribe: <mailto:commits-unsubscribe@roller.apache.org>
List-Post: <mailto:commits@roller.apache.org>
List-Id: <commits.roller.apache.org>
Reply-To: dev@roller.apache.org
Delivered-To: mailing list commits@roller.apache.org
Received: (qmail 30627 invoked by uid 99); 1 Mar 2015 19:13:05 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 01 Mar 2015 19:13:05 +0000
Date: Sun, 1 Mar 2015 19:13:05 +0000 (UTC)
From: "David Johnson (JIRA)" <jira@apache.org>
To: commits@roller.apache.org
Message-ID: <JIRA.12778433.1425091125000.47105.1425237185455@Atlassian.JIRA>
In-Reply-To: <JIRA.12778433.1425091125000@Atlassian.JIRA>
References: <JIRA.12778433.1425091125000@Atlassian.JIRA>
 <JIRA.12778433.1425091125203@arcas>
Subject: [jira] [Updated] (ROL-2065) Gaurav renders the summary of an entry
 as unresolved "$entry.summary" while no summary in the entry
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


     [ https://issues.apache.org/jira/browse/ROL-2065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Johnson updated ROL-2065:
-------------------------------
    Fix Version/s: 5.1.2

> Gaurav renders the summary of an entry as unresolved "$entry.summary" while no summary in the entry
> ---------------------------------------------------------------------------------------------------
>
>                 Key: ROL-2065
>                 URL: https://issues.apache.org/jira/browse/ROL-2065
>             Project: Apache Roller
>          Issue Type: Bug
>          Components: Themes and Macros
>    Affects Versions: 5.1.1
>            Reporter: Kohei Nozaki
>            Assignee: David Johnson
>            Priority: Minor
>             Fix For: 5.1.2
>
>         Attachments: ROL-2065.patch
>
>
> day.vm in Gaurav checks existence of summary in following code:
> {code:html}
> #if($entry.summary != "")
>     <p>$entry.summary</p>
>     <a class="btn btn-primary" href="$url.entry($entry.anchor)">Read More <i class="icon-angle-right"></i></a>
> #else
>     <p>$entry.displayContent</p>
> #end
> {code}
> I experienced WEBLOGENTRY.SUMMARY went null accidentally (https://twitter.com/lbtc_xxx/status/549181370908430338). in such case, Gaurav thinks the summary is exist and render it as "$entry.summary". I don't know how summary went null, but the db schema allows null so I guess changing comparison logic to more safer one (use $utils.isNotEmpty() instead) is reasonable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)