roller-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Johnson (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (ROL-2065) Gaurav renders the summary of an entry as unresolved "$entry.summary" while no summary in the entry
Date Sun, 01 Mar 2015 18:29:04 GMT

     [ https://issues.apache.org/jira/browse/ROL-2065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

David Johnson resolved ROL-2065.
--------------------------------
    Resolution: Fixed
      Assignee: David Johnson  (was: Roller Unassigned)

Thanks to Kohei.

Author: snoopdave
Date: Sun Mar  1 18:23:58 2015
New Revision: 1663144

URL: http://svn.apache.org/r1663144
Log:
ROL-2065 fix for Gaurav renders the summary of an entry as unresolved .summary while no summary
in the entry

Modified:
    roller/trunk/app/src/main/webapp/themes/gaurav/day.vm

> Gaurav renders the summary of an entry as unresolved "$entry.summary" while no summary
in the entry
> ---------------------------------------------------------------------------------------------------
>
>                 Key: ROL-2065
>                 URL: https://issues.apache.org/jira/browse/ROL-2065
>             Project: Apache Roller
>          Issue Type: Bug
>          Components: Themes and Macros
>    Affects Versions: 5.1.1
>            Reporter: Kohei Nozaki
>            Assignee: David Johnson
>            Priority: Minor
>         Attachments: ROL-2065.patch
>
>
> day.vm in Gaurav checks existence of summary in following code:
> {code:html}
> #if($entry.summary != "")
>     <p>$entry.summary</p>
>     <a class="btn btn-primary" href="$url.entry($entry.anchor)">Read More <i
class="icon-angle-right"></i></a>
> #else
>     <p>$entry.displayContent</p>
> #end
> {code}
> I experienced WEBLOGENTRY.SUMMARY went null accidentally (https://twitter.com/lbtc_xxx/status/549181370908430338).
in such case, Gaurav thinks the summary is exist and render it as "$entry.summary". I don't
know how summary went null, but the db schema allows null so I guess changing comparison logic
to more safer one (use $utils.isNotEmpty() instead) is reasonable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message