roller-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Glen Mazza (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ROL-2002) https:// URLs not being processed correctly in the comment URL field
Date Thu, 26 Jun 2014 03:05:24 GMT

    [ https://issues.apache.org/jira/browse/ROL-2002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14044297#comment-14044297
] 

Glen Mazza commented on ROL-2002:
---------------------------------

Greg, this issue needs a little more work unfortunately -- emails are fine, problem with the
URL validation being too strict though.

Right now, a user can no longer enter "www.cnn.com" or "football.com" as a URL, it gets reported
back as an invalid URL, we're requiring them to type in http:// or https:// which is too onerous
for your average blog commenter.  You can see how it was before the change on my blog:  https://web-gmazza.rhcloud.com/blog/entry/creating-jconsole-alternative,
cnn.com or www.cnn.com would be fine (and prefixed by Roller with an http:// if you did a
comment preview) -- the problem was that if the user puts in https://  Roller would incorrectly
add http:// to that as well, http://https:// ... that's all I'm trying to fix.

We don't need a full URL parser, if we can just capture some of the common-sense stuff that
would be good enough even if it accepts many invalid URLs that way.  (The blogger can reject
the comment if the URL is overly wacky.)  Maybe just check that there's at least one dot (period)
in the URL and if a "://" appears in the URL, that only http or https precedes it.  But even
no validation is acceptable for 5.1, so long as we're not again prepending http:// to https://.


> https:// URLs not being processed correctly in the comment URL field
> --------------------------------------------------------------------
>
>                 Key: ROL-2002
>                 URL: https://issues.apache.org/jira/browse/ROL-2002
>             Project: Apache Roller
>          Issue Type: Bug
>          Components: Comments
>    Affects Versions: 5.1
>            Reporter: Glen Mazza
>            Assignee: Greg Huber
>             Fix For: 5.1
>
>
> If a commenter has an https:// URL, Roller incorrectly prepends an http:// to it, for
example:  http://https://web-gmazza.rhcloud.com/blog



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message