Mailing-List: contact commits-help@roller.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@roller.apache.org
Date: Sun, 18 Aug 2013 16:17:48 +0000 (UTC)
From: "Glen Mazza (JIRA)" <jira@apache.org>
To: commits@roller.apache.org
Message-ID: <JIRA.12421085.1180029352920.86710.1376842668413@arcas>
In-Reply-To: <JIRA.12421085.1180029352920@arcas>
References: <JIRA.12421085.1180029352920@arcas>
Subject: [jira] [Commented] (ROL-1434) lots of UI messaging needs to be
 converted to i18n keys in resource bundles
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/ROL-1434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13743254#comment-13743254 ] 

Glen Mazza commented on ROL-1434:
---------------------------------

Yes and no.  For certain types of exceptions (sufficiently uncommon/odd ones in particular), it's best for it not to be i18n'ed so it's easier to search the web by the exception string for the problem and its solution.

                
> lots of UI messaging needs to be converted to i18n keys in resource bundles
> ---------------------------------------------------------------------------
>
>                 Key: ROL-1434
>                 URL: https://issues.apache.org/jira/browse/ROL-1434
>             Project: Roller
>          Issue Type: Task
>          Components: Struts2 Migration
>            Reporter: Allen Gilliland
>            Assignee: Roller Unassigned
>
> As part of the struts2 migration a large amount of work was done to prevent our UI code from blindly throwing exceptions which are unhandled and provide no valuable response back to users.  In a wide variety of places throughout the struts2 code there are message strings which are returned which aren't i18n keys coming from the resource bundles.
> Most of these places should be marked in the code via the comment ... // TODO: i18n
> The work here is just to go through the code, find these places, and convert raw strings into i18n keys in the resource bundles.
> NOTE: this same situation applies for all the struts2 validation files which currently list i18n keys which may not exist in the resource bundles and need to be added as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira