roller-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Glen Mazza (JIRA)" <>
Subject [jira] [Reopened] (ROL-1229) Rename RefererManager to ReferrerManager
Date Tue, 02 Apr 2013 14:49:17 GMT


Glen Mazza reopened ROL-1229:

> Rename RefererManager to ReferrerManager
> ----------------------------------------
>                 Key: ROL-1229
>                 URL:
>             Project: Roller
>          Issue Type: Improvement
>    Affects Versions: 3.0
>            Reporter: Craig L Russell
>            Assignee: Glen Mazza
>            Priority: Minor
> Craig L Russell wrote:
> I noticed (again with 3.0) that the ReferrerManager interface name is misspelled. According
to my IDE, there are 35 occurrences of this interface name in the entire source code.
> It seems that 3.0 might be the right time to fix this.
> If everyone agrees, I can provide a patch. I don't think I should check it in, because
I'm not comfortable enough with making sure that I didn't cause a regression because of a
missed update.
> Craig
> Allen responded:
> I agree that we should rename it, but I think it's too late to do this for 3.0.  We've
already spent way too much time testing/refining the release to go in and do a sweeping change
that touches lots of classes.
> Also, I don't think there is any reason that change can't be made for the next release.
 I would actually prefer that we do a single rename for all of our classes rather than keep
picking at them one at a time. For example I would be a strong supporter of a few other renamings
> 1. Website -> Weblog
> 2. Remove "Data" from the names of all the pojos.
> 3. Referer -> Referrer
> 4. Index -> Search
> and probably a few others if I looked harder.  so rather than try to squeeze this in
for 3.0, why don't we plan to make it a feature for 3.1 and do a more complete renaming.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

View raw message