roller-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shelan Perera (JIRA)" <j...@apache.org>
Subject [jira] Commented: (ROL-1907) Inefficient use of key set iterator.
Date Sun, 06 Mar 2011 17:15:25 GMT

    [ https://issues.apache.org/jira/browse/ROL-1907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13003188#comment-13003188
] 

Shelan Perera commented on ROL-1907:
------------------------------------

Actually in brief i have changed get(key) look up occurrences to entry.getValue(). and key
will get the same entry.getKey(). I ran all the test and built before submitting the patch.
Further after your comment add entries to the post and check and see if the order of the blog
entries are preserved. (I am not sure i have covered all the sanity test to cover the changes).I
tried to preserve the logic and do only the change for the look up operation.

AFAIK there is no effect on the order as i call entrySet().Iterator() which is similar as
keySet.iterator().It would be really helpful if you can review the changes :).





> Inefficient use of key set iterator.
> ------------------------------------
>
>                 Key: ROL-1907
>                 URL: https://issues.apache.org/jira/browse/ROL-1907
>             Project: Roller
>          Issue Type: Improvement
>            Reporter: Shelan Perera
>            Assignee: David Johnson
>            Priority: Minor
>         Attachments: keyset-improvement.patch
>
>
> use of keySet iterator instead of entrySet iterator.It is efficient to use entryset instead
of using .get(key) look up.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message