roller-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matt Raible (JIRA)" <j...@apache.org>
Subject [jira] Updated: (ROL-1845) Improve weblog.vm to allow clicking on the current theme
Date Thu, 05 Nov 2009 04:02:32 GMT

     [ https://issues.apache.org/jira/browse/ROL-1845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Matt Raible updated ROL-1845:
-----------------------------

    Attachment: weblog.vm.patch

Attached patch with suggested changes. Additionally includes minor HTML fixes (classes and
ids) to allow easier styling of form elements.

> Improve weblog.vm to allow clicking on the current theme
> --------------------------------------------------------
>
>                 Key: ROL-1845
>                 URL: https://issues.apache.org/jira/browse/ROL-1845
>             Project: Roller
>          Issue Type: Improvement
>          Components: Macros
>    Affects Versions: 5.0
>            Reporter: Matt Raible
>            Assignee: Roller Unassigned
>         Attachments: weblog.vm.patch
>
>
> Current:
> #** 
> Show weblog's categories in specified parent category.
> *#
> #macro(showWeblogCategoryLinksList $categoryObject $subcats $expanding )
>     #if ($expanding) #_showCommonJavascript() #end
>     #if(!$expanding && !$subcats)
>         <ul class="rCategory">
>         #if ($model.weblogCategory)
>            <li><a href="$url.category($categoryObject.path)">$text.get("macro.weblog.allcategories")</a></li>
>         #else
>            <li class="selected">$text.get("macro.weblog.allcategories")</li>
>         #end
>         #set($cats = $categoryObject.getWeblogCategories())
>         #foreach($cat in $cats)
>             #if($model.weblogCategory && $model.weblogCategory.path == $cat.path)
>                 <li class="selected">$cat.name</li>
>             #else
>                 <li><a href="$url.category($cat.path)">$cat.name</a></li>
>             #end
>         #end
>         </ul>
>     #else
>         <ul class="rCategory">
>         #_showWeblogCategoryLinksList($categoryObject $subcats $expanding )
>         </ul>
>     #end
> #end
> Suggested improved version:
> #** 
> Show weblog's categories in specified parent category.
> *#
> #macro(showWeblogCategoryLinksList $categoryObject $subcats $expanding )
>     #if ($expanding) #_showCommonJavascript() #end
>     #if(!$expanding && !$subcats)
>         <ul class="rCategory">
>         #if ($model.weblogCategory || $model.permalink)
>             <li><a href="$url.category($categoryObject.path)">$text.get("macro.weblog.allcategories")</a></li>
>         #else
>             <li class="selected"><a href="$url.category($categoryObject.path)">$text.get("macro.weblog.allcategories")</a></li>
>         #end
>         #set($cats = $categoryObject.getWeblogCategories())
>         #foreach($cat in $cats)
>             #if ($model.weblogCategory && $model.weblogCategory.path == $cat.path
|| ($model.permalink && $model.weblogEntry.category.path == $cat.path))
>                 <li class="selected"><a href="$url.category($cat.path)">$cat.name</a></li>
>             #else
>                 <li><a href="$url.category($cat.path)">$cat.name</a></li>
>             #end
>         #end
>         </ul>
>     #else
>         <ul class="rCategory">
>         #_showWeblogCategoryLinksList($categoryObject $subcats $expanding )
>         </ul>
>     #end
> #end

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message