roller-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Greg Huber (JIRA)" <j...@apache.org>
Subject [jira] Commented: (ROL-1803) Comments.jsp
Date Tue, 26 May 2009 08:36:45 GMT

    [ https://issues.apache.org/jira/browse/ROL-1803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12712908#action_12712908
] 

Greg Huber commented on ROL-1803:
---------------------------------

Dave,

I think with the DateUtil.getEndOfDay(newDate) I was trying to get a 
single "day" of comments only.  eg I had to have todays date and tomorrows 
date set in the date boxes.  Think the date is from midnight, so using 
endofday made sure the sql worked.

Cheers Greg





"Dave Johnson (JIRA)" <jira@apache.org> 
24/05/2009 04:13

To
greghnospam@ricoh.co.uk
cc

Subject
[jira] Commented: (ROL-1803) Comments.jsp







    [ 
https://issues.apache.org/jira/browse/ROL-1803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12712488#action_12712488

] 

Dave Johnson commented on ROL-1803:
-----------------------------------

Great bug report, as usual Greg.

I fixed the issue with the missing parenthesis on length()
   http://svn.apache.org/viewvc?rev=778077&view=rev

But, I don't understand what you are trying to fix with "return 
DateUtil.getEndOfDay(newDate);" -- don't we want to use the actual start 
and finish dates and not use current time for end date?

Thanks,
- Dave


.length().  The servlet will never get used!
for the query:

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.




Share our environment commitment - conserve resources and contribute to 
the reduction of CO2 emissions by not printing the email unless absolutely 
necessary to do so.

Any opinions expressed are those of the author, not Ricoh UK Ltd. This 
communication does not constitute either offer or acceptance of any 
contractually binding agreement. Such offer or acceptance must be 
communicated in writing. It is the responsibility of the recipient to 
ensure this email and attachments are free from computer viruses before 
use and the sender accepts no responsibility or liability for any such 
computer viruses.

Ricoh UK Ltd. may monitor the content of emails sent and received via its 
network for the purpose of ensuring compliance with its policies and 
procedures. This communication contains information, which may be 
confidential or privileged. The information is intended solely for the use 
of the individual or entity named above. If you are not the intended 
recipient, be aware that any disclosure, copying, distribution or use of 
the contents of this information is prohibited. If you have received this 
communication in error, please notify the sender immediately by return 
email with a copy to postmaster@ricoh.co.uk. Please contact us on +44 (0) 
208 261 4000 if you need assistance.

Registered in England No: 473236
VAT No: GB524161280 


> Comments.jsp 
> -------------
>
>                 Key: ROL-1803
>                 URL: https://issues.apache.org/jira/browse/ROL-1803
>             Project: Roller
>          Issue Type: Bug
>    Affects Versions: 5.0
>            Reporter: Greg Huber
>            Assignee: Dave Johnson
>            Priority: Trivial
>
> hello,
> In comments.jsp there is a line #334 <s:if test="#comment.content.length > 1000">
this needs to be 
> <s:if test="#comment.content.length() > 1000"> for it to work, ie .length().
 The servlet will never get used!
> Also, possibly in CommentsBean/GlobalCommentsBean, to make more sense for the query:
>     public Date getEndDate() {
>         if(!StringUtils.isEmpty(getEndDateString())) 
>         try {
>             DateFormat df = new SimpleDateFormat("MM/dd/yy");
>             return df.parse(getEndDateString());
>         } catch(Exception e) { }
>         return null;
>     }
> needs to be:
>    public Date getEndDate() {
>         if(!StringUtils.isEmpty(getEndDateString())) 
>         try {
>             DateFormat df = new SimpleDateFormat("MM/dd/yy");
>             //return df.parse(getEndDateString());
>             return DateUtil.getEndOfDay(newDate); <<<<<<<<<<<<<<<<<
>         } catch(Exception e) { }
>         return null;
>     }
> Cheers Greg

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message